Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9cfbf6b9fd40
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e8b397caca6f
Choose a head ref
  • 12 commits
  • 126 files changed
  • 6 contributors

Commits on Jul 21, 2023

  1. Improve handling of certain icons in RTL (#130979) 

    Fixes #130978 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @guidezpl
    guidezpl authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    0919fb8 View commit details
    Browse the repository at this point in the history

  2. [CI/FTL] Oriole to Panther, presubmit false (#130912) 

    Alternative to #130868

Oriole is the Pixel 6, Panther is the Pixel 7. Panther is more available in FTL at this point.

There's less value in running this on presubmit, since those can spawn many jobs multiple times over as people push new commits to branches. Let's just run it post submit to avoid overloading the capacity of FTL.
    @dnfield
    dnfield authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    764095c View commit details
    Browse the repository at this point in the history

  3. Suggest a potential valid name for the flutter project when using `fl… 

    …utter create` (#130900)

Fixes #109775

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
    @ValentinVignal
    ValentinVignal authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    be7c7e3 View commit details
    Browse the repository at this point in the history

  4. Manual roll Flutter Engine from f5c1650c7acc to acb5d0640b6c (10 revi… 

    …sions) (#131070)

Manual roll requested by [email protected]

flutter/engine@f5c1650...acb5d06

2023-07-21 [email protected] Revert Dart (flutter/engine#43895)
2023-07-21 [email protected] Roll Fuchsia Linux SDK from CWNVmH6f_iryKU05E... to gpjF3QRGg_KH0guW5... (flutter/engine#43894)
2023-07-21 [email protected] Roll Skia from 8388ec4d242c to e3d13d1b1c42 (1 revision) (flutter/engine#43893)
2023-07-21 [email protected] Roll Dart SDK from 6e79151ce988 to 921613a055ff (1 revision) (flutter/engine#43892)
2023-07-21 [email protected] Roll Skia from 3dd45617581b to 8388ec4d242c (1 revision) (flutter/engine#43891)
2023-07-21 [email protected] Roll ANGLE from b60068009dca to 2e190280f5c5 (2 revisions) (flutter/engine#43890)
2023-07-21 [email protected] Roll ANGLE from f2e0f8a0b236 to b60068009dca (1 revision) (flutter/engine#43887)
2023-07-21 [email protected] Roll Dart SDK from 8662af7d9aa3 to 6e79151ce988 (2 revisions) (flutter/engine#43885)
2023-07-21 [email protected] Roll Fuchsia Mac SDK from -SaPL-46jpiYbnCAu... to WH3AaCa4DtVERww1v... (flutter/engine#43884)
2023-07-21 [email protected] Roll Skia from 4857e876d8cf to 3dd45617581b (1 revision) (flutter/engine#43883)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from CWNVmH6f_iry to gpjF3QRGg_KH
  fuchsia/sdk/core/mac-amd64 from -SaPL-46jpiY to WH3AaCa4DtVE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    65c77f4 View commit details
    Browse the repository at this point in the history

  5. Upgrade to newer leak_tracker. (#131085)

    @polina-c
    polina-c authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    30c005f View commit details
    Browse the repository at this point in the history

  6. Manual roll Flutter Engine from acb5d0640b6c to 2d8cff44261b (3 revis… 

    …ions) (#131092)

Manual roll requested by [email protected]

flutter/engine@acb5d06...2d8cff4

2023-07-21 [email protected] Refactor: fix typo "setup" -> "set up" (flutter/engine#43824)
2023-07-21 [email protected] [engine] disable picture complexity raster caching (flutter/engine#43897)
2023-07-21 [email protected] Roll Skia from e3d13d1b1c42 to 1f84e9d51bba (1 revision) (flutter/engine#43896)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    99a4f7e View commit details
    Browse the repository at this point in the history

  7. Remove obsolete work around for shadow drawing (#131066) 

    Fixes #130737.
    @goderbauer
    goderbauer authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    9a726e8 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. Roll Flutter Engine from 2d8cff44261b to 840bcc3449ff (11 revisions) (#… 

    …131101)

flutter/engine@2d8cff4...840bcc3

2023-07-21 [email protected] Roll ANGLE from f586ec98d924 to 938ee1e80fc8 (1 revision) (flutter/engine#43912)
2023-07-21 [email protected] Roll ANGLE from 085f25bbb1e3 to f586ec98d924 (1 revision) (flutter/engine#43908)
2023-07-21 [email protected] Roll Fuchsia Mac SDK from WH3AaCa4DtVERww1v... to rMFZIJYvVmXEBGCay... (flutter/engine#43907)
2023-07-21 [email protected] [Impeller] Do not use clear color optimization if the subpass is being collapsed into its parent (flutter/engine#43878)
2023-07-21 [email protected] Roll Skia from 2e28fe9de378 to 359d4726e423 (1 revision) (flutter/engine#43906)
2023-07-21 [email protected] [Impeller] Disable color attachment removal for clips on VK (flutter/engine#43905)
2023-07-21 [email protected] [Impeller] Add a way to query the gfx backend type. (flutter/engine#43837)
2023-07-21 [email protected] Roll ANGLE from 82d68c577b1d to 085f25bbb1e3 (1 revision) (flutter/engine#43904)
2023-07-21 [email protected] Roll ANGLE from 2e190280f5c5 to 82d68c577b1d (1 revision) (flutter/engine#43901)
2023-07-21 [email protected] Roll Skia from 497326dc66cd to 2e28fe9de378 (2 revisions) (flutter/engine#43900)
2023-07-21 [email protected] Roll Skia from 1f84e9d51bba to 497326dc66cd (1 revision) (flutter/engine#43899)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from WH3AaCa4DtVE to rMFZIJYvVmXE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Jul 22, 2023
    Configuration menu
    Copy the full SHA
    3e67e19 View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from 840bcc3449ff to b47cf14fda0e (3 revisions) (#… 

    …131109)

flutter/engine@840bcc3...b47cf14

2023-07-22 [email protected] [Impeller] size command pools to npot of command count. (flutter/engine#43903)
2023-07-22 [email protected] Roll Skia from c79c781a3ce3 to 80e101dc5813 (1 revision) (flutter/engine#43914)
2023-07-22 [email protected] Roll Skia from 359d4726e423 to c79c781a3ce3 (2 revisions) (flutter/engine#43913)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Jul 22, 2023
    Configuration menu
    Copy the full SHA
    6b97716 View commit details
    Browse the repository at this point in the history

  3. Roll Flutter Engine from b47cf14fda0e to 6344b17a2e03 (1 revision) (#… 

    …131114)

flutter/engine@b47cf14...6344b17

2023-07-22 [email protected] Roll Fuchsia Linux SDK from gpjF3QRGg_KH0guW5... to LZJYHQeLdXALTMMmj... (flutter/engine#43917)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from gpjF3QRGg_KH to LZJYHQeLdXAL

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Jul 22, 2023
    Configuration menu
    Copy the full SHA
    fd2e6b8 View commit details
    Browse the repository at this point in the history

  4. Roll Flutter Engine from 6344b17a2e03 to 481684a6e276 (2 revisions) (#… 

    …131118)

flutter/engine@6344b17...481684a

2023-07-22 [email protected] Roll Fuchsia Mac SDK from rMFZIJYvVmXEBGCay... to UgZ9epS2Jkz7Yrymp... (flutter/engine#43922)
2023-07-22 [email protected] Roll Skia from 80e101dc5813 to 85e8d8403b45 (1 revision) (flutter/engine#43921)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from rMFZIJYvVmXE to UgZ9epS2Jkz7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Jul 22, 2023
    Configuration menu
    Copy the full SHA
    d460804 View commit details
    Browse the repository at this point in the history

  5. Setup leak tracking regression for material. (#130169)

    @polina-c
    polina-c authored Jul 22, 2023
    Configuration menu
    Copy the full SHA
    e8b397c View commit details
    Browse the repository at this point in the history
Loading