-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: 95be76ab7e3d
head repository: flutter/flutter
compare: b0188cd18274
- 10 commits
- 53 files changed
- 8 contributors
Commits on Jun 14, 2023
-
Unpin flutter_plugin_android_lifecycle (#128898)
Unpins flutter_plugin_android_lifecycle where it is pinned. I then 1. ran `flutter update-packages --force-upgrade` (but only committed the changes within `dev/integration_tests/gradle_deprecated_settings/`, which is where it had been pinned) 2. followed by `./gradlew :generateLockfiles` from `dev/integration_tests/gradle_deprecated_settings/android/` (the lockfile was what was causing the CI dependency resolution failure, so this second step is the fix for that). See the reason it was pinned: #121847 (comment) followed by the PR that pinned it: #122043 Fixes #122039
Configuration menu - View commit details
-
Copy full SHA for 944d6c8 - Browse repository at this point
Copy the full SHA 944d6c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d520b64 - Browse repository at this point
Copy the full SHA d520b64View commit details -
Remove temporary default case for PointerSignalKind (#128900)
This PR cleans up some prep that was added as part of #120731 which was done to unblock flutter/engine#39637 Since the work done in that PR was reverted, this should be removed. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing.
Configuration menu - View commit details
-
Copy full SHA for 4effd9c - Browse repository at this point
Copy the full SHA 4effd9cView commit details -
ContextAction.isEnabled needs a context (#127721)
...and lots of things that fall out from that
Configuration menu - View commit details
-
Copy full SHA for 34f39a2 - Browse repository at this point
Copy the full SHA 34f39a2View commit details -
Improve the error message for non-normalized constraints (#127906)
We probably added RenderBox.layout after this error was created and of course we weren't writing tests back then...
Configuration menu - View commit details
-
Copy full SHA for d64332a - Browse repository at this point
Copy the full SHA d64332aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed3d463 - Browse repository at this point
Copy the full SHA ed3d463View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d95086 - Browse repository at this point
Copy the full SHA 7d95086View commit details -
Fix inconsistently suffixed macOS flavored bundle directory (#127997)
The current implementation of macOS flavor support (#119564) assumes a bundle directory that differs from both the iOS implementation and the official documentation. The [documentation](https://docs.flutter.dev/deployment/flavors) instructs developers to suffix their Xcode build configurations with `-<flavor>`, but the implementation assumes a space: https://github.com/flutter/flutter/blob/5fd9ef4240d3fc239f042f49b8eb1ad24260091f/packages/flutter_tools/lib/src/macos/application_package.dart#L174-L178 Whereas the iOS implementation, which is the reference for the docs, assumes a `-<flavor>` suffix: https://github.com/flutter/flutter/blob/a257efc2841ed7042322fbd043f0983e705d7da2/packages/flutter_tools/lib/src/ios/xcodeproj.dart#L482-L488 This change replaces the empty space with the `-` character which is in line with the documentation and iOS implementation, as well as removing the sentence-casing applied to the flavor name; every bundle built with a flavor keeps the original flavor name in its filename. *List which issues are fixed by this PR. You must list at least one issue.* #122684. *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Configuration menu - View commit details
-
Copy full SHA for 6d2b5ea - Browse repository at this point
Copy the full SHA 6d2b5eaView commit details
Commits on Jun 15, 2023
-
[flutter_tools] cache flutter sdk version to disk (#124558)
Fixes #112833 Most of the actual changes here are in [packages/flutter_tools/lib/src/version.dart](https://github.com/flutter/flutter/pull/124558/files#diff-092e00109d9e1589fbc7c6de750e29a6ae512b2dd44e85d60028953561201605), while the rest is largely just addressing changes to the constructor of `FlutterVersion` which now has different dependencies. This change makes `FlutterVersion` an interface with two concrete implementations: 1. `_FlutterVersionGit` which is mostly the previous implementation, and 2. `_FlutterVersionFromFile` which will read a new `.version.json` file from the root of the repo The [`FlutterVersion` constructor](https://github.com/flutter/flutter/pull/124558/files#diff-092e00109d9e1589fbc7c6de750e29a6ae512b2dd44e85d60028953561201605R70) is now a factory that first checks if `.version.json` exists, and if so returns an instance of `_FlutterVersionFromGit` else it returns the fallback `_FlutterVersionGit` which will end up writing `.version.json` so that we don't need to re-calculate the version on the next invocation. `.version.json` will be deleted in the bash/batch entrypoints any time we need to rebuild he tool (this will usually be because the user did `flutter upgrade` or `flutter channel`, or manually changed the commit with git).
Configuration menu - View commit details
-
Copy full SHA for 3246808 - Browse repository at this point
Copy the full SHA 3246808View commit details -
[web] Pass creation params to the platform view factory (#128146)
This concludes step 1 of the `HtmlElementView` improvements. It's now possible to pass creation params to platform view factories directly from `HtmlElementView`. Here's a sample app using a single factory to render platform views in different colors: <details> <summary>Code sample</summary> ```dart import 'dart:js_interop'; import 'dart:ui_web' as ui_web; import 'package:flutter/material.dart'; import 'package:web/web.dart' as web; void main() { runApp(MyApp()); } class MyApp extends StatelessWidget { @OverRide Widget build(BuildContext context) { return MaterialApp( title: 'Platform View Demo', home: Scaffold( appBar: AppBar( title: Text('Platform View Demo'), ), body: Center( child: Column( mainAxisAlignment: MainAxisAlignment.spaceEvenly, children: [ BoxWrapper('red'), BoxWrapper(null), BoxWrapper('blue'), ], ), ), ), ); } } bool isRegistered = false; class BoxWrapper extends StatelessWidget { const BoxWrapper(this.cssColor); final String? cssColor; void register() { if (isRegistered) return; isRegistered = true; ui_web.platformViewRegistry.registerViewFactory('my-platform-view', ( id, { Object? params, }) { params as String?; final element = web.document.createElement('div'.toJS) as web.HTMLElement; element.textContent = 'Platform View'.toJS; element.style ..lineHeight = '100px'.toJS ..fontSize = '24px'.toJS ..backgroundColor = (params ?? 'pink').toJS ..textAlign = 'center'.toJS; return element; }); } @OverRide Widget build(BuildContext context) { register(); return SizedBox( width: 200, height: 100, child: Card( child: HtmlElementView( viewType: 'my-platform-view', creationParams: cssColor, ), ), ); } } ``` </details>  Depends on flutter/engine#42255 Part of #127030Configuration menu - View commit details
-
Copy full SHA for b0188cd - Browse repository at this point
Copy the full SHA b0188cdView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 95be76ab7e3d...b0188cd18274