Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 92a6bfbfd6ef
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 38217906e95c
Choose a head ref
  • 17 commits
  • 65 files changed
  • 17 contributors

Commits on Aug 7, 2025

  1. Adds deprecation for impeller opt out on android (#173375) 

    fixes #173122

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    @gaaclarke
    gaaclarke authored Aug 7, 2025
    Configuration menu
    Copy the full SHA
    18e7e64 View commit details
    Browse the repository at this point in the history

  2. [web] add --static-assets-url argument to build web (#171638) 

    Closes #171637

As mentioned in the issue, I am proposing a new argument to the flutter
build web command: `--static-assets-url`.

This argument would accept a full URL string ending with `/` as its
value. During the build process, the Flutter tool would use this value
to replace a dedicated placeholder within the `web/index.html` file
(inspired by `--base-href` approach).

Example Implementation:

A developer would modify their `web/index.html` to use a new
placeholder, for instance, `$FLUTTER_STATIC_ASSETS_URL`:

```html
...
<body>
  <script>
    {{flutter_js}}
    {{flutter_build_config}}

    _flutter.loader.load({
      config: {
        entryPointBaseUrl: "$FLUTTER_STATIC_ASSETS_URL",
      },
      onEntrypointLoaded: async function (engineInitializer) {
        const appRunner = await engineInitializer.initializeEngine({
          assetBase: "$FLUTTER_STATIC_ASSETS_URL",
        });

        await appRunner.runApp();
      },
    });
  </script>
</body>
...
 ```

The build command would be run with the new flag: `flutter build web --static-assets-url="https://static.company.com/some-webapp/“` - and the resulting `build/web/index.html` would have the placeholder replaced: 

```html
...
<body>
  <script>
    {{flutter_js}}
    {{flutter_build_config}}

    _flutter.loader.load({
      config: {
        entryPointBaseUrl: "https://static.company.com/some-webapp/",
      },
      onEntrypointLoaded: async function (engineInitializer) {
        const appRunner = await engineInitializer.initializeEngine({
          assetBase: "https://static.company.com/some-webapp/",
        });

        await appRunner.runApp();
      },
    });
  </script>
</body>
...
```
    @micaelcid
    micaelcid authored Aug 7, 2025
    Configuration menu
    Copy the full SHA
    3be0441 View commit details
    Browse the repository at this point in the history

  3. Manual roll to 3.10.0-75.1.beta (#173423) 

    Manual roll to 3.10.0-75.1.beta

```
6fe971b4c9b (HEAD, origin/lkgr-dev) Version 3.10.0-75.0.dev
c5eba845382 [analysis_server] Dot shorthands: Code completion for methods and constructors.
0cf15f211a4 [analysis_server] Fix change_method_signature tests to normalize code
62caf711fa1 Bump analyzer-related package version numbers
d4101733532 Ignore TODOs in analyzer_utilities package.
f2c73a7a3f0 [analysis_server] Fix DTD test EOLs on Windows
1cf804e1fe1 [vm, compiler] Fix Load[D]FromOffset for offsets with bits 21-23 set on ARM.
```
    @aam
    aam authored Aug 7, 2025
    Configuration menu
    Copy the full SHA
    1256b44 View commit details
    Browse the repository at this point in the history

  4. [ios26]Do not report error for Info.plist key not found (#172913) 

    In xcode_backend's `runSync` function, there's a flag parameter
`allowFail`. The purpose of this flag is that, when enabled, even if
command fails, we should not fail Xcode.

However, the current implementation has a bug, that even when `allowFail
= true`, we still prefix `"error:"` string to `stderr`, which causes
Xcode compilation error.

Before macOS 26, plutil used `stdout` rather than `stderr`, so the bug
was not surfaced. On macOS 26, pltuil uses `stderr` instead (which makes
sense), so the bug is surfaced now.

Note: even if plutil doesn't change behavior on macOS 26, if I randomly
come across this code, I'd still fix the logic error.

*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*

Fixes #172627

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Jenn Magder <[email protected]>
    @hellohuanlin @jmagman
    hellohuanlin and jmagman authored Aug 7, 2025
    Configuration menu
    Copy the full SHA
    c4b0be1 View commit details
    Browse the repository at this point in the history

  5. Fix ReorderableList proxy animation for partial drag-back (#172380) 

    _**Note:** Alongside this PR, I've also prepared [another
PR](#172882) with an alternative
solution involving a more substantial refactor that addresses the root
cause, rather than adding more conditional logic._

## Description

This PR fixes the proxy animation bug where dragging a `ReorderableList`
item downward and then back to its original position causes it to
animate to the wrong location (one position too low).

## The Problem

When dragging a `ReorderableList` item downward and then back to its
original position, the proxy widget briefly animates to the wrong
location (one position too low) before snapping to the correct spot.

**Reproduction**: Drag any item down past at least one other item, then
drag it back to where it started.

<p align="center">
<img
src="https://github.com/user-attachments/assets/d0931dff-5600-441c-8536-2c61789767d0"
alt="demo2" width="250">
</p>

## Root Cause

This bug is specific to dragging an item down and then bringing it back
up to nearly (but not 100% of the way ) to its original position:

1. When the item approaches its original position **from below**,
`_insertIndex` becomes `item.index + 1`
- This happens because Flutter's `ReorderableList` calculates
`_insertIndex` with the dragged item still present in the list (see
#24786)
2. The proxy _should_ animate to the item's original position at
`item.index`
    - _But the proxy actually animates one position too low._
    - This happens because `_dragEnd` incorrectly calculates 
    `_finalDropPosition = _itemOffsetAt(_insertIndex! - 1) +
  _extentOffset(...)`
- The `_extentOffset(...)` addition, designed for items dropping
_between other items_, shifts the position down by one item's height
- The correct calculation for "returning home from below" should be just
`_itemOffsetAt(_insertIndex! - 1)`

Note that this only occurs when returning from below (`_insertIndex >
item.index`). Dragging upward (in a vertical list for example) or
doesn't trigger this bug.

## Existing Implementation

The existing `_dragEnd` method in `reorderable_list.dart`:

```dart
void _dragEnd(_DragInfo item) {
  setState(() {
    if (_insertIndex == item.index) {
      _finalDropPosition = _itemOffsetAt(_insertIndex!);
    } else if (_reverse) {
      if (_insertIndex! >= _items.length) {
        _finalDropPosition =
            _itemOffsetAt(_items.length - 1) - _extentOffset(item.itemExtent, _scrollDirection);
      } else {
        _finalDropPosition =
            _itemOffsetAt(_insertIndex!) +
            _extentOffset(_itemExtentAt(_insertIndex!), _scrollDirection);
      }
    } else {
      if (_insertIndex! == 0) {
        _finalDropPosition = _itemOffsetAt(0) - 
          _extentOffset(item.itemExtent, _scrollDirection);
      } else {
        _finalDropPosition = _itemOffsetAt(_insertIndex! - 1) +
          _extentOffset(_itemExtentAt(_insertIndex! - 1), _scrollDirection);
      }
    }
  });
}
```

When returning from below, the code falls through to the final else
block, which incorrectly adds `_extentOffset`.

## Fix

Detect when `_insertIndex - item.index == 1` (indicating a return to
original position from below) and animate to the correct position.

```dart
if (_insertIndex! - item.index == 1) {
  // Drop at the original position when item returns from below
  _finalDropPosition = _itemOffsetAt(_insertIndex! - 1);
}
```

This fix was proposed by @frankpape in
#90856 (comment);
I've merely validated and researched the background of why the fix
works, and supported it with tests.

**_Demo of the fixed implementation:_**
<p align="center">
<img
src="https://github.com/user-attachments/assets/a53e8920-ebca-4326-abe9-3b43b34419e5"
alt="fixed" width="250">
</p>

Fixes #88331
Fixes #90856
Fixes #150843

## A note about a previous PR: 

While investigating this issue, I found a PR addressing what seemed to
be [the same exact
issue](#150843): PR #151026; it
turns out that that PR solved a _portion_ of the edge case: the case
where an item is dragged down and back and slightly **overshoots** its
original position when being dragged back & dropped—but that PR did not
account for the presence of this bug when the dragged item slightly
**undershoots** its original position on the return drag. This new PR
effectively addresses the 'undershooting' case.

With this, I've added a new pair of regression tests that are identical
to the [previous PR's
tests](https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/reorderable_list_test.dart#L734),
except for the fact that they simulate an undershoot on the return trip
(90% of the way back instead of 110% like the original tests). This
definitively captures the issue, failing in the master branch and
passing in this PR's branch.

Here is the specific case resolved by the [**old**
PR](#151026):
<table>
  <tr>
    <td align="center">
<img
src="https://github.com/user-attachments/assets/b0ddc745-6e9e-4f12-97da-454e2e76b06d"
alt="Before" width="200"><br>
      <sub>Before</sub>
    </td>
    <td align="center">
<img
src="https://github.com/user-attachments/assets/03e181fa-f43b-4405-b0c0-16d3465ad990"
alt="After" width="200"><br>
      <sub>After</sub>
    </td>
  </tr>
</table>

Here is the additional case resolved by **this** PR:
<table>
  <tr>
    <td align="center">
<img
src="https://github.com/user-attachments/assets/9b4bb591-aa2f-4cf0-88b8-a3ec32b0f0ac"
alt="Before" width="200"><br>
      <sub>Before</sub>
    </td>
    <td align="center">
<img
src="https://github.com/user-attachments/assets/31646e9c-78f4-4252-921f-53583193868f"
alt="After" width="200"><br>
      <sub>After</sub>
    </td>
  </tr>
</table>

Two final observations worth noting:
- The fix proposed in this PR seems to **supersede** the previous PR's
solution; it addresses both cases (overshooting and undershooting) even
in my tests with the [original PR's changes
](https://github.com/flutter/flutter/pull/151026/files#diff-23a4bb073009d89f09084bdf5f85232de135b8f11be625e6312bb85900a90e67)
reverted. Probably best to keep the old PR's code anyway to be
conservative, but noteworthy.
- I also found it notable that neither this PR nor the older PR fix any
issue with "reversed lists", which, in my tests, are simply not subject
to this edge case as we've defined it. The regression tests added for
the reverse case are thus purely precautionary.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    @lukemmtt
    lukemmtt authored Aug 7, 2025
    Configuration menu
    Copy the full SHA
    b6e78b9 View commit details
    Browse the repository at this point in the history

  6. Prepare for iOS debugging with lldb and devicectl (#173417) 

    This PR introduces new classes and methods needed to transition to using
`devicectl` (for installing and launching) and `lldb` (for debugging)
for deploying apps to iOS 17+ physical devices.

The new classes/methods are not used yet to reduce risk for
cherry-picking. A follow up PR will adopt them.

Part 1 of #173416.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    @vashworth
    vashworth authored Aug 7, 2025
    Configuration menu
    Copy the full SHA
    b57c974 View commit details
    Browse the repository at this point in the history

  7. Fix ScaffoldGeometry null scale with noAnimation FAB (#172914) 

    Fixes #172866
When using FloatingActionButtonAnimator.noAnimation to disable FAB
animations, the ScaffoldGeometry logic that drives the BottomAppBar’s
notch and shape fails because the floatingActionButtonScale is null,
leading to a runtime error during the paint phase.

This fix ensures that when the noAnimation animator is used, the FAB
geometry is returned without applying any scale transformation, safely
bypassing the null floatingActionButtonScale and preventing the error.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    @Mairramer
    Mairramer authored Aug 7, 2025
    Configuration menu
    Copy the full SHA
    601cde6 View commit details
    Browse the repository at this point in the history

  8. Remove a couple of asserts from display_list_unittest (#173381) 

    Skia is updating some of the semantics around SkPath simple shape
inference [1]. Specifically, degenerate rounded rects are to be
reflected as simple rects instead of rrects.

The display list assertions should be sufficient for these tests.

This PR unblocks the Skia-side change.

[1] https://skia-review.googlesource.com/c/skia/+/1031900


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
    @fmalita
    fmalita authored Aug 7, 2025
    Configuration menu
    Copy the full SHA
    d3ecde6 View commit details
    Browse the repository at this point in the history

  9. [Android templates] Remove jetifier usage (#173431) 

    Fixes #173430

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
    @reidbaker
    reidbaker authored Aug 7, 2025
    Configuration menu
    Copy the full SHA
    052b903 View commit details
    Browse the repository at this point in the history

  10. [A11y] TextField prefix icon and suffix icon create a sibling node' (#… 

    …173312)

prefix/suffix icon should have their own merge group. 

Noted a textfield can have suffix and suffix icon the same time so they
should be different merge group.

Co-authored-by: chunhtai <[email protected]>
    @hannah-hyj @chunhtai
    hannah-hyj and chunhtai authored Aug 7, 2025
    Configuration menu
    Copy the full SHA
    cb44b5a View commit details
    Browse the repository at this point in the history

  11. Roll ICU from b929596baebf to 1b2e3e8a421e (7 revisions) (#173436) 

    https://chromium.googlesource.com/chromium/deps/icu.git/+log/b929596baebf..1b2e3e8a421e

2025-07-14 [email protected] Added foolip's chromium account and
removed syg from owners
2025-07-14 [email protected] fuzzers/icu_to_case_fuzzer.cc: Add
missing include
2025-05-27 [email protected] Make scripts/update_tz.sh work on macOS
2025-05-27 [email protected] Fix Android typos in README.chromium
2025-05-23 [email protected] Update name_5_langs.patch to avoid
whitespace errors
2025-05-22 [email protected] Add foolip to owners file
2025-05-22 [email protected] Fix tar invocation to work on macOS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/icu-sdk-flutter
Please CC [email protected],[email protected] on the revert
to ensure that a human
is aware of the problem.

To file a bug in ICU: https://github.com/unicode-org/icu
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 7, 2025
    Configuration menu
    Copy the full SHA
    9264b70 View commit details
    Browse the repository at this point in the history

  12. Web dev proxy (#172175) 

    Adding a development Proxy and dedicated Web configuration File

<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

Flutter's current web development configuration relies on CLI arguments
and does not have a development proxy. This PR adds a development proxy
to flutter and a designated web_dev_config.yaml where web configuration
settings are loaded from.

Issues:
#170834

Document:

[HERE](https://docs.google.com/document/d/1Ud9D3F0GxB5Ocoo5NnAy7PH5oo3qxvALxUlAXMCANJ0/edit?usp=sharing)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Co-authored-by: Sydney Bao <[email protected]>
Co-authored by: Salem Iranloye <[email protected]>

---------

Co-authored-by: Kevin Moore <[email protected]>
Co-authored-by: Sydney Bao <[email protected]>
    @salemiranloye @kevmoo @SydneyBao
    3 people authored Aug 7, 2025
    Configuration menu
    Copy the full SHA
    796c62b View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2025

  1. Roll Dart SDK from ba58b96a80d7 to c48772a79e1f (3 revisions) (#173451) 

    https://dart.googlesource.com/sdk.git/+log/ba58b96a80d7..c48772a79e1f

2025-08-08 [email protected]
Version 3.10.0-78.0.dev
2025-08-07 [email protected]
Version 3.10.0-77.0.dev
2025-08-07 [email protected]
Version 3.10.0-76.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC [email protected],[email protected] on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 8, 2025
    Configuration menu
    Copy the full SHA
    ff75de6 View commit details
    Browse the repository at this point in the history

  2. Roll Dart SDK from c48772a79e1f to 4b7b565eb468 (1 revision) (#173454) 

    https://dart.googlesource.com/sdk.git/+log/c48772a79e1f..4b7b565eb468

2025-08-08 [email protected]
Version 3.10.0-79.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC [email protected],[email protected] on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 8, 2025
    Configuration menu
    Copy the full SHA
    ec81e2e View commit details
    Browse the repository at this point in the history

  3. Support launching a HTTPS URL (#164720) 

    I setup a reverse proxy, but this piece of code only allows launching
HTTP URLs. I'm submitting a patch to fix the error.

See issue comment
Dart-Code/Dart-Code#5322 (comment)
for context.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    @Wdestroier
    Wdestroier authored Aug 8, 2025
    Configuration menu
    Copy the full SHA
    e4c07e8 View commit details
    Browse the repository at this point in the history

  4. Roll Fuchsia Linux SDK from i4vsuEGyP8Xeb5tiy... to HclTm0V8hgSpfqmtG… 

    …... (#173462)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 8, 2025
    Configuration menu
    Copy the full SHA
    aef15c1 View commit details
    Browse the repository at this point in the history

  5. Use LLDB as the default debugging method for iOS 17+ and Xcode 26+ (#… 

    …173443)

This PR introduces a new feature flag called `lldb-debugging`, which is
turned on by default. When this feature is turned on, if deploying to a
physical iOS 17+ device with Xcode 26+, it will use a mixture of
`devicectl` and `lldb` to install, launch, and debug the app.

If LLDB fails, it will fallback to use Xcode automation. If LLDB times
out, it will warn the user they may want to disable it. If LLDB is
disabled, it will use Xcode automation.

This PR also adds analytics to track what deployment method is used and
if it's successful.

Part 2 and 3 of #173416.

Fixes #144218. Fixes
#133465.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    @vashworth
    vashworth authored Aug 8, 2025
    Configuration menu
    Copy the full SHA
    3821790 View commit details
    Browse the repository at this point in the history
Loading