Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8dd08314d2e4
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cb26a01a40e9
Choose a head ref
  • 12 commits
  • 14 files changed
  • 5 contributors

Commits on May 24, 2024

  1. Roll Packages from 1008d9e to 7b423f5 (2 revisions) (#149043)

    flutter/packages@1008d9e...7b423f5
    
    2024-05-24 [email protected] [ci] Start moving podspec check to ARM (flutter/packages#6782)
    2024-05-24 [email protected] [webview_flutter] Adds onHttpError callback to NavigationDelegate to catch HTTP error status codes (flutter/packages#6378)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 24, 2024
    Configuration menu
    Copy the full SHA
    6861b77 View commit details
    Browse the repository at this point in the history
  2. Fix TwoDimensionalViewport's keep alive child not always removed (whe…

    …n no longer should be kept alive) (#148298)
    
    - Fixes a child not removed from `_keepAliveBucket` when widget is no longer kept alive offscreen. Bug was triggering assert in performLayout.
    - Adds test to cover the case from bug report
    
    Fixes #138977
    gawi151 authored May 24, 2024
    Configuration menu
    Copy the full SHA
    a53b78d View commit details
    Browse the repository at this point in the history
  3. Roll Flutter Engine from 4ab442475223 to 979214444aca (3 revisions) (#…

    …149045)
    
    flutter/engine@4ab4424...9792144
    
    2024-05-24 [email protected] Roll Skia from 92f576fd2c52 to 956e77ac96fd (2 revisions) (flutter/engine#53021)
    2024-05-24 [email protected] Roll Dart SDK from fef7786d65f9 to 49b226cecee7 (1 revision) (flutter/engine#53020)
    2024-05-24 [email protected] Roll Skia from 8b8cf5b49988 to 92f576fd2c52 (1 revision) (flutter/engine#53019)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 24, 2024
    Configuration menu
    Copy the full SHA
    6093a9c View commit details
    Browse the repository at this point in the history
  4. Add test for text_editing_controller.0.dart API example. (#148872)

    This PR contributes to #130459
    
    ### Description
    - Adds test for `examples/api/lib/widgets/editable_text/text_editing_controller.0.dart`
    ksokolovskyi authored May 24, 2024
    Configuration menu
    Copy the full SHA
    6a20a5b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    aa63820 View commit details
    Browse the repository at this point in the history
  6. Add tests for editable_text.on_changed.0.dart API example. (#148874)

    This PR contributes to #130459
    
    ### Description
    - Adds tests for `examples/api/lib/widgets/editable_text/editable_text.on_changed.0.dart`
    ksokolovskyi authored May 24, 2024
    Configuration menu
    Copy the full SHA
    7be97ab View commit details
    Browse the repository at this point in the history
  7. [a11y] Slider should respect bold text setting (#149053)

    Fix #147600
    
    internal GAR issue: b/316933135
    
    reopen from #148435
    hannah-hyj authored May 24, 2024
    Configuration menu
    Copy the full SHA
    8ff5709 View commit details
    Browse the repository at this point in the history
  8. [GAR][a11y] Update assessment app to unblock tester from testing dark…

    … mode (#149055)
    
    internal: b/317130300
    
    reopening #149004
    
    ## Pre-launch Checklist
    
    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [ ] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/wiki/Data-driven-Fixes
    hannah-hyj authored May 24, 2024
    Configuration menu
    Copy the full SHA
    735c3a8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    734d243 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Roll Flutter Engine from b5e98f9b8d0f to f693fdd840e8 (4 revisions) (#…

    …149057)
    
    flutter/engine@b5e98f9...f693fdd
    
    2024-05-24 [email protected] [canvaskit] Fix overlay reorganization for edge case with only 1 overlay (flutter/engine#53006)
    2024-05-24 [email protected] Roll Dart SDK from 49b226cecee7 to 4ef8ed68a8d4 (1 revision) (flutter/engine#53024)
    2024-05-24 [email protected] Roll Skia from f832549400ab to 97783ac3000d (1 revision) (flutter/engine#53023)
    2024-05-24 [email protected] [Impeller] sped up the linear gradient by moving calculations to the cpu (flutter/engine#53007)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 25, 2024
    Configuration menu
    Copy the full SHA
    5bf11bc View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from f693fdd840e8 to e0207131ea13 (7 revisions) (#…

    …149068)
    
    flutter/engine@f693fdd...e020713
    
    2024-05-24 [email protected] Roll Dart SDK from 4ef8ed68a8d4 to 641d61332238 (1 revision) (flutter/engine#53029)
    2024-05-24 [email protected] Roll Skia from 10459d97152a to 0b7d656b9c03 (3 revisions) (flutter/engine#53028)
    2024-05-24 [email protected] Reland "DisplayListBuilder internal reorganization with better rendering op overlap detection" (52646) (flutter/engine#53002)
    2024-05-24 [email protected] Roll Skia from 137a4ea4e033 to 10459d97152a (3 revisions) (flutter/engine#53027)
    2024-05-24 [email protected] Roll Skia from d252bca326a6 to 137a4ea4e033 (1 revision) (flutter/engine#53026)
    2024-05-24 [email protected] Roll Skia from 97783ac3000d to d252bca326a6 (2 revisions) (flutter/engine#53025)
    2024-05-24 [email protected] Rename Skia specific TUs. (flutter/engine#52855)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 25, 2024
    Configuration menu
    Copy the full SHA
    45d7dba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cb26a01 View commit details
    Browse the repository at this point in the history
Loading