Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8c5a1ea7281a
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a76dbe44b99e
Choose a head ref
  • 12 commits
  • 24 files changed
  • 9 contributors

Commits on May 9, 2023

  1. Configuration menu
    Copy the full SHA
    5b87e4f View commit details
    Browse the repository at this point in the history
  2. Remove dead code (#126266)

    Dead code was flagged by `unreachable_from_main` lint, which is still experimental and not ready to be enabled yet.
    goderbauer authored May 9, 2023
    Configuration menu
    Copy the full SHA
    58454e9 View commit details
    Browse the repository at this point in the history
  3. Update FocusNode documentation (#126331)

    ## Description
    
    This PR adds some details in FocusNode documentation to explain more precisely when listeners are notified.
    
    ## Related Issue
    
    Fixes #126149
    
    ## Tests
    
    Documentation only.
    bleroux authored May 9, 2023
    Configuration menu
    Copy the full SHA
    a800edf View commit details
    Browse the repository at this point in the history
  4. Roll Flutter Engine from 8d3a8162b3ab to 824cd09b8c62 (10 revisions) (#…

    …126309)
    
    flutter/engine@8d3a816...824cd09
    
    2023-05-09 [email protected] Increase timeout of orchestrator. (flutter/engine#41839)
    2023-05-09 [email protected] [fuchsia] Stop calling FIDL from Dart in Flutter integration tests (flutter/engine#41669)
    2023-05-09 [email protected] [tests] Remove unused fuchsia.sys protocol reference (flutter/engine#41826)
    2023-05-09 [email protected] Roll Skia from 7736fbaf84f0 to 485cd3d0f9ca (6 revisions) (flutter/engine#41840)
    2023-05-09 [email protected] [Impeller] introduces DeviceHolder to avoid accessing a dead Device (flutter/engine#41748)
    2023-05-08 [email protected] Get rid of "outrageous" default text styles for HTML renderer. (flutter/engine#41822)
    2023-05-08 [email protected] Adjust DL filter bounds tests to not rely on exact Skia results (flutter/engine#41792)
    2023-05-08 [email protected] Roll Dart SDK from a8b6687327d6 to 498cfa57165b (1 revision) (flutter/engine#41823)
    2023-05-08 [email protected] [Android] Fix incorrect viewInsets during keyboard animation with EdgeToEdge (flutter/engine#39391)
    2023-05-08 [email protected] Roll Skia from 951eb9653163 to 7736fbaf84f0 (1 revision) (flutter/engine#41821)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 9, 2023
    Configuration menu
    Copy the full SHA
    8a7ded7 View commit details
    Browse the repository at this point in the history
  5. Fix platformLocation path and search dropping (#126232)

    This PR fixes the dropping of both the `path` and `search` fields from the platform location in the URL when using Flutter Web and brings it in par with similar technologies (e.g. React Router).
    It allows developers to keep the original path and/or search parameters in the URL, which are perfectly valid even while fragment routing is present.
    
    **Example use case:**
    Call a Flutter Web app with initial config parameters in the URL: 
    `http://my-flutter.app/?skipIntro=true`
    
    **Example:**
    Before initial routing:
    `http://localhost:45389/?foo=bar`
    After routing:
    `http://localhost:45389/#/menu`
    After routing (with fix):
    `http://localhost:45389/?foo=bar#menu`
    
    Fixes #116415
    Bungeefan authored May 9, 2023
    Configuration menu
    Copy the full SHA
    cab29b2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bf88f60 View commit details
    Browse the repository at this point in the history
  7. Roll Packages from 4800d65 to 1f91710 (8 revisions) (#126352)

    flutter/packages@4800d65...1f91710
    
    2023-05-09 [email protected] [camerax] Update README with plugin overview (flutter/packages#3891)
    2023-05-09 [email protected] Fix nullability in docs (flutter/packages#3876)
    2023-05-08 [email protected] [tools] Check version ranges when pathifying deps (flutter/packages#3943)
    2023-05-08 [email protected] [quick_actions] Update minimum iOS version to 11 (flutter/packages#3946)
    2023-05-08 [email protected] [shared_preferences] Update minimum iOS version to 11 (flutter/packages#3945)
    2023-05-08 [email protected] [path_provider] Update minimum iOS version to 11 (flutter/packages#3944)
    2023-05-08 [email protected] Adding setup for TestInstanceManagerHostApi in zoom and exposure tests (flutter/packages#3947)
    2023-05-08 [email protected] Roll Flutter from 43ac23b to 4ed1c92 (16 revisions) (flutter/packages#3942)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 9, 2023
    Configuration menu
    Copy the full SHA
    ce57932 View commit details
    Browse the repository at this point in the history
  8. Revert "Provide default constraints for M3 dialogs" (#126355)

    Reverts #120082
    
    Causing breakages: b/281181985
    itsjustkevin authored May 9, 2023
    Configuration menu
    Copy the full SHA
    a153d6d View commit details
    Browse the repository at this point in the history
  9. Roll Flutter Engine from 824cd09b8c62 to 8ca16cba8c38 (5 revisions) (#…

    …126360)
    
    flutter/engine@824cd09...8ca16cb
    
    2023-05-09 [email protected] [Impeller] track path convexity and
    use it to simplify fill tessellation. (flutter/engine#41834)
    2023-05-09 [email protected] Roll Skia from 9ba374e0b0f0 to
    8c936fb9ba8e (7 revisions) (flutter/engine#41854)
    2023-05-09 [email protected] Roll Skia from 485cd3d0f9ca to
    9ba374e0b0f0 (3 revisions) (flutter/engine#41849)
    2023-05-09 [email protected] Roll Fuchsia Mac SDK from
    oGF4h14qc40l5ANL3... to c4JvQUEOBHgtRdNPc... (flutter/engine#41848)
    2023-05-09 [email protected] Roll Dart SDK from
    498cfa57165b to 4b4c0325fd5b (2 revisions) (flutter/engine#41847)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/mac-amd64 from oGF4h14qc40l to c4JvQUEOBHgt
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the
    revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 9, 2023
    Configuration menu
    Copy the full SHA
    b269eb5 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Configuration menu
    Copy the full SHA
    8ab782d View commit details
    Browse the repository at this point in the history
  2. Roll flutter/packages to 0167d83 (#126427)

    Manual package roll to fix tree.
    
    Fixes #126393
    stuartmorgan-g authored May 10, 2023
    Configuration menu
    Copy the full SHA
    df789c9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a76dbe4 View commit details
    Browse the repository at this point in the history
Loading