Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 87224e0fb692
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bed459016322
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Jun 23, 2026

  1. [Tool] Fix widget-preview crash by waiting for analysis server (#187941) 

    The `flutter widget-preview start` command was crashing with an
`RpcException` (method not found) because it attempted to call
`dart/workspace/getFlutterWidgetPreviews` immediately after the `Lsp`
service was registered, but before the Analysis Server had finished its
initial analysis and registered the specific method.

This change:
- Waits for the initial analysis to complete after initializing the LSP
preview detector.
- Increases the retry limit for DTD calls to the widget preview methods
from 5 to 50 (with 200ms delay, increasing the total wait from 1s to
10s) to handle slower environments.
- Adds a unit test to verify that the tool indeed waits for the analysis
server to finish initial analysis.

Fixes #187367
    @bkonyi
    bkonyi authored Jun 23, 2026
    Configuration menu
    Copy the full SHA
    bed4590 View commit details
    Browse the repository at this point in the history
Loading