-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: 828a04040e11
head repository: flutter/flutter
compare: db6074ade4e4
- 12 commits
- 99 files changed
- 3 contributors
Commits on May 1, 2023
-
Roll Flutter Engine from 687f4c761db1 to 58cc54197a54 (6 revisions) (#…
…125833) flutter/engine@687f4c7...58cc541 2023-05-01 [email protected] Roll Fuchsia Mac SDK from NBgD7NzOpwnAULR_g... to u7iIoiSX4y8WV6Of1... (flutter/engine#41641) 2023-05-01 [email protected] Add the verify exported symbols to linux builds. (flutter/engine#41635) 2023-05-01 [email protected] [Impeller] Turns on the Metal validator for impeller_unittests. (flutter/engine#40998) 2023-05-01 [email protected] [Impeller] Remove duplicate component in path.h (flutter/engine#41639) 2023-05-01 [email protected] Forward fix for roll of Dart SDK to version with new checked-in SDK (flutter/engine#41634) 2023-05-01 [email protected] Roll Skia from 1a6a1e905518 to 82d1ef7a833e (5 revisions) (flutter/engine#41637) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from NBgD7NzOpwnA to u7iIoiSX4y8W If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 050e4ad - Browse repository at this point
Copy the full SHA 050e4adView commit details -
Roll Flutter Engine from 58cc54197a54 to 3fa6084dfb36 (1 revision) (#…
…125839) flutter/engine@58cc541...3fa6084 2023-05-01 [email protected] Fixes font-subset to not drop GSUB/GPOS/GDEF tables for variable fonts where they are needed Fixes #125704 (flutter/engine#41592) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 635337c - Browse repository at this point
Copy the full SHA 635337cView commit details
Commits on May 2, 2023
-
Migrate Xcode projects last version checks to Xcode 14.3 (#125827)
1. Add iOS and macOS migration to mark "last upgraded" Xcode version to 14.3 to prevent `Update to recommended settings` warning. 2. Update iOS and macOS templates to same. 3. Update iOS template to set `BuildIndependentTargetsInParallel` to YES as suggested. I didn't add a migration for this since it seems like a minor optimization and I don't think it's worth a potentially botched/corrupted migration. 4. Run all example/integration test project to see migrator work. 5. Add some missing test projects to the build shard since I noticed they were missing and I had to build those manually outside `SHARD=build_tests`. Fixes #125817 See #90304 for Xcode 13 example.
Configuration menu - View commit details
-
Copy full SHA for 1861ac4 - Browse repository at this point
Copy the full SHA 1861ac4View commit details -
Roll Flutter Engine from 3fa6084dfb36 to 7d87410a51d5 (4 revisions) (#…
…125845) flutter/engine@3fa6084...7d87410 2023-05-01 [email protected] Update xcode to 14e222b (flutter/engine#41640) 2023-05-01 [email protected] Run flutter license script with dart `--intrepret_irregexp` runtime option (flutter/engine#41646) 2023-05-01 [email protected] Roll Skia from 82d1ef7a833e to 38e56b6da8f9 (8 revisions) (flutter/engine#41645) 2023-05-01 [email protected] Move scenario app to use iPhone Se 3rd gen iOS 16.2, un-skip test `TwoPlatformViewsWithOtherBackDropFilterTests` (flutter/engine#41532) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for d304545 - Browse repository at this point
Copy the full SHA d304545View commit details -
Roll Flutter Engine from 7d87410a51d5 to 024bf946232d (6 revisions) (#…
…125858) flutter/engine@7d87410...024bf94 2023-05-02 [email protected] Roll Skia from 38e56b6da8f9 to c9e0992be00b (3 revisions) (flutter/engine#41655) 2023-05-02 [email protected] Roll Dart SDK from dc4a048e3cf7 to 25c29435f73e (1 revision) (flutter/engine#41654) 2023-05-01 [email protected] [Impeller] take advantage of DisplayList culling (flutter/engine#41606) 2023-05-01 [email protected] Use os_dimension in framework tests. (flutter/engine#41649) 2023-05-01 [email protected] Turn @staticInterop tear-off into closure (flutter/engine#41643) 2023-05-01 [email protected] Roll Fuchsia Linux SDK from SJOgKviZ-kwWd1Z1u... to ur2ymZJCZSj64s6Q2... (flutter/engine#41648) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from SJOgKviZ-kwW to ur2ymZJCZSj6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 7907f93 - Browse repository at this point
Copy the full SHA 7907f93View commit details -
Make
futureandstreamrequired arguments in their respective bui……lder widgets (#125838) cc'ing existing conversation participants: @domesticmouse @srawlins cc'ing to request review: @goderbauer This PR makes the following constructor arguments required: 1. `FutureBuilder.future` 2. `StreamBuilderBase.stream` 3. `StreamBuilder.stream` This fixes: #83081 #125188 (dupe of 83081) This obviates: https://github.com/dart-lang/linter/issues/4309 (I suggest we skip straight to merging this PR as this should be a low impact breaking change-assuming few to no devs are intentionally using the builders without their relevant arguments, however we could always merge 4309 first and then this) #83101 (The above PR required that at least one of future and initial data be non-null, this is undesirable as there are plenty of valid reasons to have both arguments be null) See above issues for a deeper dive, but here is a summary: It is very easy for a developer to forget to specify `future` or `stream` when using the respective `*Builder` widgets. This produces a non-obvious failure where the UI sits in a "no data yet received" state. It is easy for a dev to misinterpret this as the async work backing the future/stream hanging and they thus waste a lot of time trying to debug the async work. As such, we should require these two constructor arguments to make it impossible/much harder for devs to make this time-wasting mistake. This is a breaking change. However, it should break only a small number of active projects given that using a builder without specifying `future` or `stream` seems highly niche. The only place I've found non-accidental examples of this is in widget tests where you're calling `pumpWidget` with and without these arguments to test `*Builder.didUpdateWidget`'s behavior. In this and similar cases, it is a trivial fix to add `future: null`/`stream: null`. *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Configuration menu - View commit details
-
Copy full SHA for 4d86f5d - Browse repository at this point
Copy the full SHA 4d86f5dView commit details -
Roll Flutter Engine from 024bf946232d to a9e38dd0510d (2 revisions) (#…
…125866) flutter/engine@024bf94...a9e38dd 2023-05-02 [email protected] Roll Skia from c9e0992be00b to e18b7415188c (1 revision) (flutter/engine#41659) 2023-05-02 [email protected] Roll Dart SDK from 25c29435f73e to 0c4f93a82e0b (2 revisions) (flutter/engine#41657) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 5965313 - Browse repository at this point
Copy the full SHA 5965313View commit details -
Roll Flutter Engine from a9e38dd0510d to c0d68c36c376 (1 revision) (#…
…125868) flutter/engine@a9e38dd...c0d68c3 2023-05-02 [email protected] Roll Skia from e18b7415188c to d2c85cb8aa2f (2 revisions) (flutter/engine#41660) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 55061e4 - Browse repository at this point
Copy the full SHA 55061e4View commit details -
Roll Flutter Engine from c0d68c36c376 to d0ed35b7bf67 (1 revision) (#…
…125870) flutter/engine@c0d68c3...d0ed35b 2023-05-02 [email protected] Roll Fuchsia Mac SDK from u7iIoiSX4y8WV6Of1... to moQlKaNgpc0WD3sjC... (flutter/engine#41661) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from u7iIoiSX4y8W to moQlKaNgpc0W If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for d82e697 - Browse repository at this point
Copy the full SHA d82e697View commit details -
Roll Flutter Engine from d0ed35b7bf67 to a687d62ff631 (1 revision) (#…
…125871) flutter/engine@d0ed35b...a687d62 2023-05-02 [email protected] Roll Skia from d2c85cb8aa2f to e71bd40af2bb (1 revision) (flutter/engine#41662) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 005ad93 - Browse repository at this point
Copy the full SHA 005ad93View commit details -
Roll Flutter Engine from a687d62ff631 to 46d5ce4784b8 (1 revision) (#…
…125874) flutter/engine@a687d62...46d5ce4 2023-05-02 [email protected] [macOS] Add lookupKeyForAsset to FlutterPluginRegistrar (flutter/engine#37421) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 61c8291 - Browse repository at this point
Copy the full SHA 61c8291View commit details -
Roll Flutter Engine from 46d5ce4784b8 to 44376e8cd3de (1 revision) (#…
…125876) flutter/engine@46d5ce4...44376e8 2023-05-02 [email protected] Roll Fuchsia Linux SDK from ur2ymZJCZSj64s6Q2... to g_6rn9e-GBQGQGwgt... (flutter/engine#41663) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ur2ymZJCZSj6 to g_6rn9e-GBQG If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for db6074a - Browse repository at this point
Copy the full SHA db6074aView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 828a04040e11...db6074ade4e4