-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: 80c2e84975bb
head repository: flutter/flutter
compare: 5874a72aa4c7
- 9 commits
- 78 files changed
- 4 contributors
Commits on Aug 12, 2024
-
[CP-stable]Change flutter_build_with_compilation_error_test to check …
…stdout or stderr (#153116) ### Issue Link: #151553 ### Changelog Description: Make a flutter_tools test pass on Xcode 16 beta. ### Impact Description: When we update our CI to Xcode 16 after it releases (likely in September), all tests should pass. ### Workaround: Turning off the test. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: - Install Xcode 15 and run the test (this is happening in CI now). - Install Xcode 16 latest beta and run the test. Part of #148959
Configuration menu - View commit details
-
Copy full SHA for dcc1f06 - Browse repository at this point
Copy the full SHA dcc1f06View commit details
Commits on Aug 13, 2024
-
[CP-stable]Add xcresulttool --legacy flag for deprecated usage (#153117)
### Issue Link: #152989 ### Changelog Description: On Xcode 16 beta, compilation errors are not displayed in the output of `flutter run`. ### Impact Description: If there are compilation errors `flutter build ios`/`run` will fail, but displays the last x lines out the Xcode output instead of a nicely formatted description of the error. ### Workaround: Use Xcode 15. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: Run the following steps with both Xcode 15 and Xcode 16 installed (should behave the same): ``` $ flutter create test_create $ cd test_create $ open ios/Runner/AppDelegate.swift ``` Add code that would cause a compilation issue: ```swift import Flutter import UIKit @main @objc class AppDelegate: FlutterAppDelegate { override func application( _ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? ) -> Bool { var i = 1 + @"" GeneratedPluginRegistrant.register(with: self) return super.application(application, didFinishLaunchingWithOptions: launchOptions) } } ``` ``` $ flutter build ios ``` Output should be: ``` Failed to build iOS app Swift Compiler Error (Xcode): String literals in Swift are not preceded by an '@' sign /Users/m/Projects/test_create/ios/Runner/AppDelegate.swift:9:16 Swift Compiler Error (Xcode): Binary operator '+' cannot be applied to operands of type 'Int' and 'String' /Users/m/Projects/test_create/ios/Runner/AppDelegate.swift:9:14 Encountered error while building for device. ```
Configuration menu - View commit details
-
Copy full SHA for 8997882 - Browse repository at this point
Copy the full SHA 8997882View commit details -
[CP-stable]Handle a SocketException thrown when sending the browser c…
…lose command to Chrome (#153294) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Prevent CLI tool crash that can occur when unable to exit a spawned Chromium instance that's already been exited. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Noisy crashes for users. This crash represents 65.69% of tool crashes (with roughly half of that percentage of clients being affected). ### Workaround: Is there a workaround for this issue? There is no known workaround. ### Risk: What is the risk level of this cherry-pick? This simply adds a try-catch that will, at worst, obscure errors. ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? N/A. No reliable repro is known at this time.
Configuration menu - View commit details
-
Copy full SHA for cb28dec - Browse repository at this point
Copy the full SHA cb28decView commit details -
[CP Stable] Emit source maps for wasm in
flutter build web --wasm(#……151643) (#153310) Cherry-pick request: #153308 Original CL: This will make * `flutter run` have source maps enabled by default * `flutter build` have source maps disabled by default which mirrors what happens already today with the js compilers. For local development this works quite well - even better than with dart2js (see dart2js issues in [0]). We do have some follow-up items for source maps in dart2wasm compiler, see [1] [0] [/issues/151641](#151641) [1] [dart-lang/sdk/issues/56232](dart-lang/sdk#56232)
Configuration menu - View commit details
-
Copy full SHA for ec5d407 - Browse repository at this point
Copy the full SHA ec5d407View commit details -
[CP-stable][iOS] Copy Flutter.framework.dSYM into app archive (#153322)
### Issue Link: What is the link to the issue this cherry-pick is addressing? #116493 Dependent on engine-side CP flutter/engine#54513 ### Changelog Description: Flutter now bundles iOS framework debugging symbols in app archives built with `flutter build ipa` or Xcode's *Product > Archive* command. This eliminates the need for manual download/bundling of Flutter debug symbols for release build crash log symbolication, and as of Xcode 16, these symbols are now required for app archives to pass App Store validation. ### Impact Description: Without these bundled symbols, iOS App Store validation fails for Flutter apps under Xcode 16, making it impossible for developers to publish to the iOS App Store. ### Workaround: Use Xcode 15. ### Risk: What is the risk level of this cherry-pick? The change itself is quite simple and in the case where we can't find a bundled Flutter.framework.dSYM inside the flutter tool's artifact cache, we simply fall back to the previous behaviour of not copying it. In the case where the Flutter.framework.dSYM is found in the artifact cache (which is the expected case), we simply perform a copy using `rsync` as we do with Flutter.framework itself. This is also relatively low-risk. Further, this change has been verified by @cbracken using Flutter's own organisation on the App Store, and by [a non-Google developer](#116493 (comment)). However, I'm flagging as medium-risk since this change has only had two days of bake time for us to collect feedback, and while I expect there's a very low likelihood of an issue, we haven't yet got sufficient feedback to say definitively that we haven't missed any edge-cases. ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? The developer performing these steps will need to have *App Manager* permissions for their development team in App Store Connect. 1. Install Xcode 16 beta. 2. Make Xcode 16 beta the default on your machine: `xcode-select -s /Applications/Xcode-beta.app` 3. Create the default clickcounter app: `flutter create clickcounter` 4. Open `ios/Runner.xcworkspace` in Xcode beta 16. 5. In the project explorer sidebar, select the *Runner* app, then select the *Signing & Capabilities* tab. 6. Set the bundle identifier to the bundle identifier of your app as configured in App Store Connect. 7. From the team dropdown, select a team for which you have developer permissions. 8. From the menu bar, select *Product > Archive*. This will open the Organizer window. You can open it again later from the *Window* menu or via Command-Option-Shift-O. 9. Select the archive, then click *Validate App.*
Configuration menu - View commit details
-
Copy full SHA for 613e43c - Browse repository at this point
Copy the full SHA 613e43cView commit details
Commits on Aug 19, 2024
-
[CP-stable] Bump dependency on package:vm_service from 14.2.4 to 14.2…
….5 (#153597) Context: #153472. When the Flutter VM service is disposed while there are still outstanding requests, each request is completed with an `RPCError` that has no stack trace. This was fixed in package:vm_service v14.2.5 (these errors will now have stack traces). This PR bumps the framework repo's dependency on this package from 14.2.4 to 14.2.5. This may be handy in case we miss handling these errors from specific call sites in whatever fix(es) we put out for #153472.
Configuration menu - View commit details
-
Copy full SHA for a1f08ba - Browse repository at this point
Copy the full SHA a1f08baView commit details -
[CP-stable]add
HttpExceptionto the list of handled exceptions with……in `ResidentWebRunner::run` (#153579) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #153298 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples [CLI tool] When unable to connect to Chrome/Chromium when running a flutter web app, gracefully exit with an error message instead of crashing. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Impacts users locally running Flutter web apps. Users are likely getting noisy crashes when `flutter run` or `flutter debug-adapter` are unable to connect to the flutter web app (perhaps due to a firewall or the user closing the browser before the connection can be made). ### Workaround: Is there a workaround for this issue? N/A. No repro is known. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? N/A. No repro is known.
Configuration menu - View commit details
-
Copy full SHA for b023fad - Browse repository at this point
Copy the full SHA b023fadView commit details
Commits on Aug 20, 2024
-
[flutter_releases] Flutter stable 3.24.1 Framework Cherrypicks (#153731)
# Flutter stable 3.24.1 Framework ## Scheduled Cherrypicks
Configuration menu - View commit details
-
Copy full SHA for eb60a2c - Browse repository at this point
Copy the full SHA eb60a2cView commit details -
3.24.1 Changelog updates (#153772)
Flutter 3.24.1 Changelog updates.
Configuration menu - View commit details
-
Copy full SHA for 5874a72 - Browse repository at this point
Copy the full SHA 5874a72View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 80c2e84975bb...5874a72aa4c7