Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7c28e8eb0734
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 219efce7f16d
Choose a head ref
  • 16 commits
  • 116 files changed
  • 4 contributors

Commits on Sep 9, 2023

  1. Roll Flutter Engine from d1913cb6a276 to b8afb6deacf3 (1 revision) (#… 

    …134356)

flutter/engine@d1913cb...b8afb6d

2023-09-09 [email protected] Roll Skia from 58e39bd84ab2 to 386c7a6a56fd (1 revision) (flutter/engine#45614)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 9, 2023
    Configuration menu
    Copy the full SHA
    cc317df View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from b8afb6deacf3 to 4edbefa5e8f7 (1 revision) (#… 

    …134360)

flutter/engine@b8afb6d...4edbefa

2023-09-09 [email protected] Roll Skia from 386c7a6a56fd to 1bb0f15f2cff (1 revision) (flutter/engine#45615)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 9, 2023
    Configuration menu
    Copy the full SHA
    c7665ff View commit details
    Browse the repository at this point in the history

  3. SelectableRegion onSelectionChange should be called when the selectio… 

    …n changes (#134215)

This change makes sure to call `onSelectionChange` in all cases when selection might change including:
* Dragging selection handles
* Mouse drag to select
* Keyboard actions
* Long press drag to select
    @Renzo-Olivares
    Renzo-Olivares authored Sep 9, 2023
    Configuration menu
    Copy the full SHA
    2c477b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. Roll Flutter Engine from 4edbefa5e8f7 to feea98d6d0ae (1 revision) (#… 

    …134365)

flutter/engine@4edbefa...feea98d

2023-09-10 [email protected] Roll Fuchsia Linux SDK from i9IPFS-XpkPjlH235... to U70-bvYinYjKdGGSt... (flutter/engine#45618)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from i9IPFS-XpkPj to U70-bvYinYjK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 10, 2023
    Configuration menu
    Copy the full SHA
    8919140 View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from feea98d6d0ae to 47d1a045d140 (1 revision) (#… 

    …134368)

flutter/engine@feea98d...47d1a04

2023-09-10 [email protected] Roll Fuchsia Mac SDK from 51fG0shrG6fW64BtN... to VciXahwZgiusifyh8... (flutter/engine#45620)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 51fG0shrG6fW to VciXahwZgius

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 10, 2023
    Configuration menu
    Copy the full SHA
    690800b View commit details
    Browse the repository at this point in the history

  3. Native assets support for MacOS and iOS (#130494) 

    Support for FFI calls with `@Native external` functions through Native assets on MacOS and iOS. This enables bundling native code without any build-system boilerplate code.

For more info see:

* #129757

### Implementation details for MacOS and iOS.

Dylibs are bundled by (1) making them fat binaries if multiple architectures are targeted, (2) code signing these, and (3) copying them to the frameworks folder. These steps are done manual rather than via CocoaPods. CocoaPods would have done the same steps, but (a) needs the dylibs to be there before the `xcodebuild` invocation (we could trick it, by having a minimal dylib in the place and replace it during the build process, that works), and (b) can't deal with having no dylibs to be bundled (we'd have to bundle a dummy dylib or include some dummy C code in the build file).

The dylibs are build as a new target inside flutter assemble, as that is the moment we know what build-mode and architecture to target.

The mapping from asset id to dylib-path is passed in to every kernel compilation path. The interesting case is hot-restart where the initial kernel file is compiled by the "inner" flutter assemble, while after hot restart the "outer" flutter run compiled kernel file is pushed to the device. Both kernel files need to contain the mapping. The "inner" flutter assemble gets its mapping from the NativeAssets target which builds the native assets. The "outer" flutter run get its mapping from a dry-run invocation. Since this hot restart can be used for multiple target devices (`flutter run -d all`) it contains the mapping for all known targets.

### Example vs template

The PR includes a new template that uses the new native assets in a package and has an app importing that. Separate discussion in: #131209.

### Tests

This PR adds new tests to cover the various use cases.

* dev/devicelab/bin/tasks/native_assets_ios.dart
  * Runs an example app with native assets in all build modes, doing hot reload and hot restart in debug mode.
* dev/devicelab/bin/tasks/native_assets_ios_simulator.dart
  * Runs an example app with native assets, doing hot reload and hot restart.
* packages/flutter_tools/test/integration.shard/native_assets_test.dart
  * Runs (incl hot reload/hot restart), builds, builds frameworks for iOS, MacOS and flutter-tester.
* packages/flutter_tools/test/general.shard/build_system/targets/native_assets_test.dart
  * Unit tests the new Target in the backend.
* packages/flutter_tools/test/general.shard/ios/native_assets_test.dart
* packages/flutter_tools/test/general.shard/macos/native_assets_test.dart
  * Unit tests the native assets being packaged on a iOS/MacOS build.

It also extends various existing tests:

* dev/devicelab/bin/tasks/module_test_ios.dart
   * Exercises the add2app scenario.
* packages/flutter_tools/test/general.shard/features_test.dart
   * Unit test the new feature flag.
    @dcharkes
    dcharkes authored Sep 10, 2023
    Configuration menu
    Copy the full SHA
    aa36db1 View commit details
    Browse the repository at this point in the history

  4. Roll Flutter Engine from 47d1a045d140 to a2af0c6965be (1 revision) (#… 

    …134375)

flutter/engine@47d1a04...a2af0c6

2023-09-10 [email protected] Roll Skia from 1bb0f15f2cff to 4eea73a072d3 (1 revision) (flutter/engine#45623)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 10, 2023
    Configuration menu
    Copy the full SHA
    2da03e5 View commit details
    Browse the repository at this point in the history

  5. Roll Flutter Engine from a2af0c6965be to 59b08263f7cc (1 revision) (#… 

    …134384)

flutter/engine@a2af0c6...59b0826

2023-09-10 [email protected] Roll Fuchsia Linux SDK from U70-bvYinYjKdGGSt... to a024p4HJVVgmCW5Jo... (flutter/engine#45624)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from U70-bvYinYjK to a024p4HJVVgm

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 10, 2023
    Configuration menu
    Copy the full SHA
    de25def View commit details
    Browse the repository at this point in the history

  6. Roll Flutter Engine from 59b08263f7cc to 2acd60d6baed (1 revision) (#… 

    …134391)

flutter/engine@59b0826...2acd60d

2023-09-10 [email protected] Roll Fuchsia Mac SDK from VciXahwZgiusifyh8... to 6PrTSjMiSCsSb0muF... (flutter/engine#45626)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from VciXahwZgius to 6PrTSjMiSCsS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 10, 2023
    Configuration menu
    Copy the full SHA
    44131ae View commit details
    Browse the repository at this point in the history

  7. Roll Flutter Engine from 2acd60d6baed to 04d836f69571 (1 revision) (#… 

    …134392)

flutter/engine@2acd60d...04d836f

2023-09-10 [email protected] Roll Skia from 4eea73a072d3 to 947f91dcacf5 (1 revision) (flutter/engine#45629)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 10, 2023
    Configuration menu
    Copy the full SHA
    0d9ea62 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Roll Flutter Engine from 04d836f69571 to 7e41b064eb23 (1 revision) (#… 

    …134396)

flutter/engine@04d836f...7e41b06

2023-09-11 [email protected] Roll Fuchsia Linux SDK from a024p4HJVVgmCW5Jo... to SFM4ele7RYnVMhr7S... (flutter/engine#45632)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from a024p4HJVVgm to SFM4ele7RYnV

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    69f6e7d View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from 7e41b064eb23 to 1aa11b644855 (2 revisions) (#… 

    …134404)

flutter/engine@7e41b06...1aa11b6

2023-09-11 [email protected] Roll Skia from 5aff628b1c47 to 2e80ffb2ebea (1 revision) (flutter/engine#45634)
2023-09-11 [email protected] Roll Skia from 947f91dcacf5 to 5aff628b1c47 (1 revision) (flutter/engine#45633)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    ffe1ebd View commit details
    Browse the repository at this point in the history

  3. Roll Flutter Engine from 1aa11b644855 to ac6be4dbf821 (1 revision) (#… 

    …134407)

flutter/engine@1aa11b6...ac6be4d

2023-09-11 [email protected] Roll Skia from 2e80ffb2ebea to 4c50e0870461 (1 revision) (flutter/engine#45635)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    954444a View commit details
    Browse the repository at this point in the history

  4. Roll Flutter Engine from ac6be4dbf821 to e9f1696e5060 (1 revision) (#… 

    …134410)

flutter/engine@ac6be4d...e9f1696

2023-09-11 [email protected] Roll Fuchsia Mac SDK from 6PrTSjMiSCsSb0muF... to 7Zk_dvFh301kgQte4... (flutter/engine#45636)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 6PrTSjMiSCsS to 7Zk_dvFh301k

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c6fa261 View commit details
    Browse the repository at this point in the history

  5. Roll Flutter Engine from e9f1696e5060 to 2b5961cbc40d (1 revision) (#… 

    …134424)

flutter/engine@e9f1696...2b5961c

2023-09-11 [email protected] Roll Skia from 4c50e0870461 to 787b61f00100 (1 revision) (flutter/engine#45639)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    6de4e16 View commit details
    Browse the repository at this point in the history

  6. Cover more tests with leak tracking. (#134363)

    @polina-c
    polina-c authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    219efce View commit details
    Browse the repository at this point in the history
Loading