Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7811e8982355
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 65aca3661b8f
Choose a head ref
  • 12 commits
  • 46 files changed
  • 5 contributors

Commits on Oct 1, 2025

  1. Make sure that a DrawerButton doesn't crash in 0x0 environment (#172948)

    This is my attempt to handle
    #6537 for the DrawerButton UI
    control.
    ahmedsameha1 authored Oct 1, 2025
    Configuration menu
    Copy the full SHA
    4f49888 View commit details
    Browse the repository at this point in the history
  2. Make sure that a DateRangePickerDialog doesn't crash in 0x0 environme…

    …nts (#173754)
    
    This is my attempt to handle
    #6537 for the
    DateRangePickerDialog UI control.
    ahmedsameha1 authored Oct 1, 2025
    Configuration menu
    Copy the full SHA
    7ceee3b View commit details
    Browse the repository at this point in the history
  3. [ Tool / l10n ] Fix issue where localization generator assumed curren…

    …t directory was the target project (#175881)
    
    When running `flutter pub get` from the root of a Pub workspace,
    localizations are generated for each subproject. However, we were trying
    to write the untranslated messages file relative to the current
    directory, not the target project's directory.
    
    This change updates the logic for determining the output location of the
    untranslated messages file to include the target project root.
    
    Fixes #174205
    bkonyi authored Oct 1, 2025
    Configuration menu
    Copy the full SHA
    40f013a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d0a6884 View commit details
    Browse the repository at this point in the history
  5. Reapply "Update the AccessibilityPlugin::Announce method to account f… (

    #176107)
    
    …… (#174365)"
    
    This reverts commit 5e146d4.
    
    <!--
    Thanks for filing a pull request!
    Reviewers are typically assigned within a week of filing a request.
    To learn more about code review, see our documentation on Tree Hygiene:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    -->
    
    straight reland, previous pr was reverted because g3fix is outdated
    
    ## Pre-launch Checklist
    
    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [ ] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    chunhtai authored Oct 1, 2025
    Configuration menu
    Copy the full SHA
    a3eba8e View commit details
    Browse the repository at this point in the history
  6. Roll Skia from c44a36470d07 to b5d8ae8d3410 (5 revisions) (#176367)

    https://skia.googlesource.com/skia.git/+log/c44a36470d07..b5d8ae8d3410
    
    2025-10-01 [email protected] Revert "Reapply "Use pathbuilder or
    factories to keep path immutable""
    2025-10-01 [email protected] Roll
    vulkan-deps from 9023de589c86 to 29b917fb5921 (3 revisions)
    2025-10-01 [email protected] Remove unused mutable-path parameter
    2025-10-01 [email protected] [graphite] Add
    SupportsPipelineCreationCacheControl bool to VulkanCaps
    2025-10-01 [email protected] Only enable shader precision modifier
    usage for ganesh/GL
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected]
    on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Oct 1, 2025
    Configuration menu
    Copy the full SHA
    c1764c1 View commit details
    Browse the repository at this point in the history
  7. [ Widget Preview ] Persist "Filter by Selected File" toggle (#176289)

    This change introduces `PersistentPreferences`, which allows for the
    widget previewer to save settings to disk.
    
    `PersistentPreferences` makes use of the existing `~/.flutter-devtools`
    directory used by DevTools for the same purpose, writing preferences in
    JSON format to `~/.flutter-devtools/.widget-preview`.
    bkonyi authored Oct 1, 2025
    Configuration menu
    Copy the full SHA
    23a9ce3 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2025

  1. Configuration menu
    Copy the full SHA
    2bf5da4 View commit details
    Browse the repository at this point in the history
  2. Delete Skia-specific performance overlay implementation (#176364)

    (Essentially a re-issue of
    #174682 which ended up with
    broken Google Testing links)
    
    We had 2 different implementations of the rendering code for the
    performance overlay layer. The skia version used some skia-specific code
    to render the overlay incrementally into an offscreen surface and so we
    created a different implementation for Impeller that only uses standard
    rendering calls (and no surface cache). It turns out that the Impeller
    version was faster anyway even on Skia so it is a simple change to
    delete the old code and always use the new visualizer.
    
    The new visualizer reduces the time to render the graph from just under
    1ms to about .1ms on Skia.
    The new visualizer takes .1ms longer to compute on the UI thread, but
    overall we save time between the 2 threads.
    The new visualizer is much faster on Impeller.
    
    Some work could be done to save some of that time on the UI thread by
    only incrementally updating the graph data, but for now we can take the
    ~.8-.9ms savings with just some deleted code.
    flar authored Oct 2, 2025
    Configuration menu
    Copy the full SHA
    b77acbf View commit details
    Browse the repository at this point in the history
  3. Roll Skia from b5d8ae8d3410 to 257c1f94afaa (6 revisions) (#176389)

    https://skia.googlesource.com/skia.git/+log/b5d8ae8d3410..257c1f94afaa
    
    2025-10-02 [email protected] Roll Dawn
    from cd3a5de0811f to 603a5155599a (14 revisions)
    2025-10-01 [email protected] Make SkPathPriv::Raw handle SkPaths with
    infinite bounds correctly
    2025-10-01 [email protected] Reapply "Reapply "Use pathbuilder or
    factories to keep path immutable""
    2025-10-01 [email protected] [graphite] Make use of
    PipelineCreateCacheControl in Vulkan
    2025-10-01 [email protected] Update tests to use pathbuilder
    2025-10-01 [email protected] [skcapture] add capture callbacks for
    SkSurface
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected]
    on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Oct 2, 2025
    Configuration menu
    Copy the full SHA
    9b91dab View commit details
    Browse the repository at this point in the history
  4. [ Widget Preview ] Fix resolution for workspace "hosted" dependencies (

    …#176358)
    
    Projects within the same workspace can depend on each other without
    explicitly specifying path dependencies or dependency overrides using
    the following syntax:
    
    ```
    dependencies:
      my_workspace_project: # No constraint or path
    ```
    
    This is treated as a "hosted" dependency, which conflicts with the path
    dependencies used by the widget_preview_scaffold.
    
    This change introduces dependency_overrides for each package in the
    workspace watched by the widget previewer to allow for dependencies to
    be resolved correctly.
    
    Fixes #176018
    bkonyi authored Oct 2, 2025
    Configuration menu
    Copy the full SHA
    f35a287 View commit details
    Browse the repository at this point in the history
  5. Roll Skia from 257c1f94afaa to 05c1f5803415 (4 revisions) (#176402)

    https://skia.googlesource.com/skia.git/+log/257c1f94afaa..05c1f5803415
    
    2025-10-02 [email protected] Roll
    vulkan-deps from 29b917fb5921 to 3964dd7c126b (4 revisions)
    2025-10-02 [email protected] Roll ANGLE
    from ae02c3292a95 to 7994bf76d7a9 (8 revisions)
    2025-10-02
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-10-02 [email protected] Roll Skia
    Infra from a3b8ecf9f94a to 8d4953412be2 (6 revisions)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected]
    on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Oct 2, 2025
    Configuration menu
    Copy the full SHA
    65aca36 View commit details
    Browse the repository at this point in the history
Loading