Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 76107bdf509f
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b12d86157e38
Choose a head ref
  • 14 commits
  • 20 files changed
  • 7 contributors

Commits on Aug 9, 2024

  1. Roll Flutter Engine from 05208896830a to e50fd307b6f7 (5 revisions) (#… 

    …153143)

flutter/engine@0520889...e50fd30

2024-08-09 [email protected] Roll Skia from 2eee5f248886 to bf9cf9b8fe9d (1 revision) (flutter/engine#54462)
2024-08-09 [email protected] Roll Skia from 5e8d9842cefa to 2eee5f248886 (1 revision) (flutter/engine#54461)
2024-08-09 [email protected] Roll Dart SDK from ff0404c72fc5 to 9222e4c96f4d (1 revision) (flutter/engine#54460)
2024-08-09 [email protected] Roll Skia from 4cff580721cf to 5e8d9842cefa (1 revision) (flutter/engine#54459)
2024-08-09 [email protected] [iOS] Rename Flutter.dSYM to Flutter.framework.dSYM (flutter/engine#54458)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d464571 View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from e50fd307b6f7 to c9ec468c7592 (2 revisions) (#… 

    …153145)

flutter/engine@e50fd30...c9ec468

2024-08-09 [email protected] Roll Skia from bf9cf9b8fe9d to 0bedf6746d9e (2 revisions) (flutter/engine#54466)
2024-08-09 [email protected] Roll Fuchsia Test Scripts from TXbf0oL9XzQ8vcHJP... to ra4HZdsFPpgZgDON6... (flutter/engine#54464)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    27234a9 View commit details
    Browse the repository at this point in the history

  3. Make ios_deploy_test.dart more robust (#153147) 

    The test should not assume that a stream of bytes delivers them in a
certain chunked order (e.g. all bytes of a line are delivered in one
chunk and the newline comes in another chunk).

Instead it should use a line splitter to obtain individual lines and can
match those against expectations.

This fragile test is broken after [0] which combines writing a string
together with the newline instead of seperately.

[0] https://dart-review.googlesource.com/c/sdk/+/378024
    @mkustermann
    mkustermann authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    493c453 View commit details
    Browse the repository at this point in the history

  4. Shift tests on moto g4 on Windows hosts to mokey in staging (#153167) 

    For #148085
    @zanderso
    zanderso authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    857addc View commit details
    Browse the repository at this point in the history

  5. Fix tests expectations regarding new lines. (#153174) 

    Fixes #153163

Dart sdk change that affected tests is
dart-lang/sdk@e8c0353
    @aam
    aam authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    22e6af6 View commit details
    Browse the repository at this point in the history

  6. Move Cupertino focus constants to cupertino/constants.dart (#153115)

    @victorsanni
    victorsanni authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    0c9b2e5 View commit details
    Browse the repository at this point in the history

  7. Roll Packages from bb797b9 to f7b1256 (5 revisions) (#153180) 

    flutter/packages@bb797b9...f7b1256

2024-08-09 [email protected] Manual roll Flutter from b6cd31e to 76107bd (14 revisions) (flutter/packages#7349)
2024-08-09 [email protected] [interactive_media_ads] Adds support for all `AdEventType`s and ad data (flutter/packages#7287)
2024-08-08 [email protected] [google_maps] remove Impeller opt out. (flutter/packages#7346)
2024-08-08 [email protected] [flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType (flutter/packages#7310)
2024-08-08 [email protected] Manual roll Flutter from d595e98 to b6cd31e (21 revisions) (flutter/packages#7339)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    cd94835 View commit details
    Browse the repository at this point in the history

  8. Roll Flutter Engine from c9ec468c7592 to 4d5b1df96fc9 (6 revisions) (#… 

    …153182)

flutter/engine@c9ec468...4d5b1df

2024-08-09 [email protected] Roll Skia from 31c432c02665 to 13b4fee1ba99 (1 revision) (flutter/engine#54470)
2024-08-09 [email protected]  Update pre-commit formatter to use java from repo rather than path. (flutter/engine#54450)
2024-08-09 [email protected] Remove swiftshader from the license script excludes list (flutter/engine#54412)
2024-08-09 [email protected] Roll Dart SDK from 1cc09f3f3642 to 35bc5c866149 (1 revision) (flutter/engine#54468)
2024-08-09 [email protected] Roll Skia from 0bedf6746d9e to 31c432c02665 (1 revision) (flutter/engine#54467)
2024-08-09 [email protected] Roll Dart SDK from 9222e4c96f4d to 1cc09f3f3642 (2 revisions) (flutter/engine#54465)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    6d3e320 View commit details
    Browse the repository at this point in the history

  9. Roll Flutter Engine from 4d5b1df96fc9 to 2f577d8e3fa2 (4 revisions) (#… 

    …153191)

flutter/engine@4d5b1df...2f577d8

2024-08-09 [email protected] [Impeller] Add FAQ entries. (flutter/engine#54456)
2024-08-09 [email protected] Roll Skia from f5dc4483204d to 5e190559fefd (1 revision) (flutter/engine#54472)
2024-08-09 [email protected] Roll Skia from 13b4fee1ba99 to f5dc4483204d (1 revision) (flutter/engine#54471)
2024-08-09 [email protected] [Impeller] remove scene3d support. (flutter/engine#54453)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    cd54675 View commit details
    Browse the repository at this point in the history

  10. Spell check range error (#153055) 

    Fixed a bug in spell checkers, especially custom ones, where deleting characters rapidly threw an error.
    @justinmc
    justinmc authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    ed47c4b View commit details
    Browse the repository at this point in the history

  11. Expose affixes icon constraints in InputDecorationTheme (#153089) 

    ## Description

This PR makes the existing `InputDecoration.prefixIconConstraints` and `InputDecoration.suffixIconConstraints` configurable from an `InputDecorationTheme`.

## Related Issue

Related to #138691 (this is needed before providing a fix or a workaround for it).

## Tests

Update and split one existing test into two different tests.
Update the existing test related to debugFillDescription by adding all the non tested properties.
    @bleroux
    bleroux authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    5609019 View commit details
    Browse the repository at this point in the history

  12. Also run Linux_android_emu tests on API level 34 image (#153175) 

    These VMs are relatively inexpensive, so there's no reason not to
continue running on the API level 34 image while we work out how to deal
with the apparent instability in the 35 images.

Related: #152684
    @zanderso
    zanderso authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    f43ae3b View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Roll Flutter Engine from 2f577d8e3fa2 to 3acd373923c9 (7 revisions) (#… 

    …153210)

flutter/engine@2f577d8...3acd373

2024-08-10 [email protected] Revert "Roll Dart SDK from 35bc5c866149 to cb89f7cad79c (1 revision) (#54474)" (flutter/engine#54487)
2024-08-09 [email protected] Remove shared mutex from FML and use the C++17 variants. (flutter/engine#54482)
2024-08-09 [email protected] Roll Skia from 2a7e7567607e to eeffce72693c (1 revision) (flutter/engine#54480)
2024-08-09 [email protected] Roll Fuchsia Test Scripts from ra4HZdsFPpgZgDON6... to q3WfgLnPmQ-1lBu8M... (flutter/engine#54479)
2024-08-09 [email protected] Roll Dart SDK from 35bc5c866149 to cb89f7cad79c (1 revision) (flutter/engine#54474)
2024-08-09 [email protected] Roll Skia from 5e190559fefd to 2a7e7567607e (1 revision) (flutter/engine#54477)
2024-08-09 [email protected] Remove fml::size. (flutter/engine#54476)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 10, 2024
    Configuration menu
    Copy the full SHA
    fe0d8f1 View commit details
    Browse the repository at this point in the history

  2. Move windows mokey tests to prod (#153203) 

    For #148085
    @zanderso
    zanderso authored Aug 10, 2024
    Configuration menu
    Copy the full SHA
    b12d861 View commit details
    Browse the repository at this point in the history
Loading