Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 72b69f944915
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e5e36ad34058
Choose a head ref
  • 12 commits
  • 21 files changed
  • 6 contributors

Commits on Sep 15, 2023

  1. Speed up native assets target (#134523)

    Speeds up the native assets target in the backend by
    
    1. changing other targets `gen_dart_plugin_registrant` and
    `release_unpack_ios` to do async I/O,
    2. not reparsing the package config, and
    3. not calling `dart pub deps --json` for 0 or 1 packages (fixed
    package:native_assets_builder).
    
    * #134427
    
    ```
               [   +2 ms] native_assets: Starting due to {}
               [   +2 ms] Skipping target: gen_localizations
               [   +1 ms] gen_dart_plugin_registrant: Starting due to {InvalidatedReasonKind.inputChanged: The following inputs have updated contents: /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/package_config_subset}
               [  +33 ms] gen_dart_plugin_registrant: Complete
               [ +107 ms] release_unpack_ios: Complete
               [  +60 ms] Writing native_assets.yaml.
               [   +7 ms] Writing /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/flutter_build/be2692bbfbc0b9a27fcd2422d52354c6/native_assets.yaml done.
               [        ] native_assets: Complete
    ```
    
    ->
    
    ```
               [   +4 ms] native_assets: Starting due to {}
               [        ] Skipping target: gen_localizations
               [   +1 ms] gen_dart_plugin_registrant: Starting due to {InvalidatedReasonKind.inputChanged: The following inputs have updated contents: /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/package_config_subset}
               [  +31 ms] Writing native_assets.yaml.
               [   +8 ms] Writing /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/flutter_build/f9451a65a465bfab70d004e21d6cc1d6/native_assets.yaml done.
               [   +1 ms] native_assets: Complete
    ```
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] All existing and new tests are passing.
    
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    dcharkes authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    8ebb8d4 View commit details
    Browse the repository at this point in the history
  2. moved hello_world_impeller to a 7pro (#134830)

    arm64 is necessary for this test
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    gaaclarke authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    43260cc View commit details
    Browse the repository at this point in the history
  3. [Windows_android channels_integration_test] Column -> ListView (#134836)

    This should fix #134636. 
    
    The column can get really tall, especially when there's line wrapping. This is the layout on a tablet, so on a motor g4 this column is likely going to overflow.
    
    ```
         RenderParagraph#66251 relayoutBoundary=up3
    � creator: RichText � Text-[<'status'>] � Column �
    �   FutureBuilder<TestStepResult> � Padding �
    �   KeyedSubtree-[GlobalKey#0f29e] � _BodyBuilder � MediaQuery �
    �   LayoutId-[<_ScaffoldSlot.body>] � CustomMultiChildLayout �
    �   _ActionsScope � Actions � �
    |  parentData: offset=Offset(0.0, 600.0); flex=null; fit=null
    ```
    
    ![flutter_01](https://github.com/flutter/flutter/assets/31859944/5e700d21-3c5e-4990-bfb5-153f44f1c517)
    LongCatIsLooong authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    ec47148 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f629dc8 View commit details
    Browse the repository at this point in the history
  5. Makes scheme and target optional parameter when getting universal lin… (

    #134571)
    
    �k settings
    
    the show build settings xcode command can only accept one of the target or scheme flag. Therefore I make them optional.
    chunhtai authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    367203b View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2023

  1. Roll Flutter Engine from 45bc4307cda3 to 67dd12f8dfca (6 revisions) (#…

    …134791)
    
    flutter/engine@45bc430...67dd12f
    
    2023-09-14 [email protected] Roll Dart SDK from
    d25e8d682c8f to 7e4d9f4d8e52 (3 revisions) (flutter/engine#45854)
    2023-09-14 [email protected] Remove @pragma('vm:entry-point')
    annotations on members that aren't accessed from C++
    (flutter/engine#45697)
    2023-09-14 [email protected] Roll Skia from 6bc9f5886ddf to
    9b7c116ed6c2 (1 revision) (flutter/engine#45853)
    2023-09-14 [email protected] Switch
    linux_android_debug_engine from goma to reclient (flutter/engine#45345)
    2023-09-14 [email protected] Switch goma to
    reclient fro standalone targets (flutter/engine#45804)
    2023-09-14 [email protected] Handle
    external window's `WM_CLOSE` in lifecycle manager (flutter/engine#45840)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the
    revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 16, 2023
    Configuration menu
    Copy the full SHA
    18ad09e View commit details
    Browse the repository at this point in the history
  2. Manual roll Flutter Engine from 67dd12f8dfca to 5aa9db365ed6 (5 revis…

    …ions) (#134856)
    
    Manual roll requested by [email protected]
    
    flutter/engine@67dd12f...5aa9db3
    
    2023-09-15 [email protected] Roll Skia from 37ea783440ea to
    7aa8bfaa63fc (1 revision) (flutter/engine#45861)
    2023-09-14 [email protected] Roll Skia from 8c9e378c4902 to
    37ea783440ea (1 revision) (flutter/engine#45859)
    2023-09-14 [email protected] Reduce unnecessary
    Dart_TimelineGetMicros call (flutter/engine#45637)
    2023-09-14 [email protected] Roll Skia from 9b7c116ed6c2 to
    8c9e378c4902 (3 revisions) (flutter/engine#45858)
    2023-09-14 [email protected] Set tests to run
    on macOS 12 (flutter/engine#45855)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the
    revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 16, 2023
    Configuration menu
    Copy the full SHA
    30cd285 View commit details
    Browse the repository at this point in the history
  3. Manual roll Flutter Engine from 5aa9db365ed6 to c0eaf2633686 (5 revis…

    …ions) (#134860)
    
    Manual roll requested by [email protected]
    
    flutter/engine@5aa9db3...c0eaf26
    
    2023-09-15 [email protected] Roll Dart SDK from
    c0a505f9d1dd to 65117290c3b0 (1 revision) (flutter/engine#45867)
    2023-09-15 [email protected] Roll Fuchsia Mac SDK from
    FF4r9-tqhioBbRG9f... to --OUw__L3ekVTG-5c... (flutter/engine#45866)
    2023-09-15 [email protected] Roll Fuchsia Linux SDK from
    MzLcTzBiWJ7o3Q2_Z... to ES0r-mYplPOBYHvUQ... (flutter/engine#45865)
    2023-09-15 [email protected] Roll Dart SDK from
    7e4d9f4d8e52 to c0a505f9d1dd (1 revision) (flutter/engine#45864)
    2023-09-15 [email protected] Roll Skia from 7aa8bfaa63fc to
    c0cabb0f93c9 (1 revision) (flutter/engine#45863)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from MzLcTzBiWJ7o to ES0r-mYplPOB
      fuchsia/sdk/core/mac-amd64 from FF4r9-tqhioB to --OUw__L3ekV
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the
    revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 16, 2023
    Configuration menu
    Copy the full SHA
    ae74369 View commit details
    Browse the repository at this point in the history
  4. Manual roll Flutter Engine from c0eaf2633686 to d623ecf43c66 (5 revis…

    …ions) (#134861)
    
    Manual roll requested by [email protected]
    
    flutter/engine@c0eaf26...d623ecf
    
    2023-09-15 [email protected] Roll Skia from 3492fc567816 to
    de56f293eb41 (1 revision) (flutter/engine#45878)
    2023-09-15 [email protected] Roll Skia from 6e286034109e to
    3492fc567816 (1 revision) (flutter/engine#45876)
    2023-09-15 [email protected] Roll Skia from 824b1973703d to
    6e286034109e (1 revision) (flutter/engine#45875)
    2023-09-15 [email protected] Roll Skia from 4f7aafd0c853 to
    824b1973703d (1 revision) (flutter/engine#45871)
    2023-09-15 [email protected] Roll Skia from c0cabb0f93c9 to
    4f7aafd0c853 (1 revision) (flutter/engine#45868)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the
    revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 16, 2023
    Configuration menu
    Copy the full SHA
    0032d9b View commit details
    Browse the repository at this point in the history
  5. Manual roll Flutter Engine from d623ecf43c66 to 51e643de62aa (5 revis…

    …ions) (#134865)
    
    Manual roll requested by [email protected]
    
    flutter/engine@d623ecf...51e643d
    
    2023-09-15 [email protected] Adds a --quiet flag to run_tests.py (flutter/engine#45880)
    2023-09-15 [email protected] Update AGP and Kotlin for scenario app  (flutter/engine#45549)
    2023-09-15 [email protected] Migrate GrMipmapped->skgpu::Mipmapped (flutter/engine#45881)
    2023-09-15 [email protected] [Impeller] Introduce mock vulkan context builder (flutter/engine#45834)
    2023-09-15 [email protected] Roll Fuchsia Linux SDK from ES0r-mYplPOBYHvUQ... to wWzXsy6kx1sp8Km34... (flutter/engine#45879)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from ES0r-mYplPOB to wWzXsy6kx1sp
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 16, 2023
    Configuration menu
    Copy the full SHA
    b8dc118 View commit details
    Browse the repository at this point in the history
  6. Manual roll Flutter Engine from 51e643de62aa to 326faf1762d6 (6 revis…

    …ions) (#134875)
    
    Manual roll requested by [email protected]
    
    flutter/engine@51e643d...326faf1
    
    2023-09-15 [email protected] Roll Skia from c79441fc8016 to 4f26f22daa4b (1 revision) (flutter/engine#45893)
    2023-09-15 [email protected] Roll Skia from 58c509b1a24a to c79441fc8016 (1 revision) (flutter/engine#45892)
    2023-09-15 [email protected] Roll Skia from fffef1047640 to 58c509b1a24a (2 revisions) (flutter/engine#45888)
    2023-09-15 [email protected] Roll Dart SDK from 65117290c3b0 to a5ee0055cf20 (1 revision) (flutter/engine#45887)
    2023-09-15 [email protected] Roll Fuchsia Mac SDK from --OUw__L3ekVTG-5c... to -_edKGA5GTkDFxVgl... (flutter/engine#45886)
    2023-09-15 [email protected] Roll Skia from de56f293eb41 to fffef1047640 (2 revisions) (flutter/engine#45885)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/mac-amd64 from --OUw__L3ekV to -_edKGA5GTkD
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 16, 2023
    Configuration menu
    Copy the full SHA
    e1428bf View commit details
    Browse the repository at this point in the history
  7. Manual roll Flutter Engine from 326faf1762d6 to 30b7e9ded7a0 (5 revis…

    …ions) (#134876)
    
    Manual roll requested by [email protected]
    
    flutter/engine@326faf1...30b7e9d
    
    2023-09-15 [email protected] Roll Skia from 7f88bda24f7f to 0057898979a1 (1 revision) (flutter/engine#45904)
    2023-09-15 [email protected] [Impeller] Test `FenceWaiterVK` and fix termination bugs (flutter/engine#45870)
    2023-09-15 [email protected] Roll Dart SDK from a5ee0055cf20 to e9452310189b (1 revision) (flutter/engine#45902)
    2023-09-15 [email protected] Roll Skia from 4f26f22daa4b to 7f88bda24f7f (5 revisions) (flutter/engine#45901)
    2023-09-15 [email protected] [Impeller] dont cache failed render target allocations. (flutter/engine#45895)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 16, 2023
    Configuration menu
    Copy the full SHA
    e5e36ad View commit details
    Browse the repository at this point in the history
Loading