-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: 684247a3c78a
head repository: flutter/flutter
compare: ddf60fb08733
- 12 commits
- 55 files changed
- 5 contributors
Commits on Jan 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 05854af - Browse repository at this point
Copy the full SHA 05854afView commit details -
Run module_test_ios on arm and x64 (#141815)
This will ensure the test runs on the supported platforms.
Configuration menu - View commit details
-
Copy full SHA for 6f7aed5 - Browse repository at this point
Copy the full SHA 6f7aed5View commit details -
Fix "Delete" tooltip is shown disabled on chips with
onDeletedcall……back (#141770) fixes [Disabled chips with `onDeleted` callback shows "Delete" tooltip on hover](#141336) ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return const MaterialApp( debugShowCheckedModeBanner: false, home: Example(), ); } } class Example extends StatefulWidget { const Example({super.key}); @OverRide State<Example> createState() => _ExampleState(); } class _ExampleState extends State<Example> { bool _isEnable = false; @OverRide Widget build(BuildContext context) { return Scaffold( body: Center( child: Column( mainAxisAlignment: MainAxisAlignment.spaceEvenly, children: <Widget>[ RawChip( label: const Text('RawChip'), onPressed: () {}, isEnabled: _isEnable, onDeleted: () {}, ), FilterChip( label: const Text('FilterChip'), selected: false, onSelected: _isEnable ? (bool value) {} : null, onDeleted: () {}, ), InputChip( label: const Text('InputChip'), isEnabled: _isEnable, onDeleted: () {}, ), ], ), ), floatingActionButton: FloatingActionButton.extended( onPressed: () { setState(() { _isEnable = !_isEnable; }); }, label: Text(_isEnable ? 'Disable' : 'Enable'), ), ); } } ``` </details> ### Preview | Before | After | | --------------- | --------------- | | <img src="https://github.com/flutter/flutter/assets/48603081/f80ae5f7-0a6d-4041-ade3-cbc2b5c78188" height="450" /> | <img src="https://github.com/flutter/flutter/assets/48603081/04e62854-e3f1-4b65-9753-183d288f3cfe" height="450" /> |
Configuration menu - View commit details
-
Copy full SHA for 788614d - Browse repository at this point
Copy the full SHA 788614dView commit details -
Roll Flutter Engine from f2b441a26416 to 517fc2bbfa51 (2 revisions) (#…
…141904) flutter/engine@f2b441a...517fc2b 2024-01-19 [email protected] Roll Skia from fabb71dcf9b7 to 61a2dcff4194 (1 revision) (flutter/engine#49904) 2024-01-19 [email protected] Roll Skia from c09908c48f14 to fabb71dcf9b7 (3 revisions) (flutter/engine#49902) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for cd6fe51 - Browse repository at this point
Copy the full SHA cd6fe51View commit details -
Roll Flutter Engine from 517fc2bbfa51 to d00e55f7f8ed (1 revision) (#…
…141909) flutter/engine@517fc2b...d00e55f 2024-01-19 [email protected] [Windows] Refactor EGL initialization (flutter/engine#49895) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for bc254ce - Browse repository at this point
Copy the full SHA bc254ceView commit details
Commits on Jan 20, 2024
-
Remove more textScaleFactor references (#141816)
Remove more `textScaleFactor` references from flutter/flutter. - Some changes are related to label scaling: the padding EdgeInsets values of some chip subclasses scale linearly between predetermined "max" padding values and "min" padding values. Before they scale with the `textScaleFactor` scalar, now they scale with the font size and are still capped at the original "max" and "min" values. - The rest of them are tests or size heuristics that depend on `textScaleFactor`, these are replaced by an effective text scale factor computed using a default font size (which is determined in a pretty random fashion, but it will only make a difference on Android 14+). No API changes in this batch. There are still some references left that I intend to remove in a different batch that would introduce API changes.
Configuration menu - View commit details
-
Copy full SHA for 5892a00 - Browse repository at this point
Copy the full SHA 5892a00View commit details -
Roll Flutter Engine from d00e55f7f8ed to a9b87c6288d2 (3 revisions) (#…
…141914) flutter/engine@d00e55f...a9b87c6 2024-01-20 [email protected] [Impeller] null check vertex buffer. (flutter/engine#49915) 2024-01-19 [email protected] [Impeller] adds vulkan golden images (flutter/engine#49849) 2024-01-19 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Fuchsia] Redo - Use chromium test-scripts to download images and execute tests" (flutter/engine#49908) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 3842c24 - Browse repository at this point
Copy the full SHA 3842c24View commit details -
Roll Flutter Engine from a9b87c6288d2 to 53a2436cf75c (1 revision) (#…
…141916) flutter/engine@a9b87c6...53a2436 2024-01-20 [email protected] [Impeller] use string view for labels in more places to defer allocatons. (flutter/engine#49905) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 0d73663 - Browse repository at this point
Copy the full SHA 0d73663View commit details -
Roll Flutter Engine from 53a2436cf75c to 4d67f267b115 (1 revision) (#…
…141917) flutter/engine@53a2436...4d67f26 2024-01-20 [email protected] [Impeller] Encode directly to command buffer for Metal. (flutter/engine#49785) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 61c3455 - Browse repository at this point
Copy the full SHA 61c3455View commit details -
Roll Flutter Engine from 4d67f267b115 to 6f6649bdfef2 (1 revision) (#…
…141920) flutter/engine@4d67f26...6f6649b 2024-01-20 [email protected] Roll Skia from 61a2dcff4194 to 3cac1efbdd7a (4 revisions) (flutter/engine#49916) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 3225cfe - Browse repository at this point
Copy the full SHA 3225cfeView commit details -
Roll Flutter Engine from 6f6649bdfef2 to 1385f76018ab (1 revision) (#…
…141926) flutter/engine@6f6649b...1385f76 2024-01-20 [email protected] Manual roll Dart SDK from 8d697eaa395c to 7a91ef52d200 (5 revisions) (flutter/engine#49917) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 3c1cb8a - Browse repository at this point
Copy the full SHA 3c1cb8aView commit details -
Roll Flutter Engine from 1385f76018ab to 704ef3399012 (1 revision) (#…
…141932) flutter/engine@1385f76...704ef33 2024-01-20 [email protected] Roll Fuchsia Linux SDK from geXIwPzzJiSXrZEEb... to kOnlSGX_aTAK7vvLc... (flutter/engine#49919) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from geXIwPzzJiSX to kOnlSGX_aTAK If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for ddf60fb - Browse repository at this point
Copy the full SHA ddf60fbView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 684247a3c78a...ddf60fb08733