Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 684247a3c78a
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ddf60fb08733
Choose a head ref
  • 12 commits
  • 55 files changed
  • 5 contributors

Commits on Jan 19, 2024

  1. Configuration menu
    Copy the full SHA
    05854af View commit details
    Browse the repository at this point in the history
  2. Run module_test_ios on arm and x64 (#141815)

    This will ensure the test runs on the supported platforms.
    godofredoc authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    6f7aed5 View commit details
    Browse the repository at this point in the history
  3. Fix "Delete" tooltip is shown disabled on chips with onDeleted call…

    …back (#141770)
    
    fixes [Disabled chips with `onDeleted` callback shows "Delete" tooltip on hover](#141336)
    
    ### Code sample
    
    <details>
    <summary>expand to view the code sample</summary> 
    
    ```dart
    import 'package:flutter/material.dart';
    
    void main() => runApp(const MyApp());
    
    class MyApp extends StatelessWidget {
      const MyApp({super.key});
    
      @OverRide
      Widget build(BuildContext context) {
        return const MaterialApp(
          debugShowCheckedModeBanner: false,
          home: Example(),
        );
      }
    }
    
    class Example extends StatefulWidget {
      const Example({super.key});
    
      @OverRide
      State<Example> createState() => _ExampleState();
    }
    
    class _ExampleState extends State<Example> {
      bool _isEnable = false;
    
      @OverRide
      Widget build(BuildContext context) {
        return Scaffold(
          body: Center(
            child: Column(
              mainAxisAlignment: MainAxisAlignment.spaceEvenly,
              children: <Widget>[
                RawChip(
                  label: const Text('RawChip'),
                  onPressed: () {},
                  isEnabled: _isEnable,
                  onDeleted: () {},
                ),
                FilterChip(
                  label: const Text('FilterChip'),
                  selected: false,
                  onSelected: _isEnable ? (bool value) {} : null,
                  onDeleted: () {},
                ),
                InputChip(
                  label: const Text('InputChip'),
                  isEnabled: _isEnable,
                  onDeleted: () {},
                ),
              ],
            ),
          ),
          floatingActionButton: FloatingActionButton.extended(
            onPressed: () {
              setState(() {
                _isEnable = !_isEnable;
              });
            },
            label: Text(_isEnable ? 'Disable' : 'Enable'),
          ),
        );
      }
    }
    ```
    
    </details>
    
    ### Preview
    
    | Before | After |
    | --------------- | --------------- |
    | <img src="https://github.com/flutter/flutter/assets/48603081/f80ae5f7-0a6d-4041-ade3-cbc2b5c78188" height="450" /> | <img src="https://github.com/flutter/flutter/assets/48603081/04e62854-e3f1-4b65-9753-183d288f3cfe" height="450" /> |
    TahaTesser authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    788614d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cd6fe51 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bc254ce View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Remove more textScaleFactor references (#141816)

    Remove more `textScaleFactor` references from flutter/flutter.  
    
    - Some changes are related to label scaling: the padding EdgeInsets values of some chip subclasses scale linearly between predetermined "max" padding values and "min" padding values. Before they scale with the `textScaleFactor` scalar, now they scale with the font size and are still capped at the original "max" and "min" values.
    - The rest of them are tests or size heuristics that depend on `textScaleFactor`, these are replaced by an effective text scale factor computed using a default font size (which is determined in a pretty random fashion, but it will only make a difference on Android 14+).
    
    No API changes in this batch. There are still some references left that I intend to remove in a different batch that would introduce API changes.
    LongCatIsLooong authored Jan 20, 2024
    Configuration menu
    Copy the full SHA
    5892a00 View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from d00e55f7f8ed to a9b87c6288d2 (3 revisions) (#…

    …141914)
    
    flutter/engine@d00e55f...a9b87c6
    
    2024-01-20 [email protected] [Impeller] null check vertex buffer. (flutter/engine#49915)
    2024-01-19 [email protected] [Impeller] adds vulkan golden images (flutter/engine#49849)
    2024-01-19 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Fuchsia] Redo - Use chromium test-scripts to download images and execute tests" (flutter/engine#49908)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jan 20, 2024
    Configuration menu
    Copy the full SHA
    3842c24 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0d73663 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    61c3455 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3225cfe View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3c1cb8a View commit details
    Browse the repository at this point in the history
  7. Roll Flutter Engine from 1385f76018ab to 704ef3399012 (1 revision) (#…

    …141932)
    
    flutter/engine@1385f76...704ef33
    
    2024-01-20 [email protected] Roll Fuchsia Linux SDK from geXIwPzzJiSXrZEEb... to kOnlSGX_aTAK7vvLc... (flutter/engine#49919)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from geXIwPzzJiSX to kOnlSGX_aTAK
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jan 20, 2024
    Configuration menu
    Copy the full SHA
    ddf60fb View commit details
    Browse the repository at this point in the history
Loading