Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 63170e984e19
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b444e7897e24
Choose a head ref
  • 13 commits
  • 20 files changed
  • 7 contributors

Commits on Sep 6, 2026

  1. Configuration menu
    Copy the full SHA
    ffba1cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    882e0b7 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2026

  1. Configuration menu
    Copy the full SHA
    d6bed8f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b3ae778 View commit details
    Browse the repository at this point in the history
  3. Roll Skia from e1437642d259 to b3fa80a0e168 (5 revisions) (#192362)

    https://skia.googlesource.com/skia.git/+log/e1437642d259..b3fa80a0e168
    
    2026-09-07 [email protected] Roll ANGLE
    from a404d7f7f817 to 52f594287836 (13 revisions)
    2026-09-07 [email protected] Roll
    debugger-app-base from fd0291e56fb6 to 6450bc7cb052
    2026-09-07 [email protected] Roll Skia
    Infra from 43e36b5c5eea to fe7060b135d0 (11 revisions)
    2026-09-07 [email protected] Roll Dawn
    from 91158020c0b1 to f45d1eb98a88 (17 revisions)
    2026-09-07 [email protected] Roll
    shaders-base from 503b59e71e1e to 2c861cb82614
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 7, 2026
    Configuration menu
    Copy the full SHA
    8698e4d View commit details
    Browse the repository at this point in the history
  4. Add itemExtentBuilder support to ListView.separated (#191157)

    This PR adds `itemExtentBuilder` support to `ListView.separated`,
    allowing optimal scrolling performance when item and separator extents
    are known.
    
    Closes #138758
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    If this change needs to override an active code freeze, provide a
    comment explaining why. The code freeze workflow can be overridden by
    code reviewers. See pinned issues for any active code freezes with
    guidance.
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    Mairramer authored Sep 7, 2026
    Configuration menu
    Copy the full SHA
    5f6e3ed View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2026

  1. ci: update dartdoc from 9.0.6 to 9.0.9 (#192405)

    A bug in `dartdoc` 9.0.6 is causing a RangeError during
    `_stripDocImports` during `@docImport` processing. The changelog
    indicates this was fixed in 9.0.8.
    
    https://github.com/dart-lang/dartdoc/blob/main/CHANGELOG.md#908
    
    Not rolling to 9.0.9 since that introduces new dependency constraints.
    
    <!--
    Thanks for filing a pull request!
    Reviewers are typically assigned within a week of filing a request.
    To learn more about code review, see our documentation on Tree Hygiene:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    -->
    
    ## Pre-launch Checklist
    
    - [X] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [X] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [X] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [X] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [X] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above, or I'm just desperate to get the tree green.
    - [X] I updated/added relevant in-code documentation (doc comments with
    `///`).
    - [X] If this PR introduces a new feature or capability, I created and
    linked a website documentation issue or PR in [flutter/website] (or
    verified none is needed).
    - [X] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [X] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [X] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    If this change needs to override an active code freeze, provide a
    comment explaining why. The code freeze workflow can be overridden by
    code reviewers. See pinned issues for any active code freezes with
    guidance.
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [flutter/website]: https://github.com/flutter/website
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    cbracken authored Sep 8, 2026
    Configuration menu
    Copy the full SHA
    6dbf67f View commit details
    Browse the repository at this point in the history
  2. [Linux] Don't clear the OpenGL context when a frame has been drawn (#…

    …192137)
    
    The draw handler made a context current to draw the frame with, then
    cleared it, leaving no context current at all while GTK finished the
    frame.
    
    GTK makes the context it needs current before using OpenGL, so this
    doesn't need to be cleared. But GTK doesn't check that making its
    context current succeeded, and if it fails it carries on and uses OpenGL
    with no context current, which crashes.
    
    Leaving the context current means GTK still has one to fall back on when
    this happens, so it doesn't crash.
    
    See #191775
    robert-ancell authored Sep 8, 2026
    Configuration menu
    Copy the full SHA
    45f4e3d View commit details
    Browse the repository at this point in the history
  3. [flutter_tools] Safely remove web loading indicator on dart-app-ready (…

    …#192233)
    
    Fixes #192226
    
    ### Problem
    In `packages/flutter_tools/lib/src/web/bootstrap.dart`, when compiling
    the web bootstrap script (`main.dart.js`), an event listener was added
    to `window` for `dart-app-ready` that executed:
    ```javascript
    loader.parentNode.removeChild(loader);
    ```
    On initial load, this removes the loader from the DOM, setting
    `loader.parentNode` to `null`.
    When DWDS reconnects or re-dispatches `dart-app-ready` (e.g. following a
    WebSocket disconnect/reconnect), this listener was invoked again.
    Attempting to call `.removeChild` on a `null` `parentNode` threw:
    ```
    TypeError: Cannot read properties of null (reading 'removeChild')
    ```
    
    ### Solution
    1. Use `loader.remove()` and `styleSheet.remove()` instead of
    `parentNode.removeChild()`.
    2. Configure the event listener with `{ once: true }` so it is
    automatically removed after firing once.
    
    ### Tests
    Added regression unit tests to
    `packages/flutter_tools/test/general.shard/web/bootstrap_test.dart`
    verifying that `{ once: true }` and `.remove()` are used in generated
    web bootstrap code.
    bkonyi authored Sep 8, 2026
    Configuration menu
    Copy the full SHA
    78ca392 View commit details
    Browse the repository at this point in the history
  4. [tool] Let --local-engine reach the build system again (#192361)

    Desktop builds with --local-engine quietly used the cached engine
    instead of the one just built, and often failed outright with "Can't
    load Kernel binary: Invalid SDK hash", because cached engine artifacts
    stop being updated once --local-engine is used and eventually no longer
    match the Dart SDK.
    
    Commands are created with the artifacts to build against when the tool
    starts up, which is before the command line has been parsed, so they
    always used the cached ones. --local-engine and --local-web-sdk were
    applied afterwards, and only to the legacy zone that commands used to
    read artifacts from. flutter assemble stopped reading from that zone in
    #190773, taking the build system with it.
    
    Use artifacts that can be changed after they are created instead, and
    update them as soon as the runner has parsed the command line, which
    happens before any command runs. Everything then builds against the
    right engine.
    robert-ancell authored Sep 8, 2026
    Configuration menu
    Copy the full SHA
    20b9fec View commit details
    Browse the repository at this point in the history
  5. Remove no-shuffle from scrollbar test (#186656)

    Part of #85160
    
    
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    If this change needs to override an active code freeze, provide a
    comment explaining why. The code freeze workflow can be overridden by
    code reviewers. See pinned issues for any active code freezes with
    guidance.
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    ValentinVignal authored Sep 8, 2026
    Configuration menu
    Copy the full SHA
    9f6cac2 View commit details
    Browse the repository at this point in the history
  6. Remove no-shuffle tag from dropdown_test.dart (#186398)

    Part of #85160
    
    It seems, the tests were already fixed, when I run with the seed `456`
    or `1408669812`
    
    ```
    flutter test test/material/dropdown_test.dart --test-randomize-ordering-seed=1408669812   
    Building flutter tool...
    Resolving dependencies... (1.0s)
    Downloading packages... 
    Got dependencies.
    Resolving dependencies in `/Users/valentinvignal/Projects/flutter`... 
    Downloading packages... 
      _fe_analyzer_shared 95.0.0 (100.0.0 available)
      adaptive_breakpoints 0.1.7 (discontinued)
      analyzer 10.1.0 (13.0.0 available)
      archive 3.6.1 (4.0.9 available)
      cli_util 0.4.2 (0.5.1 available)
      dart_style 3.1.7 (3.1.9 available)
      device_info 2.0.3 (discontinued replaced by device_info_plus)
      devtools_shared 12.1.0 (13.0.1 available)
      gcloud 0.8.19 (0.9.0 available)
      google_fonts 6.3.3 (8.1.0 available)
      googleapis 14.0.0 (16.0.0 available)
      googleapis_auth 2.3.0 (2.3.1 available)
      isolate 2.1.1 (discontinued)
      js 0.7.2 (discontinued)
      native_toolchain_c 0.17.6 (0.18.0 available)
      pedantic 1.11.1 (discontinued replaced by lints)
      video_player_avfoundation 2.9.5 (2.9.6 available)
      xml 6.6.1 (7.0.1 available)
    Got dependencies in `/Users/valentinvignal/Projects/flutter`!
    5 packages are discontinued.
    13 packages have newer versions incompatible with dependency constraints.
    Try `flutter pub outdated` for more information.
    Shuffling test order with --test-randomize-ordering-seed=1408669812
    00:32 +123: All tests passed!       
    ```
    
    
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    If this change needs to override an active code freeze, provide a
    comment explaining why. The code freeze workflow can be overridden by
    code reviewers. See pinned issues for any active code freezes with
    guidance.
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    ValentinVignal authored Sep 8, 2026
    Configuration menu
    Copy the full SHA
    3238b12 View commit details
    Browse the repository at this point in the history
  7. Clean up lint errors in workflows (#191987)

    This PR resolves shellcheck and syntax issues flagged by `actionlint`
    across GitHub Actions workflows.
    
    I've been using `actionlint` to check workflows for errors. This brings
    it clean.
    
    Fixing others in
    - no-main-prs: #191973
    - scheduled-localization-update:
    #191991
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    If this change needs to override an active code freeze, provide a
    comment explaining why. The code freeze workflow can be overridden by
    code reviewers. See pinned issues for any active code freezes with
    guidance.
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    Piinks authored Sep 8, 2026
    Configuration menu
    Copy the full SHA
    b444e78 View commit details
    Browse the repository at this point in the history
Loading