Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5dea6b994e8f
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3ee8ff287a6e
Choose a head ref
  • 9 commits
  • 31 files changed
  • 4 contributors

Commits on Jan 22, 2024

  1. Configuration menu
    Copy the full SHA
    fb3a1e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5caa8b8 View commit details
    Browse the repository at this point in the history
  3. Update ToggleButtons, ExpansionPanel, and ExpandIcon tests for …

    …Material 3 (#141868)
    
    Updated unit tests for `ToggleButtons`, `ExpansionPanel`, and `ExpandIcon` to have M2 and M3 versions.
    
    More info in #139076
    TahaTesser authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    0ef4638 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ce97e34 View commit details
    Browse the repository at this point in the history
  5. Reapply "Native assets: roll deps" (#141748) (#141864)

    Fixes #141827
    
    Reland: https://dart-review.googlesource.com/c/sdk/+/346960 has rolled into g3, so the imports should now resolve in g3 as well.
    
    > [!CAUTION]
    > _Do NOT merge if "Google Testing" bot didn't run!_
    
    Rolls the packages from https://github.com/dart-lang/native in the native assets implementation.
    
    Most notable we're refactoring `package:native_assets_cli` for `build.dart` use.
    Therefore, all imports to that package for Flutter/Dart should be to the implementation internals that are no longer visible for `build.dart` writers. Hence all the import updates.
    
    No behavior in Flutter apps should change.
    
    This PR also updates the template to use the latests version of `package:native_assets_cli` which no longer exposes all the implementation details.
    dcharkes authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    634b326 View commit details
    Browse the repository at this point in the history
  6. Fix shape and collapsedShape isn't applied to ExpansionTile's s…

    …plash ink (#141777)
    
    This updates the previous attempt #135855 and removes the complications when testing M3 ink sparkle effect. 
    Thanks to this [PR](#138757) by @Piinks 
    
    fixes [ExpansionTile InkSplash doesn't respect Shape's borderRadius](#125779)
    fixes [`ExpansionTile.backgroundColor` &  `ExpansionTile.collapsedBackgroundColor` removes splash effect](#107113)
    
    ### Code sample
    
    <details>
    <summary>expand to view the code sample</summary> 
    
    ```dart
    import 'package:flutter/material.dart';
    
    void main() => runApp(const MyApp());
    
    class MyApp extends StatelessWidget {
      const MyApp({super.key});
    
      @OverRide
      Widget build(BuildContext context) {
        return const MaterialApp(
          debugShowCheckedModeBanner: false,
          home: Example(),
        );
      }
    }
    
    class Example extends StatelessWidget {
      const Example({super.key});
    
      @OverRide
      Widget build(BuildContext context) {
        return const Scaffold(
          body: Center(
              child: Padding(
            padding: EdgeInsets.symmetric(horizontal: 24.0),
            child: ExpansionTile(
              collapsedBackgroundColor: Color(0x25ff0000),
              backgroundColor: Color(0x250000ff),
              collapsedShape: RoundedRectangleBorder(
                borderRadius: BorderRadius.all(Radius.circular(30.0)),
                side: BorderSide(color: Colors.black, width: 2.0),
              ),
              shape: RoundedRectangleBorder(
                borderRadius: BorderRadius.all(Radius.circular(30.0)),
                side: BorderSide(color: Colors.black, width: 2.0),
              ),
              clipBehavior: Clip.hardEdge,
              title: Text('Expansion Tile'),
              children: <Widget>[
                FlutterLogo(size: 50),
                FlutterLogo(size: 50),
                FlutterLogo(size: 50),
                FlutterLogo(size: 50),
    
              ],
            ),
          )),
        );
      }
    }
    ```
    
    </details>
    
    ### Before
    
    <img width="789" alt="Screenshot 2024-01-18 at 18 16 15" src="https://github.com/flutter/flutter/assets/48603081/8c6a6f1e-6986-4acf-8dec-e223a682c0d7">
    
    <img width="789" alt="Screenshot 2024-01-18 at 18 16 44" src="https://github.com/flutter/flutter/assets/48603081/f55f6a26-2128-48a1-b24d-3c14e4f6ecdc">
    
    ### After 
    <img width="789" alt="Screenshot 2024-01-18 at 18 20 27" src="https://github.com/flutter/flutter/assets/48603081/7ec8b888-7319-460d-8488-9cd44c9246a6">
    
    <img width="789" alt="Screenshot 2024-01-18 at 18 20 53" src="https://github.com/flutter/flutter/assets/48603081/80d66d5b-7eb2-4f47-ab4d-d7f469a731fa">
    TahaTesser authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    9574d58 View commit details
    Browse the repository at this point in the history
  7. Mark defaultTargetPlatform as constant for non-debug non-web builds. (#…

    …141105)
    
    This PR adds the Dart VM `vm:platform-const-if` pragma introduced in
    dart-lang/sdk@57a1168875 to the
    `defaultTargetPlatform` property, allowing it to be computed as if it
    was a constant field in non-debug AOT builds. In particular, this means
    that platform-specific code executed conditionally based on this
    property can be tree-shaken in release builds. Note that this PR changes
    `defaultTargetPlatform` to only allow overriding via
    `debugDefaultTargetPlatformOverride` in debug builds, and makes it so
    that compilation throws an error if code assigns
    to`debugDefaultTargetPlatformOverride` in other build modes.
    
    Related issue: #14233
    
    ## Pre-launch Checklist
    
    - [X] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [X] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [X] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [X] I signed the [CLA].
    - [X] I listed at least one issue that this PR fixes in the description
    above.
    - [X] I updated/added relevant documentation (doc comments with `///`).
    - [X] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [X] All existing and new tests are passing.
    sstrickl authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    7ca4b7b View commit details
    Browse the repository at this point in the history
  8. Roll Packages from 129e08c to e4cbf23 (11 revisions) (#141962)

    flutter/packages@129e08c...e4cbf23
    
    2024-01-21 [email protected] Roll Flutter from ddf60fb to 5dea6b9 (5 revisions) (flutter/packages#5951)
    2024-01-21 [email protected] Update platform label rules for shared iOS/macOS (flutter/packages#5801)
    2024-01-20 [email protected] [pigeon] Support other hosts in generated file CI checks (flutter/packages#5944)
    2024-01-20 [email protected] [pigeon] Improve style of generated Swift code (flutter/packages#5938)
    2024-01-20 [email protected] Roll Flutter from 684247a to ddf60fb (12 revisions) (flutter/packages#5949)
    2024-01-20 [email protected] [camera]fix a sample buffer memory leak on pause resume recording (flutter/packages#5927)
    2024-01-19 [email protected] [ci] Run Swift formatter and linter during CI formatting (flutter/packages#5928)
    2024-01-19 [email protected] Manual roll Flutter from f77f824 to 684247a (39 revisions) (flutter/packages#5948)
    2024-01-19 [email protected] Expose registered widget libraries and local widget library widgets. (flutter/packages#5936)
    2024-01-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.2.0 (flutter/packages#5937)
    2024-01-19 [email protected] Manual roll Flutter (stable) from ef1af02 to 67457e6 (1 revision) (flutter/packages#5932)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    bfa245f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3ee8ff2 View commit details
    Browse the repository at this point in the history
Loading