Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5dcb86f68f23
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a14f74ff3a1c
Choose a head ref
  • 3 commits
  • 8 files changed
  • 2 contributors

Commits on May 21, 2024

  1. [CP-stable]Fixes incorrect read/write permissions on Flutter.framewor…

    …k and FlutterMacOS.framework (#148717)
    
    This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process#automatically-creates-a-cherry-pick-request)
    Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
    
    ### Issue Link:
    What is the link to the issue this cherry-pick is addressing?
    #148354
    #147142
    
    ### Changelog Description:
    Correct read/write permisions for FlutterMacOS.framework to allow MacOS developers to publish to the app store
    
    ### Impact Description:
    MacOS developers.
    
    ### Workaround:
    Is there a workaround for this issue?
    
    Run chmod locally after building #148354 (comment)
    
    ### Risk:
    What is the risk level of this cherry-pick?
    
    ### Test Coverage:
    Are you confident that your fix is well-tested by automated tests?
    
    ### Validation Steps:
    What are the steps to validate that this fix works?
    
    1. `flutter build macos --release` any macos project
    2. `ls -la macos/Build/Products/Release/test_create.app/Contents/Frameworks/`
    3. Note that the permissions for FlutterMacOS.framework is `drwxr-xr-x`, NOT `dr-------`
    (note that this is validated to work here #148354 (comment))
    flutteractionsbot authored May 21, 2024
    Configuration menu
    Copy the full SHA
    ec6611b View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. [flutter_releases] Flutter stable 3.22.1 Framework Cherrypicks (#148816)

    # Flutter stable 3.22.1 Framework
    itsjustkevin authored May 22, 2024
    Configuration menu
    Copy the full SHA
    b76707a View commit details
    Browse the repository at this point in the history
  2. [CP] [devicelab] explicitly enable vulkan validation in test. (#147382)…

    … (#148863)
    
    Fix for release build failure https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20hello_world_impeller/3962/overview
    
    Part of #142659
    
    this test expects validation layers on, so we need to explicitly enable them before we can turn them off by default.
    itsjustkevin authored May 22, 2024
    2 Configuration menu
    Copy the full SHA
    a14f74f View commit details
    Browse the repository at this point in the history
Loading