Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 544d30dbaddf
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c40173f114fa
Choose a head ref
  • 10 commits
  • 33 files changed
  • 9 contributors

Commits on Jul 12, 2023

  1. Roll Flutter Engine from 5c887028810d to 16e2ab7e986c (2 revisions) (#…

    …130421)
    
    flutter/engine@5c88702...16e2ab7
    
    2023-07-12 [email protected] Roll Skia from ac4c113c071d to ebc149cff431 (4 revisions) (flutter/engine#43603)
    2023-07-12 [email protected] Roll Fuchsia Linux SDK from zTuZjXzI3bqscWmeo... to 1STsUj0X5YgpiSNEb... (flutter/engine#43602)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from zTuZjXzI3bqs to 1STsUj0X5Ygp
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    58acd60 View commit details
    Browse the repository at this point in the history
  2. Update Divider/VerticalDivider and theme tests for M2/M3 (#130415)

    Updated unit tests for `Divider`/ `VerticalDivider`  and theme to have M2 and M3 versions.
    
    More info in #128725
    TahaTesser authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    42924e2 View commit details
    Browse the repository at this point in the history
  3. Use platform specific line separator in gen-l10n (#130090)

    Currently files are not generated with `\r\n` in windows. This PR should
    fix the issue.
    
    Fixes #109761.
    thkim1011 authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    d75735e View commit details
    Browse the repository at this point in the history
  4. Add missing links to examples that aren't linked anywhere (#130422)

    ## Description
    
    This adds links to examples that were not linked anywhere.
    
    ## Related Issues
     - Fixes #129956
    
    ## Tests
     - Documentation only change
    gspencergoog authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    3d67ca4 View commit details
    Browse the repository at this point in the history
  5. Reland [a11y] CupertinoSwitch On/Off labels (#130173)

    This original PR (#127776) was reverted (#130166) due to a Google test failure.
    
    This reopens the PR as per the discussion in #130166 (comment).
    
    Fixes issue #4830.
    gilnobrega authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    a189d95 View commit details
    Browse the repository at this point in the history
  6. Refactor JSNumber.toDart and Object.toJS (#129436)

    JSNumber.toDart will now be two functions: toDartDouble and toDartInt.
    
    There was code that did an Object.toJS. This has been changed to
    use Function.toJS as well to make it consistent with the code
    in flutter/packages:
    https://github.com/flutter/packages/blob/0ef393811d0c2653e68ac135733353fcad8fffa9/packages/web_benchmarks/lib/src/recorder.dart#L1223
    
    This is to help land this CL:
    https://dart-review.googlesource.com/c/sdk/+/309082
    
    https://dart-review.googlesource.com/c/sdk/+/309081 is the CL that added
    the new methods.
    
    ## Pre-launch Checklist
    
    - [X] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [X] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [X] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [X] I signed the [CLA].
    - [X] I listed at least one issue that this PR fixes in the description
    above.
    - [X] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] All existing and new tests are passing.
    srujzs authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    ab39bff View commit details
    Browse the repository at this point in the history
  7. Update Checkbox tests for M2/M3 (#130351)

    Updated unit tests for `Checkbox` to have M2 and M3 versions.
    
    More info in #127064
    QuncCccccc authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    dd0b6e3 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Exclude Tooltip's overlay child from SelectableRegion (#130181)

    Fixes #129969 by making tooltip text unselectable (for now). 
    Also fixes some other issues uncovered when I was writing the tests.
    
    Currently `getTransformTo` only works on ancestors. I'll try to add a new method that computes the transform from 2 arbitrary render objects in the same render tree in a follow-up PR and make `Selectable` use that method instead.
    LongCatIsLooong authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    2da353a View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from 16e2ab7e986c to 1b1ccdd1f527 (13 revisions) (#…

    …130458)
    
    flutter/engine@16e2ab7...1b1ccdd
    
    2023-07-12 [email protected] Roll Skia from 4e989b1564ee to bedc92598644 (1 revision) (flutter/engine#43617)
    2023-07-12 [email protected] move rtree and canvas_spy sources to Fuchsia sub-directory (flutter/engine#43615)
    2023-07-12 [email protected] Roll Skia from 68e3c0b3eea7 to 4e989b1564ee (6 revisions) (flutter/engine#43614)
    2023-07-12 [email protected] Document (and assert) that channel names can't contains nulls (flutter/engine#43593)
    2023-07-12 [email protected] Reland "Refactor JSNumber.toDart and Object.toJS" (flutter/engine#43363)
    2023-07-12 [email protected] Add a flag to `ParagraphBuilder` for rounding hack migration (flutter/engine#43118)
    2023-07-12 [email protected] [Impeller] Fixes for asymmetric stencil descriptors (flutter/engine#43535)
    2023-07-12 [email protected] Roll Skia from adeeb8d50f7c to 68e3c0b3eea7 (1 revision) (flutter/engine#43609)
    2023-07-12 [email protected] Add comment to use of 3x3 mapRect in TransformLayer (flutter/engine#43608)
    2023-07-12 [email protected] Roll Skia from a251a36ea519 to adeeb8d50f7c (1 revision) (flutter/engine#43606)
    2023-07-12 [email protected] Roll Dart SDK from b95f6531c726 to 8f8f281ccdc6 (2 revisions) (flutter/engine#43607)
    2023-07-12 [email protected] Roll Skia from ebc149cff431 to a251a36ea519 (2 revisions) (flutter/engine#43604)
    2023-07-12 [email protected] [Impeller] Use new SkParagraph APIs for stroked text. (flutter/engine#41735)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    47ba59c View commit details
    Browse the repository at this point in the history
  3. Revert "Roll Flutter Engine from 16e2ab7e986c to 1b1ccdd1f527 (13 rev…

    …isions)" (#130479)
    
    Reverts #130458
    Jonah Williams authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    c40173f View commit details
    Browse the repository at this point in the history
Loading