Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 533d04d14df0
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4967a94cd907
Choose a head ref
  • 12 commits
  • 51 files changed
  • 5 contributors

Commits on Apr 8, 2024

  1. Add a custom shape example for AppBar.shape (#146421)

    fixes [AppBar shape disappears on AppBar elevation change when scrolling](#145945)
    
    ### Description
    This PR adds an example for complete custom app bar for the  `AppBar.shape` property.
    
    ### Preview
    
    ![Screenshot 2024-04-08 at 14 21 04](https://github.com/flutter/flutter/assets/48603081/ae3eda2b-b709-4652-9f2c-dd7b7dcfeb5c)
    TahaTesser authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    cba689c View commit details
    Browse the repository at this point in the history
  2. Roll pub packages (#146444)

    This PR was generated by `flutter update-packages --force-upgrade`.
    flutter-pub-roller-bot authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    84c7298 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8a4a46a View commit details
    Browse the repository at this point in the history
  4. Roll Flutter Engine from 1e88b2dbc7f7 to ceb5fa2c8651 (3 revisions) (#…

    …146447)
    
    flutter/engine@1e88b2d...ceb5fa2
    
    2024-04-08 [email protected] Add `missing_code_block_language_in_doc_comment` lint to flutter/engine. (flutter/engine#51944)
    2024-04-08 [email protected] Use the AOT snapshot built by the Dart SDK for the frontend server (flutter/engine#51943)
    2024-04-08 [email protected] Roll Skia from 50b7ff0bf275 to aa31cad3cbef (2 revisions) (flutter/engine#51968)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    670a8cc View commit details
    Browse the repository at this point in the history
  5. Fix DropdownButtonFormField throws when onChange is null (#146342)

    ## Description
    
    This PRs fixes a null pointer exception thrown when reset is called on a `DropdownButtonFormField` whose `onChange` callback is null.
    
    ## Related Issue
    
    Fixes #146335
    
    ## Tests
    
    Adds 1 tests.
    bleroux authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    f45741b View commit details
    Browse the repository at this point in the history
  6. Text editing inside of Transformed.scale (#146019)

    Fixes bugs in the text selection positioning calculations so that they work even when the field is scaled. In many cases, we were simply translating things around without applying the proper localToGlobal (or vice versa) transform.
    
    | Before | After |
    | --- | --- |
    | <img src="https://github.com/flutter/flutter/assets/389558/a5a45472-98c5-4cdf-b382-218971fd9404" /> | <img src="https://github.com/flutter/flutter/assets/389558/f396a1af-2546-4e38-a9d9-6c6edfa38d94" /> |
    
    Partial fix for: #144685
    It looks like there are other problems where transforms aren't applied properly. Putting a transform at the root of the application, above MaterialApp, will expose more problems.
    
    <details>
    
    <summary>Sample code</summary>
    
    ```dart
    import 'package:flutter/material.dart';
    import 'package:webview_flutter/webview_flutter.dart';
    
    void main() => runApp(const _App());
    
    class _App extends StatelessWidget {
      const _App();
    
      @OverRide
      Widget build(BuildContext context) {
        return const MaterialApp(home: _Home());
      }
    }
    
    class _Home extends StatefulWidget {
      const _Home();
    
      @OverRide
      State<_Home> createState() => _HomeState();
    }
    
    class _HomeState extends State<_Home> {
      final _controller = WebViewController();
      final TextEditingController textEditingController = TextEditingController(
        text: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.',
      );
      final OverlayPortalController overlayPortalController = OverlayPortalController();
    
      @OverRide
      void initState() {
        super.initState();
        _controller
          ..setJavaScriptMode(JavaScriptMode.unrestricted)
          ..loadRequest(Uri.https('api.flutter.dev'));
      }
    
      @OverRide
      Widget build(BuildContext context) {
        overlayPortalController.show();
        return Scaffold(
          appBar: AppBar(
            title: const Text('Scaled WebView Tester'),
          ),
          body: Stack(
            children: <Widget>[
              Transform.scale(
                alignment: Alignment.topLeft,
                scale: 0.5,
                child: TextField(
                  controller: textEditingController,
                  maxLines: null,
                ),
              ),
              OverlayPortal(
                controller: overlayPortalController,
                overlayChildBuilder: (BuildContext context) {
                  return Positioned(
                    top: 0.0,
                    left: 0.0,
                    child: SizedBox(
                      height: 1000,
                      width: 1000,
                      child: Stack(
                        children: <Widget>[
                          Positioned(
                            top: 90.0,
                            left: 0.0,
                            child: Container(
                              height: 1.0,
                              width: 1000,
                              color: Colors.blue,
                            ),
                          ),
                          Positioned(
                            top: 102.0,
                            left: 0.0,
                            child: Container(
                              height: 1.0,
                              width: 1000,
                              color: Colors.blue,
                            ),
                          ),
                        ],
                      ),
                    ),
                  );
                },
              ),
            ],
          ),
        );
      }
    }
    ```
    
    </details>
    justinmc authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    1cd946e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    137cb4b View commit details
    Browse the repository at this point in the history
  8. Roll Flutter Engine from 269aa69f47df to 8701a9a7fa41 (4 revisions) (#…

    …146463)
    
    flutter/engine@269aa69...8701a9a
    
    2024-04-08 [email protected] Roll Fuchsia Linux SDK from RNSwTRpc6cfMY99CC... to 82nvjI_UGVS8qYqyH... (flutter/engine#51972)
    2024-04-08 [email protected] Roll Dart SDK from f7239b3c25af to 28b5735ad7dc (4 revisions) (flutter/engine#51970)
    2024-04-08 [email protected] [et] Run GN before looking for targets. Default to build config targets (flutter/engine#51956)
    2024-04-08 [email protected] Run local_engine.json builds in prod (flutter/engine#51931)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from RNSwTRpc6cfM to 82nvjI_UGVS8
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    8f3652a View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Configuration menu
    Copy the full SHA
    4cfdd1f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c13e3fe View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a5be75 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4967a94 View commit details
    Browse the repository at this point in the history
Loading