Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5207a309e8d8
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f52fe4f7e55d
Choose a head ref
  • 18 commits
  • 12 files changed
  • 5 contributors

Commits on Oct 7, 2023

  1. Allow leaks around tap down/up, while flackiness is not fixed. (#136133)

    @polina-c
    polina-c authored Oct 7, 2023
    Configuration menu
    Copy the full SHA
    74f8b4f View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from 8711c1fd2191 to a18c52768bbc (6 revisions) (#… 

    …136141)

flutter/engine@8711c1f...a18c527

2023-10-07 [email protected] [Impeller] Add IMPELLER_DEBUG around group. (flutter/engine#46642)
2023-10-07 [email protected] Roll Skia from 6ce883877068 to 99d9d571f4dd (1 revision) (flutter/engine#46652)
2023-10-07 [email protected] Roll Fuchsia Linux SDK from a-BbzDtY3w8UXYgbK... to nX88TgPdoM6PK1wBq... (flutter/engine#46651)
2023-10-07 [email protected] Roll Fuchsia Mac SDK from GXgrnmetc14RPdheo... to NRLsjEUCmIz2f1Wox... (flutter/engine#46649)
2023-10-07 [email protected] Roll Skia from 15de5cc6a095 to 6ce883877068 (1 revision) (flutter/engine#46648)
2023-10-07 [email protected] Roll Dart SDK from 7ba556c43d35 to a88ed8cafd27 (1 revision) (flutter/engine#46647)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from a-BbzDtY3w8U to nX88TgPdoM6P
  fuchsia/sdk/core/mac-amd64 from GXgrnmetc14R to NRLsjEUCmIz2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 7, 2023
    Configuration menu
    Copy the full SHA
    7008520 View commit details
    Browse the repository at this point in the history

  3. Roll Flutter Engine from a18c52768bbc to 46b05f69187d (1 revision) (#… 

    …136142)

flutter/engine@a18c527...46b05f6

2023-10-07 [email protected] Roll Skia from 99d9d571f4dd to 3d77b5de5984 (1 revision) (flutter/engine#46653)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 7, 2023
    Configuration menu
    Copy the full SHA
    a672b01 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2023

  1. Roll Flutter Engine from 46b05f69187d to eb88bb5b5c4b (1 revision) (#… 

    …136145)

flutter/engine@46b05f6...eb88bb5

2023-10-08 [email protected] Roll Fuchsia Mac SDK from NRLsjEUCmIz2f1Wox... to qf94AgyANg4i0Supy... (flutter/engine#46654)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from NRLsjEUCmIz2 to qf94AgyANg4i

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 8, 2023
    Configuration menu
    Copy the full SHA
    0fef7a5 View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from eb88bb5b5c4b to 03c8c7724873 (1 revision) (#… 

    …136147)

flutter/engine@eb88bb5...03c8c77

2023-10-08 [email protected] Roll Fuchsia Linux SDK from nX88TgPdoM6PK1wBq... to 8ri3ggb_SASX6KpNn... (flutter/engine#46655)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from nX88TgPdoM6P to 8ri3ggb_SASX

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 8, 2023
    Configuration menu
    Copy the full SHA
    edf6625 View commit details
    Browse the repository at this point in the history

  3. Roll Flutter Engine from 03c8c7724873 to 0785e3c69f7c (2 revisions) (#… 

    …136150)

flutter/engine@03c8c77...0785e3c

2023-10-08 [email protected] Roll Skia from a04f2cfaf4d4 to ac67f4882568 (1 revision) (flutter/engine#46657)
2023-10-08 [email protected] Roll Skia from 3d77b5de5984 to a04f2cfaf4d4 (1 revision) (flutter/engine#46656)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 8, 2023
    Configuration menu
    Copy the full SHA
    901077b View commit details
    Browse the repository at this point in the history

  4. Roll Flutter Engine from 0785e3c69f7c to 34ffdf06ca93 (1 revision) (#… 

    …136156)

flutter/engine@0785e3c...34ffdf0

2023-10-08 [email protected] Roll Fuchsia Mac SDK from qf94AgyANg4i0Supy... to gaFsjQCR8UjK8EX-b... (flutter/engine#46658)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from qf94AgyANg4i to gaFsjQCR8UjK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 8, 2023
    Configuration menu
    Copy the full SHA
    f9ee41e View commit details
    Browse the repository at this point in the history

  5. Roll Flutter Engine from 34ffdf06ca93 to d5485d67b9f9 (1 revision) (#… 

    …136158)

flutter/engine@34ffdf0...d5485d6

2023-10-08 [email protected] Roll Fuchsia Linux SDK from 8ri3ggb_SASX6KpNn... to TTQty3yF7hRg2UFT8... (flutter/engine#46659)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 8ri3ggb_SASX to TTQty3yF7hRg

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 8, 2023
    Configuration menu
    Copy the full SHA
    10a128d View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Roll Flutter Engine from d5485d67b9f9 to 7b8f5d4297c6 (1 revision) (#… 

    …136168)

flutter/engine@d5485d6...7b8f5d4

2023-10-08 [email protected] Roll Skia from ac67f4882568 to fedfbe6383f0 (1 revision) (flutter/engine#46660)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ef5b209 View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from 7b8f5d4297c6 to e58a9b3c54b6 (1 revision) (#… 

    …136175)

flutter/engine@7b8f5d4...e58a9b3

2023-10-09 [email protected] Roll Fuchsia Mac SDK from gaFsjQCR8UjK8EX-b... to nN0l08yRbt0zE3R7a... (flutter/engine#46661)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from gaFsjQCR8UjK to nN0l08yRbt0z

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e27dc0a View commit details
    Browse the repository at this point in the history

  3. Update BottomSheet test for M3 + fix an issue in elevation resolution (… 

    …#136071)

This PR updates unit tests from bottom sheet tests for M3 migration.

More info in #127064

It also contains in bottom_sheet.dart where a default value took precedence over a theme attribute.
    @bleroux
    bleroux authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    a6d7124 View commit details
    Browse the repository at this point in the history

  4. Roll Flutter Engine from e58a9b3c54b6 to 53da096c0c38 (2 revisions) (#… 

    …136182)

flutter/engine@e58a9b3...53da096

2023-10-09 [email protected] Roll Skia from fedfbe6383f0 to 0507cc73ca2a (1 revision) (flutter/engine#46663)
2023-10-09 [email protected] Roll Fuchsia Linux SDK from TTQty3yF7hRg2UFT8... to 0ObCmDD14Cel45cU-... (flutter/engine#46662)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from TTQty3yF7hRg to 0ObCmDD14Cel

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    6ddeec2 View commit details
    Browse the repository at this point in the history

  5. Roll Flutter Engine from 53da096c0c38 to 69ffbd18ab5e (2 revisions) (#… 

    …136186)

flutter/engine@53da096...69ffbd1

2023-10-09 [email protected] Roll Skia from c844143823fb to 9fd74b688561 (1 revision) (flutter/engine#46665)
2023-10-09 [email protected] Roll Skia from 0507cc73ca2a to c844143823fb (1 revision) (flutter/engine#46664)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    b6d8b4c View commit details
    Browse the repository at this point in the history

  6. Roll Flutter Engine from 69ffbd18ab5e to 2886353ee612 (1 revision) (#… 

    …136187)

flutter/engine@69ffbd1...2886353

2023-10-09 [email protected] Roll Skia from 9fd74b688561 to 871c976c0ecc (1 revision) (flutter/engine#46666)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    c899ce3 View commit details
    Browse the repository at this point in the history

  7. Update CircleAvatar & DataTable tests for Material 3 (#135901) 

    Updated unit tests for `CircleAvatar` & `DataTable` to have M2 and M3 versions.

More info in #127064
    @TahaTesser
    TahaTesser authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    9ab091f View commit details
    Browse the repository at this point in the history

  8. Fix flutter drive instructions in Macrobenchmark README (#135990) 

    fixes [Macrobenchmark `README.md` is out-of-date](#132703)
    @TahaTesser
    TahaTesser authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e5d4575 View commit details
    Browse the repository at this point in the history

  9. Roll Flutter Engine from 2886353ee612 to 664f5e833871 (1 revision) (#… 

    …136195)

flutter/engine@2886353...664f5e8

2023-10-09 [email protected] Roll Skia from 871c976c0ecc to 3b83cd44d9ee (1 revision) (flutter/engine#46669)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    6dce142 View commit details
    Browse the repository at this point in the history

  10. [leak-tracking] Add leak tracking in test/painting #2 (#136169)

    @droidbg
    droidbg authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    f52fe4f View commit details
    Browse the repository at this point in the history
Loading