Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4967a94cd907
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 97cd47a02e60
Choose a head ref
  • 11 commits
  • 69 files changed
  • 7 contributors

Commits on Apr 9, 2024

  1. Roll Packages from 6b4d8b6 to 17f55d3 (6 revisions) (#146508)

    flutter/packages@6b4d8b6...17f55d3
    
    2024-04-09 [email protected] Release compileSdk changes (flutter/packages#6491)
    2024-04-08 [email protected] [camera_android] Remove `TestUtils.java` (flutter/packages#6490)
    2024-04-08 [email protected] Roll Flutter from 98d23f7 to 533d04d (12 revisions) (flutter/packages#6488)
    2024-04-08 [email protected] [go_router_builder] Add `restorationScopeId` to `ShellRouteData` (flutter/packages#6238)
    2024-04-08 [email protected] [go_router] Fixes deep links with no path (flutter/packages#6447)
    2024-04-08 [email protected] [in_app_purchase] Convert Android data objects to Pigeon (flutter/packages#6453)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    28e5b7f View commit details
    Browse the repository at this point in the history
  2. Roll pub packages (#146515)

    This PR was generated by `flutter update-packages --force-upgrade`.
    flutter-pub-roller-bot authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    6f9fff1 View commit details
    Browse the repository at this point in the history
  3. Fix skwasm tests (#145570)

    Skwasm tests are now running as `bringup: true` in postsubmit, but failing. Let's get them fixed.
    eyebrowsoffire authored Apr 9, 2024
    2 Configuration menu
    Copy the full SHA
    51e70fa View commit details
    Browse the repository at this point in the history
  4. Support mdns when attaching to proxied devices. (#146021)

    Also move the vm service discovery logic into platform-specific implementation of `Device`s. This is to avoid having platform-specific code in attach.dart.
    chingjun authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    8004212 View commit details
    Browse the repository at this point in the history
  5. Roll Flutter Engine from 5a824e22deb2 to 5dca50d3e268 (10 revisions) (#…

    …146524)
    
    flutter/engine@5a824e2...5dca50d
    
    2024-04-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete engine v1 android embedding (#51229)" (flutter/engine#51996)
    2024-04-09 [email protected] Delete engine v1 android embedding (flutter/engine#51229)
    2024-04-09 [email protected] better output from engine layer unit test failures (flutter/engine#51975)
    2024-04-09 [email protected] Revert "Roll Dart SDK from 78174b41ab0f to 7a5e410f982e (1 revision) (#51980)" (flutter/engine#51990)
    2024-04-09 [email protected] [skwasm] Reify the SkPicture pointer as the right type. (flutter/engine#51991)
    2024-04-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 7a5e410f982e to db99af14c4bc (1 revision) (#51986)" (flutter/engine#51989)
    2024-04-09 [email protected] Move the Dart SDK to //flutter/third_party/dart (flutter/engine#51917)
    2024-04-09 [email protected] [macOS] Implement hit testing and handle platform view cursor changes (flutter/engine#43101)
    2024-04-09 [email protected] Roll Dart SDK from 7a5e410f982e to db99af14c4bc (1 revision) (flutter/engine#51986)
    2024-04-09 [email protected] Roll Dart SDK from 78174b41ab0f to 7a5e410f982e (1 revision) (flutter/engine#51980)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    207e78e View commit details
    Browse the repository at this point in the history
  6. Fix InputDecorator label position ignore visual density (#146488)

    ## Description
    
    This PRs makes the label vertical position depend on visual density for filled text field.
    Previously, for M2 and M3, the label vertical offset was always the same (12 on M2, 8 and M3) despite different visual density configuration.
    This was noticable on desktop and can lead to weird rendering especially on M3 where line height makes the cursor taller.
    
    Screenshots for a filled text field:
    
    | | Before | After |
    |--------|--------|--------|
    |M3 macOs| ![image](https://github.com/flutter/flutter/assets/840911/bd9bdb6e-477c-4db0-ae8f-74e18d19f29e) | ![image](https://github.com/flutter/flutter/assets/840911/25e59c44-0139-4813-be28-472302d6970e) | 
    |M2 macOs| ![image](https://github.com/flutter/flutter/assets/840911/1c52493b-b17b-407b-93cc-69120207b716) | ![image](https://github.com/flutter/flutter/assets/840911/1fc4a8b6-429b-476c-b5bf-ff2934bf5293) | 
    
    </details> 
    
    ## Related Issue
    
    Fixes #141354
    
    ## Tests
    
    Adds 2 tests, updates 2 tests.
    bleroux authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    906ce36 View commit details
    Browse the repository at this point in the history
  7. Bump codecov/codecov-action from 4.2.0 to 4.3.0 (#146528)

    Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.2.0 to 4.3.0.
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p>
    <blockquote>
    <h2>v4.3.0</h2>
    <h2>What's Changed</h2>
    <ul>
    <li>fix: automatically detect if using GitHub enterprise by <a href="https://github.com/thomasrockhu-codecov"><code>@�thomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1356">codecov/codecov-action#1356</a></li>
    <li>build(deps-dev): bump typescript from 5.4.3 to 5.4.4 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1355">codecov/codecov-action#1355</a></li>
    <li>build(deps): bump github/codeql-action from 3.24.9 to 3.24.10 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1360">codecov/codecov-action#1360</a></li>
    <li>build(deps-dev): bump <code>@�typescript-eslint/eslint-plugin</code> from 7.5.0 to 7.6.0 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1364">codecov/codecov-action#1364</a></li>
    <li>build(deps-dev): bump <code>@�typescript-eslint/parser</code> from 7.5.0 to 7.6.0 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1363">codecov/codecov-action#1363</a></li>
    <li>feat: add network params by <a href="https://github.com/thomasrockhu-codecov"><code>@�thomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1365">codecov/codecov-action#1365</a></li>
    <li>build(deps): bump undici from 5.28.3 to 5.28.4 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1361">codecov/codecov-action#1361</a></li>
    <li>chore(release): v4.3.0 by <a href="https://github.com/thomasrockhu-codecov"><code>@�thomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1366">codecov/codecov-action#1366</a></li>
    </ul>
    <p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v4.2.0...v4.3.0">https://github.com/codecov/codecov-action/compare/v4.2.0...v4.3.0</a></p>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/codecov/codecov-action/commit/84508663e988701840491b86de86b666e8a86bed"><code>8450866</code></a> chore(release): v4.3.0 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1366">#1366</a>)</li>
    <li><a href="https://github.com/codecov/codecov-action/commit/e8419092e9de1e2493563107cf52bfa83d9ae62f"><code>e841909</code></a> build(deps): bump undici from 5.28.3 to 5.28.4 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1361">#1361</a>)</li>
    <li><a href="https://github.com/codecov/codecov-action/commit/363a65ad481c04303701b094b4d2c113a65f5d3e"><code>363a65a</code></a> feat: add network params (<a href="https://redirect.github.com/codecov/codecov-action/issues/1365">#1365</a>)</li>
    <li><a href="https://github.com/codecov/codecov-action/commit/640b86a455d2fd2f6e7acbb9eb863bc9f4a51954"><code>640b86a</code></a> build(deps-dev): bump <code>@�typescript-eslint/parser</code> from 7.5.0 to 7.6.0 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1363">#1363</a>)</li>
    <li><a href="https://github.com/codecov/codecov-action/commit/375c033fbe86348a044b3884012d849d84b90769"><code>375c033</code></a> build(deps-dev): bump <code>@�typescript-eslint/eslint-plugin</code> from 7.5.0 to 7.6.0 (#...</li>
    <li><a href="https://github.com/codecov/codecov-action/commit/d701256d7a115528200188787cd91ce87889775f"><code>d701256</code></a> build(deps): bump github/codeql-action from 3.24.9 to 3.24.10 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1360">#1360</a>)</li>
    <li><a href="https://github.com/codecov/codecov-action/commit/0bb547ab4974725a7d01e2ac18c843a6924c39f3"><code>0bb547a</code></a> build(deps-dev): bump typescript from 5.4.3 to 5.4.4 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1355">#1355</a>)</li>
    <li><a href="https://github.com/codecov/codecov-action/commit/55e8381a3e12db78da75715d4d60379adb17c4e6"><code>55e8381</code></a> fix: automatically detect if using GitHub enterprise (<a href="https://redirect.github.com/codecov/codecov-action/issues/1356">#1356</a>)</li>
    <li>See full diff in <a href="https://github.com/codecov/codecov-action/compare/7afa10ed9b269c561c2336fd862446844e0cbf71...84508663e988701840491b86de86b666e8a86bed">compare view</a></li>
    </ul>
    </details>
    <br />
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=4.2.0&new-version=4.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    </details>
    dependabot[bot] authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    237d885 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bba260a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    511ccf4 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Roll Flutter Engine from e4e274898efc to eaf73cd39cf8 (6 revisions) (#…

    …146538)
    
    flutter/engine@e4e2748...eaf73cd
    
    2024-04-09 [email protected] Update embedder example apps to run with the current engine tree (flutter/engine#51995)
    2024-04-09 [email protected] [Impeller] Refactor KHR swapchains to make it easy to reuse backend agnostic components. (flutter/engine#52002)
    2024-04-09 [email protected] Roll Skia from 74b0e26886f0 to 45eeeddb0074 (1 revision) (flutter/engine#52007)
    2024-04-09 [email protected] Try postsubmit_overrides for one mac build (flutter/engine#51676)
    2024-04-09 [email protected] [Impeller] Remove stencil clipping logic. (flutter/engine#51999)
    2024-04-09 [email protected] Roll Skia from a86861d21ae1 to 74b0e26886f0 (2 revisions) (flutter/engine#52000)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    74b65d4 View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from eaf73cd39cf8 to cee489a4e275 (2 revisions) (#…

    …146541)
    
    flutter/engine@eaf73cd...cee489a
    
    2024-04-10 [email protected] Roll Skia from 45eeeddb0074 to 3e3f28d64b2b (1 revision) (flutter/engine#52010)
    2024-04-09 [email protected] Roll Fuchsia Linux SDK from 82nvjI_UGVS8qYqyH... to imlnJ68ZziH-Lp2xk... (flutter/engine#52009)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from 82nvjI_UGVS8 to imlnJ68ZziH-
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    97cd47a View commit details
    Browse the repository at this point in the history
Loading