Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 477ebd831c12
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 98d23f709fec
Choose a head ref
  • 16 commits
  • 115 files changed
  • 6 contributors

Commits on Apr 5, 2024

  1. Configuration menu
    Copy the full SHA
    643848a View commit details
    Browse the repository at this point in the history
  2. Reland "Bump to AGP 8.1/Gradle 8.3 (almost) everywhere" (#146307)

    Relands #146181.
    
    Just 3 commits:
    1. a revert of the revert
    2. the fix described in #146181 (comment)
    3. updating two postsubmit tests from Java 11 to 17, as that is required for this new AGP version.
    
    I've verified that `flutter build apk --flavor paid --debug` fails in `dev/integration_tests/flavors/` with the error in ci without (2), and succeeds with it. 
    
    I've also verified that the `dev/benchmarks/complex_layout` app builds successfully with Java 17.
    
    That covers all the postsubmits that failed according [to the dashboard](https://flutter-dashboard.appspot.com/#/build).
    gmackall authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    22e0c89 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5466a89 View commit details
    Browse the repository at this point in the history
  4. Copy part files and sourcemaps when building with dart2js. (#146356)

    This fixes #145653
    
    When dart2js emits deferred part files, they need to be copied from the build folder to the output folder.
    eyebrowsoffire authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    75ae44d View commit details
    Browse the repository at this point in the history
  5. Roll Flutter Engine from 62df3bd5f681 to 6a478d6931b2 (3 revisions) (#…

    …146360)
    
    flutter/engine@62df3bd...6a478d6
    
    2024-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove #if SHELL_ENABLE_METAL checks in iOS code (#51636)" (flutter/engine#51941)
    2024-04-05 [email protected] Roll Fuchsia Linux SDK from TAr6MCirveGvhZFHK... to EaKtmpePocJx6qaKg... (flutter/engine#51940)
    2024-04-05 [email protected] Roll Skia from 6d673cafb8d1 to 0424e59d3a08 (1 revision) (flutter/engine#51939)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from TAr6MCirveGv to EaKtmpePocJx
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    101820b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    dfa3b1a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    37952e0 View commit details
    Browse the repository at this point in the history
  8. Bump github/codeql-action from 3.24.9 to 3.24.10 (#146368)

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.9 to 3.24.10.
    <details>
    <summary>Changelog</summary>
    <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
    <blockquote>
    <h1>CodeQL Action Changelog</h1>
    <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
    <p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
    <h2>[UNRELEASED]</h2>
    <p>No user facing changes.</p>
    <h2>3.24.10 - 05 Apr 2024</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.17.0. <a href="https://redirect.github.com/github/codeql-action/pull/2219">#2219</a></li>
    <li>Add a deprecation warning for customers using CodeQL version 2.12.5 and earlier. These versions of CodeQL were discontinued on 26 March 2024 alongside GitHub Enterprise Server 3.8, and will be unsupported by CodeQL Action versions 3.25.0 and later and versions 2.25.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/2220">#2220</a>
    <ul>
    <li>If you are using one of these versions, please update to CodeQL CLI version 2.12.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
    <li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.11.6 and 2.12.5, you can replace <code>github/codeql-action/*@V3</code> by <code>github/codeql-action/*@v3.24.10</code> and <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.24.10</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
    </ul>
    </li>
    </ul>
    <h2>3.24.9 - 22 Mar 2024</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.16.5. <a href="https://redirect.github.com/github/codeql-action/pull/2203">#2203</a></li>
    </ul>
    <h2>3.24.8 - 18 Mar 2024</h2>
    <ul>
    <li>Improve the ease of debugging extraction issues by increasing the verbosity of the extractor logs when running in debug mode. <a href="https://redirect.github.com/github/codeql-action/pull/2195">#2195</a></li>
    </ul>
    <h2>3.24.7 - 12 Mar 2024</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.16.4. <a href="https://redirect.github.com/github/codeql-action/pull/2185">#2185</a></li>
    </ul>
    <h2>3.24.6 - 29 Feb 2024</h2>
    <p>No user facing changes.</p>
    <h2>3.24.5 - 23 Feb 2024</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.16.3. <a href="https://redirect.github.com/github/codeql-action/pull/2156">#2156</a></li>
    </ul>
    <h2>3.24.4 - 21 Feb 2024</h2>
    <ul>
    <li>Fix an issue where an existing, but empty, <code>/sys/fs/cgroup/cpuset.cpus</code> file always resulted in a single-threaded run. <a href="https://redirect.github.com/github/codeql-action/pull/2151">#2151</a></li>
    </ul>
    <h2>3.24.3 - 15 Feb 2024</h2>
    <ul>
    <li>Fix an issue where the CodeQL Action would fail to load a configuration specified by the <code>config</code> input to the <code>init</code> Action. <a href="https://redirect.github.com/github/codeql-action/pull/2147">#2147</a></li>
    </ul>
    <h2>3.24.2 - 15 Feb 2024</h2>
    <ul>
    <li>Enable improved multi-threaded performance on larger runners for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/2141">#2141</a></li>
    </ul>
    <h2>3.24.1 - 13 Feb 2024</h2>
    </blockquote>
    <p>... (truncated)</p>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/github/codeql-action/commit/4355270be187e1b672a7a1c7c7bae5afdc1ab94a"><code>4355270</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2226">#2226</a> from github/update-v3.24.10-7df281f2f</li>
    <li><a href="https://github.com/github/codeql-action/commit/3f041c51a5d00e36a4ea25ed1c14d851d65db7cb"><code>3f041c5</code></a> Update changelog for v3.24.10</li>
    <li><a href="https://github.com/github/codeql-action/commit/7df281f2feac4aa04424a4fcca3efb7f7c9f681f"><code>7df281f</code></a> Gracefully continue if <code>createStatusReportBase</code> throws (<a href="https://redirect.github.com/github/codeql-action/issues/2225">#2225</a>)</li>
    <li><a href="https://github.com/github/codeql-action/commit/f421cda8e715cc7652d8b748f49574cf286aec12"><code>f421cda</code></a> Run integration test PR checks nightly (<a href="https://redirect.github.com/github/codeql-action/issues/2222">#2222</a>)</li>
    <li><a href="https://github.com/github/codeql-action/commit/5f535debfea657d84f956486f01539ccb5330f43"><code>5f535de</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2221">#2221</a> from github/nickfyson/upload-logging</li>
    <li><a href="https://github.com/github/codeql-action/commit/278465cdfb754d68191bff6702d925c85eeb2a55"><code>278465c</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2219">#2219</a> from github/update-bundle/codeql-bundle-v2.17.0</li>
    <li><a href="https://github.com/github/codeql-action/commit/65e69c8a4b476ce903dc9795a65db719486a0d92"><code>65e69c8</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.17.0</li>
    <li><a href="https://github.com/github/codeql-action/commit/c037115ddf761460364e7a6fddfe05adb9dfc4a6"><code>c037115</code></a> clarify logging in response to pr review comments</li>
    <li><a href="https://github.com/github/codeql-action/commit/d3c32a84cb5364893701e6664feb83986c420052"><code>d3c32a8</code></a> fix test to respect updated logging behaviour</li>
    <li><a href="https://github.com/github/codeql-action/commit/26540626a59343078de93e8aedf34b4ae8d876ef"><code>2654062</code></a> Merge branch 'main' into nickfyson/upload-logging</li>
    <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/1b1aada464948af03b950897e5eb522f92603cc2...4355270be187e1b672a7a1c7c7bae5afdc1ab94a">compare view</a></li>
    </ul>
    </details>
    <br />
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.24.9&new-version=3.24.10)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    </details>
    dependabot[bot] authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    86c8565 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4d1161b View commit details
    Browse the repository at this point in the history
  10. Make FileSystem dependency explicit througout. (#146008)

    This is part 8 of a broken down version of the #140101 refactor.
    
    This only makes one dependency explicit. Further PRs will do the same for other dependencies, until these APIs have no hidden dependencies.
    
    This particular change attempts to be minimal. A future change will apply some formatting cleanup (newlines, reordering parameters and arguments) for clarity.
    Hixie authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    3748b59 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. Configuration menu
    Copy the full SHA
    94db175 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3b6293a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e794dc8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7971b35 View commit details
    Browse the repository at this point in the history
  5. Roll Flutter Engine from 563bdb1d7976 to 605b3f35fa0a (1 revision) (#…

    …146393)
    
    flutter/engine@563bdb1...605b3f3
    
    2024-04-06 [email protected] Roll Fuchsia Linux SDK from EaKtmpePocJx6qaKg... to t4ixHpO8UiL4xDsOr... (flutter/engine#51955)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from EaKtmpePocJx to t4ixHpO8UiL4
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    2c038e6 View commit details
    Browse the repository at this point in the history
  6. Prepare for RenderDecorator.computeBaseline changes. (#146363)

    Minor changes to make the `RenderDecorator.computeBaseline` change a bit easier to make. No semantic changes.
    LongCatIsLooong authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    98d23f7 View commit details
    Browse the repository at this point in the history
Loading