-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: 46b097a3070d
head repository: flutter/flutter
compare: c3279caa127d
- 18 commits
- 69 files changed
- 18 contributors
Commits on Jul 29, 2025
-
Marks Linux_android_emu_unstable android_defines_test to be unflaky (#…
…171856) <!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Linux_android_emu_unstable android_defines_test" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android_emu_unstable%20android_defines_test%22). This test can be marked as unflaky. Co-authored-by: Ben Konyi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 915c7bc - Browse repository at this point
Copy the full SHA 915c7bcView commit details -
Fix Gemini Code Assist for GitHub config yaml (#172887)
Gemini Code Assist for GitHub config seems incorrect, though the comment doesn't tell us what's wrong. #172886 (comment) <img width="814" height="111" alt="Screenshot 2025-07-28 at 4 45 41 PM" src="https://github.com/user-attachments/assets/6763a74b-3b14-4ef0-8234-4eaa70a72358" /> Speculating the yaml doesn't like the `**`. Introduced in #172785 --------- Co-authored-by: John "codefu" McDole <[email protected]> Co-authored-by: Parker Lougheed <[email protected]> Co-authored-by: John "codefu" McDole <[email protected]>
1Configuration menu - View commit details
-
Copy full SHA for 30ae030 - Browse repository at this point
Copy the full SHA 30ae030View commit details -
Reverts "Reland licenses cpp switch (#172671)" (#172912)
<!-- start_original_pr_link --> Reverts: #172671 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: gaaclarke <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: integration problems with google roller <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: gaaclarke <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {matanlurey, jtmcdole} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: changes since last land: 1) Now the license checker can trim matched licenses to remove regions that aren't apropos 1) There is a `.autoroller-preupload.sh` script that should update the LICENSE file when the autoroller executes relies on: - #172655 - https://skia-review.googlesource.com/c/buildbot/+/1025936 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b5b5897 - Browse repository at this point
Copy the full SHA b5b5897View commit details -
Made
android_gradle_print_build_variants_test.dartmore robust (#17……2910) issue: #172908 It's uncertain if this will fix the issue since we don't know why the old matcher failed. This may fix it, or it may just give us more information to debug with. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for ea378cf - Browse repository at this point
Copy the full SHA ea378cfView commit details -
Roll Skia from 409e1c7ba09b to a42898e5d622 (29 revisions) (#172906)
manual land of #172881 https://skia.googlesource.com/skia.git/+log/409e1c7ba09b..a42898e5d622 2025-07-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2025-07-28 [email protected] Revert "[graphite] Add option to avoid clear load op conversion" 2025-07-28 [email protected] Defer drawOval to SkDraw 2025-07-28 [email protected] Factor out rrect deducer, so it can be used outside of pathref 2025-07-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2025-07-28 [email protected] Refactor IsRectContour for other clients 2025-07-28 [email protected] Share code from PathRawShapes 2025-07-28 [email protected] [Fontations] Roll Fontations 2025-07-28 [email protected] [graphite] Fix thread race in Dawn backend 2025-07-28 [email protected] Roll vulkan-deps from dfe81c21c267 to aef5b0045b59 (1 revision) 2025-07-28 [email protected] Roll ANGLE from d38531e82fd8 to c8209fec9a5f (6 revisions) 2025-07-28 [email protected] Roll SwiftShader from a84d1801cf7b to 8802b4ec130b (1 revision) 2025-07-28 [email protected] Roll Skia Infra from 8aa65434c8ed to 4695e6b7d184 (7 revisions) 2025-07-28 [email protected] Roll Dawn from 3d2423f23524 to 2fa5446206bd (15 revisions) 2025-07-27 [email protected] Update SKP version 2025-07-27 [email protected] Roll vulkan-deps from 1e5f8fd67984 to dfe81c21c267 (1 revision) 2025-07-26 [email protected] Roll vulkan-deps from f4b5d4a14233 to 1e5f8fd67984 (1 revision) 2025-07-26 [email protected] Roll vulkan-deps from 75a29db5e706 to f4b5d4a14233 (3 revisions) 2025-07-25 [email protected] HDR v2: Make more paths robust to new version 2025-07-25 [email protected] [graphite] Fix bug(s) in PipelineKey serialization 2025-07-25 [email protected] Roll vulkan-deps from b16be89ea18d to 75a29db5e706 (3 revisions) 2025-07-25 [email protected] Reapply "Add defaults for path enums, declare as 8-bit" 2025-07-25 [email protected] Update Matrix PolyToPoly to take spans 2025-07-25 [email protected] Stick to 1/2 scale for final blur decimation step 2025-07-25 [email protected] Remove old docker images related to fiddler 2025-07-25 [email protected] skscan to take pathraw 2025-07-25 [email protected] Roll ANGLE from f94510ab8d9e to d38531e82fd8 (13 revisions) 2025-07-25 [email protected] Roll Skia Infra from 2fdfa81e82dc to 8aa65434c8ed (8 revisions) 2025-07-25 [email protected] Roll Dawn from b6b32cb6d1a1 to 3d2423f23524 (14 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Co-authored-by: engine-flutter-autoroll <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9632181 - Browse repository at this point
Copy the full SHA 9632181View commit details -
Add package PR triage note (#172898)
Add an explanation of the flutter/packages platform PR triage system, as it isn't documented anywhere.
Configuration menu - View commit details
-
Copy full SHA for 2329a6c - Browse repository at this point
Copy the full SHA 2329a6cView commit details -
Roll Packages from 6b2e34e to ed235d1 (4 revisions) (#172905)
flutter/packages@6b2e34e...ed235d1 2025-07-29 [email protected] Roll Flutter from cfbaa18 to 46b097a (12 revisions) (flutter/packages#9695) 2025-07-29 [email protected] [camera_avfoundation] Implementation swift migration - part 10 (flutter/packages#9664) 2025-07-29 [email protected] [interactive_media_ads] Adds remaining methods for internal wrapper of the native `AdsRequest` (flutter/packages#9663) 2025-07-28 [email protected] [camera_android_camerax] Delete unused file (flutter/packages#9634) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 26917f5 - Browse repository at this point
Copy the full SHA 26917f5View commit details -
Refactor Android platform view code in advance of enabling HCPP on ex…
…isting PV widgets (behind a flag) (#170553) Should introduce no behavior changes. Refactors the android platform view code so that 1. The delegator is ready to delegate between PlatformViewsController (PVC) 1 and 2, and implements a `PlatformViewsChannel.PlatformViewsHandler`. 2. The `PlatformViewCreationRequest` and `PlatformViewTouch` are fully shared between the two platform view modes 3. Introduces new factory constructors for the different types of `PlatformViewCreationRequest`s, corresponding to the modes. Making the flag work on existing widgets will be done in a follow up PR here https://github.com/flutter/flutter/blob/67262d924051ee03dd4539926752c1170da4271f/engine/src/flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformViewsChannel.java#L95. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <[email protected]> Co-authored-by: Reid Baker <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5f9b9ab - Browse repository at this point
Copy the full SHA 5f9b9abView commit details -
fix(scrollbar): Update padding type to EdgeInsetsGeometry (#172056)
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> This PR enhances RTL support for the RawScrollbar widget by updating its padding type and adding comprehensive tests. The changes include: 1. Updating RawScrollbar's `padding` parameter from `EdgeInsets` to `EdgeInsetsGeometry` - This change is non-breaking because `EdgeInsets` is a subclass of `EdgeInsetsGeometry` - Existing code using `EdgeInsets` will continue to work as before - Users can now optionally use `EdgeInsetsDirectional` for RTL support 2. Adding a test case that verifies scrollbar positioning with EdgeInsetsDirectional padding 3. Testing both overscroll and regular scroll scenarios with directional padding These changes ensure that the scrollbar works correctly in both LTR and RTL layouts, improving accessibility and internationalization support. Fixes: #167922 ## Pre-launch Checklist - [x] I read the [Contributor Guide](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview) and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md) wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide](https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md), including [Features we expect every widget to implement](https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement). - [x] I signed the [CLA](https://cla.developers.google.com/). - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord](https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md). <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for a5934ee - Browse repository at this point
Copy the full SHA a5934eeView commit details -
Roll Fuchsia Linux SDK from tK_PAaLeo0pUxi8hv... to bQVQlLssTxxLjoDU0…
…... (#172925) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 4a798c0 - Browse repository at this point
Copy the full SHA 4a798c0View commit details -
Fix documentation for FlutterEngineRunTask (#172889)
The engine provides the tasks to the embedder, which then runs them using FlutterEngineRunTask. The existing docs suggest the tasks are given to the engine (i.e. are sourced in the embedder).
Configuration menu - View commit details
-
Copy full SHA for 636b3c7 - Browse repository at this point
Copy the full SHA 636b3c7View commit details -
Fix SegmentedButton border doesn't reflect states (#172754)
## Description This PR fixes `SegmentedButton` border side not depending on the current state. It's based on one @TahaTesser 's great PR: see #161942. 🙏 I updated some logic related to disabled border which led to Taha’s PR failing internal Google tests. I also added a test to verify the disabled border. <details><summary>Code sample for screenshots</summary> ```dart import 'package:flutter/material.dart'; void main() { runApp(const SegmentedButtonApp()); } enum Calendar { day, week, month, year } class SegmentedButtonApp extends StatefulWidget { const SegmentedButtonApp({super.key}); @OverRide State<SegmentedButtonApp> createState() => _SegmentedButtonAppState(); } class _SegmentedButtonAppState extends State<SegmentedButtonApp> { Calendar? calendarView; @OverRide Widget build(BuildContext context) { return MaterialApp( theme: ThemeData( segmentedButtonTheme: SegmentedButtonThemeData( style: ButtonStyle( side: WidgetStateProperty.fromMap(<WidgetStatesConstraint, BorderSide?>{ WidgetState.disabled: const BorderSide(color: Colors.grey, width: 2), WidgetState.selected & WidgetState.hovered: const BorderSide( color: Colors.blue, width: 2, ), WidgetState.selected & WidgetState.focused: const BorderSide( color: Colors.pinkAccent, width: 2, ), WidgetState.hovered: const BorderSide(color: Colors.green, width: 2), WidgetState.focused: const BorderSide(color: Colors.purple, width: 2), WidgetState.any: const BorderSide(color: Colors.amber, width: 2), }), ), ), ), home: Scaffold( body: Center( child: SegmentedButton<Calendar>( segments: const <ButtonSegment<Calendar>>[ ButtonSegment<Calendar>( value: Calendar.day, label: Text('Day'), icon: Icon(Icons.calendar_view_day), enabled: false, ), ButtonSegment<Calendar>( value: Calendar.week, label: Text('Week'), icon: Icon(Icons.calendar_view_week), ), ButtonSegment<Calendar>( value: Calendar.month, label: Text('Month'), icon: Icon(Icons.calendar_view_month), ), ButtonSegment<Calendar>( value: Calendar.year, label: Text('Year'), icon: Icon(Icons.calendar_today), ), ], selected: <Calendar>{?calendarView}, emptySelectionAllowed: true, onSelectionChanged: (Set<Calendar> newSelection) { setState(() { calendarView = newSelection.isEmpty ? null : newSelection.first; }); }, ), ), floatingActionButton: FloatingActionButton(onPressed: () {}, child: const Icon(Icons.add)), ), ); } } ``` </details> # Before https://github.com/user-attachments/assets/1581f431-f87a-4af3-8ef6-f1f0d170e54a # After https://github.com/user-attachments/assets/156a8a64-3d9f-4323-9a1d-60624f5ac5d4 ## Related Issue Fixes [SegmentedButton does not set its MaterialState for side ](#159884) ## Tests Adds 2 tests.
Configuration menu - View commit details
-
Copy full SHA for c825031 - Browse repository at this point
Copy the full SHA c825031View commit details
Commits on Jul 30, 2025
-
Roll Skia from a42898e5d622 to f72bd01a49b1 (21 revisions) (#172944)
https://skia.googlesource.com/skia.git/+log/a42898e5d622..f72bd01a49b1 2025-07-30 [email protected] Revert "[graphite] Add AHARDWAREBUFFER_FORMAT_B8G8R8A8_UNORM support" 2025-07-29 [email protected] Roll vulkan-deps from 03166deacb9d to c98f4a016f37 (6 revisions) 2025-07-29 [email protected] [graphite] Preserve rounded corners for stroke bounds in ClipStack 2025-07-29 [email protected] Fix RustPNG build 2025-07-29 [email protected] Update -base versions of shaders/skottie/fiddler/debugger 2025-07-29 [email protected] [graphite] Optimize drawDRRect and nested rect contours 2025-07-29 [email protected] [graphite] Add AHARDWAREBUFFER_FORMAT_B8G8R8A8_UNORM support 2025-07-29 [email protected] Remove unused SkTypeface_AndroidSystem::fAxes 2025-07-29 [email protected] [videodecoder] Forward-declare GrRecordingContext 2025-07-29 [email protected] Update pinned jsfiddle-base 2025-07-29 [email protected] Add RRect to raw-shapes 2025-07-29 [email protected] Use optional for PathRef queries 2025-07-29 [email protected] Fix cusp detection for linear cubics in FindCubicConvex180Chops 2025-07-29 [email protected] Temporarily remove RustPNG from CQ 2025-07-29 [email protected] Roll vulkan-deps from aef5b0045b59 to 03166deacb9d (8 revisions) 2025-07-29 [email protected] Roll Dawn from 2fa5446206bd to fcda4f3d4b8c (12 revisions) 2025-07-29 [email protected] Roll SwiftShader from 8802b4ec130b to 4bd5bd8d51e4 (1 revision) 2025-07-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2025-07-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2025-07-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2025-07-28 [email protected] identify_transfer_fn: Return C string for PQ and HLG If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 1cf0494 - Browse repository at this point
Copy the full SHA 1cf0494View commit details -
[a11y] add RangeSlider to a11y test app as additional use-case (#172922)
Add `RangeSlider` as an additional use-case to the a11y_assessments app. As part of that this PR adds a `Switch` to the app bar of the app to reveal the additional use-cases. Each use-case is annotated to be either a `core` or `additional` using a new `enum`, which is also introduced in this PR.
Configuration menu - View commit details
-
Copy full SHA for 2c5957a - Browse repository at this point
Copy the full SHA 2c5957aView commit details -
Roll Skia from f72bd01a49b1 to 34693354289f (1 revision) (#172946)
https://skia.googlesource.com/skia.git/+log/f72bd01a49b1..34693354289f 2025-07-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for c372faa - Browse repository at this point
Copy the full SHA c372faaView commit details -
Roll Skia from 34693354289f to 62476cd444d2 (1 revision) (#172950)
https://skia.googlesource.com/skia.git/+log/34693354289f..62476cd444d2 2025-07-30 [email protected] Roll Dawn from fcda4f3d4b8c to 87ae884a3c56 (19 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 1ffcede - Browse repository at this point
Copy the full SHA 1ffcedeView commit details -
Roll Skia from 62476cd444d2 to 00765f238077 (3 revisions) (#172955)
https://skia.googlesource.com/skia.git/+log/62476cd444d2..00765f238077 2025-07-30 [email protected] Roll ANGLE from c8209fec9a5f to e286ef784996 (19 revisions) 2025-07-30 [email protected] Roll SwiftShader from 4bd5bd8d51e4 to 7cd1022cdc50 (1 revision) 2025-07-30 [email protected] Roll Skia Infra from 4695e6b7d184 to baf909de57f0 (14 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for c9b1fa8 - Browse repository at this point
Copy the full SHA c9b1fa8View commit details -
Roll Skia from 00765f238077 to da5a6704f8a3 (1 revision) (#172966)
https://skia.googlesource.com/skia.git/+log/00765f238077..da5a6704f8a3 2025-07-30 [email protected] Roll vulkan-deps from c98f4a016f37 to b64ff232d6ed (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for c3279ca - Browse repository at this point
Copy the full SHA c3279caView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 46b097a3070d...c3279caa127d