Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 45ef8f36ff41
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2e221e7308ba
Choose a head ref
  • 20 commits
  • 38 files changed
  • 16 contributors

Commits on Sep 5, 2024

  1. Configuration menu
    Copy the full SHA
    a3301ce View commit details
    Browse the repository at this point in the history
  2. Fix ZoomPageTransitionsBuilder hardcoded fill color (#154057)

    Fixes: #115275
    Fixes: #116127
    Fixes: #126682
    
    Continuing on: #139078 (Credits to @LowLevelSubmarine for his initial
    work!)
    
    When using `ZoomPageTransitionsBuilder`, which is the default for
    `ThemeData` with a `MaterialApp`, dark edges would show around the
    exiting page that was being zoomed out in the background. Other times, a
    scrim (what looked like a slightly transparent dark overlay over the
    page) would appear.
    
    After some experimenting it was concluded that, in the first case, this
    was because both pages don't fully fill the enclosing scaffold area
    during the transition and the color for filling the remaining space was
    set hard coded as `Colors.black`. The second case (scrim) happens when
    navigating from a page with an enclosing scaffold to a nested one,
    without a scaffold, unlike the first case that happens when both pages
    have a (different) enclosing scaffold, except this time it would be the
    hard coded color covering the page with a slight opacity reduction.
    
    ### Changes
    
    - Replaced the hard coded color for transition filling with the current
    `ThemeData.colorScheme.surface`
    
    - Added a RenderBox based test to verify the correct color is being used
    in the transition.
    
    ## Preview
    
    **Before, notice the dark outline flash when navigating to the first
    page and the scrim when navigating to the second:**
    
    
    https://github.com/user-attachments/assets/b4cc8658-1008-49f4-8553-abd5fcc72989
    
    **After, using the theme relative color (in this case the default white)
    to replace the hard coded value:**
    
    
    https://github.com/user-attachments/assets/b70f42d2-6246-4964-99d1-34ff8051ab06
    
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation.
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    dy0gu authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    834566f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fea5d1e View commit details
    Browse the repository at this point in the history
  4. Fix DropdownMenu menu does not follow the text field (#154667)

    ## Description
    
    This PR fixes the `DropdownMenu` menu position when the keyboard appear on mobile device.
    
    ## Related Issue
    
    Fixes #149037.
    
    ## Tests
    
    Adds 2 tests.
    bleroux authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    2b8072e View commit details
    Browse the repository at this point in the history
  5. Add proguard rule to keep the class for all implementations of Flutte…

    …rPlugin (#154677)
    
    Fixes #154580, for the time being. 
    
    We should follow up to determine why this is necessary, but I think it is important to un-break these specific plugins for now.
    gmackall authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a621b8a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6dc8820 View commit details
    Browse the repository at this point in the history
  7. iOS,macOS: Do not copy unsigned_binaries.txt to build outputs (#154684)

    There are three categories of binaries produced as part of the framework artifacts:
    * Those that use APIs that require entitlements and must be code-signed; e.g. gen_snapshot
    * Those that do not use APIs that require entitlements and must be code-signed; e.g. Flutter.framework dylib.
    * Those that do not need to be code-signed; e.g. Flutter.dSYM symbols.
    
    We are adding the third category in flutter/engine#54977. The Cocoon code signing aspect of this was handled in flutter/cocoon#3890.
    
    This ensures these files don't get copied into the build output should they appear in the artifact cache.
    
    Issue: #154571
    cbracken authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    4d17998 View commit details
    Browse the repository at this point in the history
  8. Normalize Dialog theme (#153982)

    This PR is to make preparations to make `DialogTheme` conform to Flutter's conventions for component themes:
    
    * Added a `DialogThemeData` class which defines overrides for the defaults for `Dialog` properties.
    * Added 2 `DialogTheme` constructor parameters: `DialogThemeData? data` and `Widget? child`. This is now the preferred way to configure a `DialogTheme`:
    ```
    DialogTheme(
      data: DialogThemeData(color: xxx, elevation: xxx, ...),
      child: Dialog(...)
    )
    ```
      These two properties are made nullable to not break existing apps which has customized `ThemeData.dialogTheme`.
    
    * Changed the type of theme defaults from `DialogTheme` to `DialogThemeData`.
    
    TODO:
    
    * Fix internal failures.
    * Change the type of `ThemeData.dialogTheme` from `DialogTheme` to `DialogThemeData`. This may cause breaking changes, a migration guide will be created.
    
    Addresses the "theme normalization" sub project within #91772
    QuncCccccc authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6dd929a View commit details
    Browse the repository at this point in the history
  9. Bump peter-evans/create-pull-request from 7.0.0 to 7.0.1 (#154690)

    Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.0 to 7.0.1.
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a href="https://github.com/peter-evans/create-pull-request/releases">peter-evans/create-pull-request's releases</a>.</em></p>
    <blockquote>
    <h2>Create Pull Request v7.0.1</h2>
    <p>�� Fixes <a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3311">an issue</a> affecting one particular use case where the action fails on <code>diff --stat</code> with <code>fatal: ambiguous argument</code>.</p>
    <h2>What's Changed</h2>
    <ul>
    <li>build(deps): bump peter-evans/create-pull-request from 6 to 7 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3283">peter-evans/create-pull-request#3283</a></li>
    <li>build(deps-dev): bump <code>@�types/node</code> from 18.19.46 to 18.19.48 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3288">peter-evans/create-pull-request#3288</a></li>
    <li>build(deps-dev): bump <code>@�typescript-eslint/parser</code> from 7.17.0 to 7.18.0 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3289">peter-evans/create-pull-request#3289</a></li>
    <li>build(deps-dev): bump eslint-plugin-import from 2.29.1 to 2.30.0 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3290">peter-evans/create-pull-request#3290</a></li>
    <li>build(deps-dev): bump <code>@�typescript-eslint/eslint-plugin</code> from 7.17.0 to 7.18.0 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3291">peter-evans/create-pull-request#3291</a></li>
    <li>fix: handle ambiguous argument failure on diff stat by <a href="https://github.com/peter-evans"><code>@�peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3312">peter-evans/create-pull-request#3312</a></li>
    </ul>
    <p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v7.0.0...v7.0.1">https://github.com/peter-evans/create-pull-request/compare/v7.0.0...v7.0.1</a></p>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/peter-evans/create-pull-request/commit/8867c4aba1b742c39f8d0ba35429c2dfa4b6cb20"><code>8867c4a</code></a> fix: handle ambiguous argument failure on diff stat (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3312">#3312</a>)</li>
    <li><a href="https://github.com/peter-evans/create-pull-request/commit/6073f5434ba635ff2f4390cddac0059ab04d9409"><code>6073f54</code></a> build(deps-dev): bump <code>@�typescript-eslint/eslint-plugin</code> (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3291">#3291</a>)</li>
    <li><a href="https://github.com/peter-evans/create-pull-request/commit/6d01b5601c7aca7ad0eb2f8532106269ac38b584"><code>6d01b56</code></a> build(deps-dev): bump eslint-plugin-import from 2.29.1 to 2.30.0 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3290">#3290</a>)</li>
    <li><a href="https://github.com/peter-evans/create-pull-request/commit/25cf8451c34bbbcbb3ef973b252eb91ec1ad8be9"><code>25cf845</code></a> build(deps-dev): bump <code>@�typescript-eslint/parser</code> from 7.17.0 to 7.18.0 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3289">#3289</a>)</li>
    <li><a href="https://github.com/peter-evans/create-pull-request/commit/d87b980a0ebf44e8ed8ef733b28171c81ca501af"><code>d87b980</code></a> build(deps-dev): bump <code>@�types/node</code> from 18.19.46 to 18.19.48 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3288">#3288</a>)</li>
    <li><a href="https://github.com/peter-evans/create-pull-request/commit/119d131ea9fd0db1802246d0098211de13a26406"><code>119d131</code></a> build(deps): bump peter-evans/create-pull-request from 6 to 7 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3283">#3283</a>)</li>
    <li><a href="https://github.com/peter-evans/create-pull-request/commit/73e6230af4af8faaeddac4d3f16e25f8a2bd8e4b"><code>73e6230</code></a> docs: update readme</li>
    <li><a href="https://github.com/peter-evans/create-pull-request/commit/c0348e860fc89e6cc1f5b623f7b1140d6ee9a2d5"><code>c0348e8</code></a> ci: add v7 to workflow</li>
    <li>See full diff in <a href="https://github.com/peter-evans/create-pull-request/compare/4320041ed380b20e97d388d56a7fb4f9b8c20e79...8867c4aba1b742c39f8d0ba35429c2dfa4b6cb20">compare view</a></li>
    </ul>
    </details>
    <br />
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=peter-evans/create-pull-request&package-manager=github_actions&previous-version=7.0.0&new-version=7.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    </details>
    dependabot[bot] authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    57faab2 View commit details
    Browse the repository at this point in the history
  10. Roll Flutter Engine from c50eb8a65097 to 015f3b1dec53 (2 revisions) (#…

    …154691)
    
    flutter/engine@c50eb8a...015f3b1
    
    2024-09-05 [email protected] [engine] always force platform channel responses to schedule a task. (flutter/engine#54975)
    2024-09-05 [email protected] Fix unexpected ViewFocus events when Text Editing utilities change focus in the middle of a blur call. (flutter/engine#54965)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b0ed1cb View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9e99675 View commit details
    Browse the repository at this point in the history
  12. Improve iOS unpack target's error messages (#154649)

    Improves the formatting and error messages of the target that unpacks the Flutter framework in Flutter iOS builds.
    
    Follow up to: #154645
    Part of #151567
    loic-sharma authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    aea8434 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Reverts "Roll Flutter Engine from c50eb8a65097 to 015f3b1dec53 (2 rev…

    …isions) (#154691)" (#154726)
    
    Reverts: #154691
    Initiated by: jtmcdole
    Reason for reverting: breaking flutter-dashboard
    Original PR Author: engine-flutter-autoroll
    
    Reviewed By: {fluttergithubbot}
    
    This change reverts the following previous change:
    
    flutter/engine@c50eb8a...015f3b1
    
    2024-09-05 [email protected] [engine] always force platform channel responses to schedule a task. (flutter/engine#54975)
    2024-09-05 [email protected] Fix unexpected ViewFocus events when Text Editing utilities change focus in the middle of a blur call. (flutter/engine#54965)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    auto-submit[bot] authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3d53d1a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c6b0876 View commit details
    Browse the repository at this point in the history
  3. Roll Packages from 71e827e to 56df73e (1 revision) (#154725)

    flutter/packages@71e827e...56df73e
    
    2024-09-06 [email protected] [extension_google_sign_in_as_googleapis_auth][google_maps_flutter_ios] Manual roll with fixes to example and skipping some native tests (flutter/packages#7571)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c56ab6b View commit details
    Browse the repository at this point in the history
  4. Improve CupertinoPopupSurface appearance (#151430)

    This PR makes the CupertinoPopupSurface more vibrant. Also, the gaussian kernel was switched to 30 from 20 based on  comparisons. 
    
    @dkwingsmt - Looking forward to your dialog and fixes!
    
    After is on bottom:
    <img width="939" alt="image" src="https://github.com/flutter/flutter/assets/59215665/bd020c9b-af87-4342-9a9f-c9f8f7693456">
    
    Notably, because the borders are very transparent, the new version looks more colorful in the sample screencap than it actually is. As such, focus on the individual colors to get a feel for the change.
    
    | actual | old | new
    |--|--|--|
    | <img width="30" alt="image" src="https://github.com/flutter/flutter/assets/59215665/7de2801d-a2cc-44a4-a660-2692889fed63"> | <img width="28" alt="image" src="https://github.com/flutter/flutter/assets/59215665/48689d82-af15-4612-b4ab-75d584e9b094"> | <img width="30" alt="image" src="https://github.com/flutter/flutter/assets/59215665/7c1075ec-b815-47e0-b822-65a2b63497a0"> |
    | <img width="24" alt="image" src="https://github.com/flutter/flutter/assets/59215665/2eeefe25-2e1d-4a79-b748-4925d950b9a2"> | <img width="26" alt="image" src="https://github.com/flutter/flutter/assets/59215665/68a2694c-d943-4563-9b5e-9e86e2ee1d58"> | <img width="28" alt="image" src="https://github.com/flutter/flutter/assets/59215665/1932b90a-1719-40f5-828e-41ceafd59e26"> |
    <img width="22" alt="image" src="https://github.com/flutter/flutter/assets/59215665/0bd22c64-dd37-4262-a7e8-ed610151ab7a"> |  <img width="28" alt="image" src="https://github.com/flutter/flutter/assets/59215665/e1738bd2-98d2-491b-9a4a-d2c7cbc5a080"> | <img width="25" alt="image" src="https://github.com/flutter/flutter/assets/59215665/c245d786-19aa-4a14-8df3-029591d1debd"> |
    
    Partially addresses #29483
    
    This will need tests, which I will add once I know which tests break due to this commit.
    
    Blockers: 
    * #152026
    davidhicks980 authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    35b0349 View commit details
    Browse the repository at this point in the history
  5. [Conductor] Add ability to override mirror, add tests for default arg…

    … parsing and custom arg parsing (#154363)
    
    fixes #154342
    reidbaker authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9d9ec70 View commit details
    Browse the repository at this point in the history
  6. [tool] Add dartFileName setting for platform plugins (#153099)

    This PR introduces the `dartFileName` parameter for platform plugin configurations with Dart platform implementations. This new parameter allows plugin developers to specify a custom path to the file where the `dartPluginClass` is defined.
    
    **Implementation is opt-in**. `dartFileName` is completely optional and is taken in account only with `dartClassName`. Possibility to set `dartClassName` without `dartFileName` remains. 
    
    **Implementation is backward compatible** � existing configurations using only `dartClassName` remain fully supported. If `dartFileName` is omitted, the system falls back to the previous behavior of deriving the file name from the plugin name.
    
    ## Example
    
    ```yaml
    flutter:
      plugin:
        platforms:
          some_platform:
            dartPluginClass: MyPlugin
            dartFileName: 'src/my_plugin_implementation.dart'
    ```
    
    fixes #152833
    Sameri11 authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d932115 View commit details
    Browse the repository at this point in the history
  7. Support custom transition duration for DialogRoute, `CupertinoDialo…

    …gRoute` and show dialog methods. (#154048)
    
    Currently we don't support custom transition duration for `DialogRoute`, `CupertinoDialogRoute` and show dialog methods , This PR will to support that.
    nploi authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0eaeb0d View commit details
    Browse the repository at this point in the history
  8. Fix DropdownMenu focused item styles (#153159)

    ## Description
    
    This PR fixes the style resolution for selected dropdown menu items (make it possible to provide a custom style and avoid hardcoded values when possible).
    
    For the moment, I kept the default selected background which was previously set (`onSurface.withOpacity(0.12)`) to keep this PR focused on its goal which is to make it possible to overrides the defaults item style by providing a custom button style at the theme level or at the menu entry level.
    
    ## Related Issue
    
    Fixes #123736.
    
    ## Tests
    
    Adds 4 tests.
    bleroux authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    2e221e7 View commit details
    Browse the repository at this point in the history
Loading