Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3df163ff081e
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 353b8bc87d29
Choose a head ref
  • 10 commits
  • 20 files changed
  • 4 contributors

Commits on Jun 11, 2023

  1. Configuration menu
    Copy the full SHA
    d2c1cf8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    08e595c View commit details
    Browse the repository at this point in the history
  3. Roll Flutter Engine from 5da44b9aafdd to 788437e41ee0 (2 revisions) (#…

    …128672)
    
    flutter/engine@5da44b9...788437e
    
    2023-06-11 [email protected] Roll Dart SDK from 46f3e816d30d to 0c4f3ae7464c (1 revision) (flutter/engine#42745)
    2023-06-11 [email protected] Roll Fuchsia Mac SDK from E7gwQ9L15jziMUKha... to UxuMYdEq-rI5WqUKJ... (flutter/engine#42744)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/mac-amd64 from E7gwQ9L15jzi to UxuMYdEq-rI5
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jun 11, 2023
    Configuration menu
    Copy the full SHA
    1fccad1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2b1f882 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Configuration menu
    Copy the full SHA
    4f94dee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f2118b View commit details
    Browse the repository at this point in the history
  3. Update ListTile text defaults to use ColorScheme (#128581)

    fixes #128569
    
    <details> 
    <summary>code sample</summary> 
    
    ```dart
    import 'package:flutter/material.dart';
    
    void main() {
      runApp(const ListTileApp());
    }
    
    class ListTileApp extends StatelessWidget {
      const ListTileApp({super.key});
    
      @OverRide
      Widget build(BuildContext context) {
        return MaterialApp(
          title: 'Flutter Demo',
          theme: ThemeData(
            useMaterial3: true,
            colorScheme: ColorScheme.fromSeed(seedColor: Colors.red).copyWith(
              onSurface: Colors.yellow,
              onSurfaceVariant: Colors.green,
            ),
          ),
          home: const Scaffold(
            body: Center(
              child: ListTile(
                title: Text('title'),
                subtitle: Text('subtitle'),
              ),
            ),
          ),
        );
      }
    }
    
    ``` 
    	
    </details>
    
    # Description
    M3 ListTile couldn't be customized using `ColorScheme` colors. 
    
    - This PR updates the list tile text defaults to `ColorScheme` text color tokens.
    - Improved the `ListTile` template to use the token group.
    - Update docs and tests.
    
    ```dart
            colorScheme: ColorScheme.fromSeed(seedColor: Colors.red).copyWith(
              onSurface: Colors.yellow,
              onSurfaceVariant: Colors.green,
            ),
    ```
    
    ### Before
    
    ![Screenshot 2023-06-09 at 17 47 04](https://github.com/flutter/flutter/assets/48603081/c0130371-3c7c-428c-bb57-504822cf64b5)
    
    ### After
    
    ![Screenshot 2023-06-09 at 17 46 17](https://github.com/flutter/flutter/assets/48603081/3b4d6f8c-7fdd-4546-a6f0-00dd34cb5a96)
    TahaTesser authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    ca5aa23 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    05d1cde View commit details
    Browse the repository at this point in the history
  5. Fix RangeSlider notifies start and end twice when participates in ges…

    …ture arena (#128674)
    
    Fixes #128433
    
    This PR applies the same fix as we did for Slider #82152
    nt4f04uNd authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    ad8c997 View commit details
    Browse the repository at this point in the history
  6. Roll Packages from afe2f05 to c9865e8 (6 revisions) (#128701)

    flutter/packages@afe2f05...c9865e8
    
    2023-06-11 [email protected] Roll Flutter from da127f1 to 3df163f (25 revisions) (flutter/packages#4183)
    2023-06-10 [email protected] [image_picker] Add desktop support (flutter/packages#3882)
    2023-06-09 [email protected] [image_picker] getMedia platform changes (flutter/packages#4174)
    2023-06-09 [email protected] [image_picker] Add desktop support - implementations (flutter/packages#4172)
    2023-06-09 [email protected] Roll Flutter from 6e254a3 to da127f1 (28 revisions) (flutter/packages#4170)
    2023-06-09 [email protected] [go_router_builder] Include required and positional query parameters in the location (flutter/packages#4163)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    353b8bc View commit details
    Browse the repository at this point in the history
Loading