Comparing changes

…oller instances. (#136608)" (#144579) This reverts commit 9fa9fd3. Fixes #144087. Fixes #138588. This crash has been reported previously from a customer in google3 in #138588, but we weren't able to track it down. Thankfully, a repro was now provided in #144087 (comment) which traced the crash down to a change made in #136608. This PR reverts that change to fix that crash for now. I will post a new PR shortly that will add a test to cover the use case that caused the crash with #136608 to make sure we don't re-introduce the crash in the future.

…144624) flutter/engine@8916bb3...a7c7858 2024-03-05 [email protected] Roll Skia from 10058142c8a2 to de108a9c8b54 (4 revisions) (flutter/engine#51199) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

The title says it all. This parameter is unused and serves no apparent purpose.

flutter/packages@0625827...2aa6e3f 2024-03-05 [email protected] [in_app_purchase_storekit] Fix type of error code returned from native code in `SKReceiptManager.retrieveReceiptData` (flutter/packages#6265) 2024-03-05 [email protected] [video_player] Fix typo in readme (flutter/packages#6264) 2024-03-05 [email protected] [pigeon] Separates message call code generation into separate methods in the SwiftGenerator (flutter/packages#5959) 2024-03-05 [email protected] [flutter_markdown] Fix WidgetSpan Support in MarkdownElementBuilder (flutter/packages#6225) 2024-03-04 [email protected] [webview_flutter] Make WebKitWebViewWidget unit tests stateless (flutter/packages#6228) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This is a regression test for #144087 and #138588. To be submitted after #144579.

…144629) flutter/engine@a7c7858...3e8b0de 2024-03-05 [email protected] Folds concurrent job calculation into `tools/gn` (flutter/engine#51193) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Adds missing `style` to `PopupMenuButton`. Fixes: #114709

Improved the smiley image TextButton example a little. Handling the case where the `Future.delayed` object that represents the button's one second long action is superseded by a second button press that triggers a new one-second action. This does complicate the example - just a little - but it's a little more robust. In case someone copy-and-pastes the code. The TextButton example was recently updated: #144583

…144639) flutter/engine@3e8b0de...49bc157 2024-03-05 [email protected] Fix typo in githook message (flutter/engine#51205) 2024-03-05 [email protected] Roll Skia from 453cb0d04584 to 875b356e4d96 (2 revisions) (flutter/engine#51202) 2024-03-05 [email protected] Add device selection to `et run` (flutter/engine#51184) 2024-03-05 [email protected] Roll Skia from de108a9c8b54 to 453cb0d04584 (2 revisions) (flutter/engine#51201) 2024-03-05 [email protected] Adds githooks that reminds to run `gclient sync -D` (flutter/engine#51156) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

… Web) (#144161) Partial implementation of #143348 This enables asset transformation during hot reload (except for web, because that has its own implementation of `DevFS` ð��). Asset transformers will be reapplied after changing any asset and performing a hot reload during `flutter run`.

…144248) Fixes #144244.

…144653) flutter/engine@49bc157...effcf97 2024-03-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (#51209)" (flutter/engine#51217) 2024-03-05 [email protected] [Impeller] implement blur style solid (flutter/engine#50892) 2024-03-05 [email protected] [g3 roll] Revert "Remove unused drone_dimension field" (flutter/engine#51214) 2024-03-05 [email protected] Roll Skia from 17677914dabf to 37947aec8c5c (5 revisions) (flutter/engine#51211) 2024-03-05 [email protected] Fix git hooks on Windows (flutter/engine#51203) 2024-03-05 [email protected] [Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (flutter/engine#51209) 2024-03-05 [email protected] [Impeller] Fix convex triangulation winding bug for multi-contour paths. (flutter/engine#51198) 2024-03-05 [email protected] Roll Skia from 875b356e4d96 to 17677914dabf (2 revisions) (flutter/engine#51207) 2024-03-05 [email protected] Skip configuration dependency if unit tests are disabled (flutter/engine#51179) 2024-03-05 [email protected] [Impeller] Implement YUV texture import and sampling for video player frames. (flutter/engine#50730) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…143661) I was doing some debugging on a RenderSliver subclass, and found that SliverConstraints.toString was missing the precedingScrollExtent field. Add that, and add both that field and userScrollDirection to the `==` and hashCode implementations, which had been skipping them, so that all three methods now handle all the class's fields.

…144659) flutter/engine@effcf97...d374c78 2024-03-06 [email protected] Revamp the `scenario_app/../README.md` to encourage self-sustenance (flutter/engine#51196) 2024-03-06 [email protected] [Impeller] disable blending in gaussian intermediate steps. (flutter/engine#51118) 2024-03-06 [email protected] [Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (flutter/engine#51219) 2024-03-06 [email protected] Roll Skia from 37947aec8c5c to 1d1fd7fe1a89 (1 revision) (flutter/engine#51216) 2024-03-06 [email protected] [Impeller] Fix path winding when bridging from contours with an odd number of points. (flutter/engine#51218) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…144661) flutter/engine@d374c78...370e7d5 2024-03-06 [email protected] Roll Skia from 1d1fd7fe1a89 to db3a36120ae2 (1 revision) (flutter/engine#51222) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…144668) flutter/engine@370e7d5...b6efe0d 2024-03-06 [email protected] Roll Skia from db3a36120ae2 to f17ec7494469 (3 revisions) (flutter/engine#51226) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/packages@2aa6e3f...9b88dbc 2024-03-06 [email protected] [image_picker_for_web] migrates to package:web (flutter/packages#5799) 2024-03-06 [email protected] [video_player_web] migrates to package:web (flutter/packages#5800) 2024-03-06 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20240205 to 20240303 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#6253) 2024-03-05 [email protected] [rfw] Change test coverage logic to enforce 100% coverage (flutter/packages#6272) 2024-03-05 [email protected] [in_app_purchase_storekit] backfill native tests for more complete test coverage (flutter/packages#6209) 2024-03-05 [email protected] [tool] Add features to support GCB auto-publish flow (flutter/packages#6218) 2024-03-05 [email protected] [web] Use TrustedTypes from pkg web. (flutter/packages#6273) 2024-03-05 [email protected] Roll Flutter from 65cd84b to 3b5a2ec (26 revisions) (flutter/packages#6269) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comparing changes

Open a pull request

Commits on Mar 5, 2024

Commits on Mar 6, 2024

This comparison is taking too long to generate.

Uh oh!