# Proposal

I suggest to make possible to specify .env files to the --dart-define-from-file in addition to the Json format.

# Issue

Close #128667

When android uses iOS style `PageTransitionsBuilder` and iOS uses android style `PageTransitionsBuilder`, on android, swipe from the left edge of the screen doesn't work. This PR solves that problem.

#99919 introduced a breaking change, the pr re-implemented it <del>without introducing a breaking change.**</del>

This PR is adding a file of two simple unit tests in order to improve code coverage (covering two simple classes within the annotations.dart file).

The issue this is fixing is the lack of complete test coverage for the annotations.dart file.

…sions) (#130023)

Manual roll Flutter Engine from 987b621eac4e to bd2e42b203e1 (32 revisions)

Manual roll requested by [email protected]

flutter/engine@987b621...bd2e42b

2023-07-05 [email protected] Reverts Dart SDK to version 3.1.0-262.0.dev (flutter/engine#43417)
2023-07-05 [email protected] Roll Fuchsia Mac SDK from 8YulTHvG-Jg3Sof-S... to C3Q7MJBYkiin8zw-f... (flutter/engine#43415)
2023-07-05 [email protected] Roll Dart SDK from f7c242ded366 to e193587883d6 (1 revision) (flutter/engine#43414)
2023-07-05 [email protected] Roll Skia from a453fed07c91 to d58324bf653d (1 revision) (flutter/engine#43413)
2023-07-05 [email protected] Roll Skia from faf906db84ab to a453fed07c91 (4 revisions) (flutter/engine#43412)
2023-07-05 [email protected] Roll Dart SDK from c89f5ac4fd46 to f7c242ded366 (1 revision) (flutter/engine#43410)
2023-07-04 [email protected] Roll Fuchsia Mac SDK from 8-taK-r4HkgVAIGtU... to 8YulTHvG-Jg3Sof-S... (flutter/engine#43409)
2023-07-04 [email protected] Roll Dart SDK from 7cd6ed860b63 to c89f5ac4fd46 (1 revision) (flutter/engine#43408)
2023-07-04 [email protected] Roll Dart SDK from d128bd4977a7 to 7cd6ed860b63 (1 revision) (flutter/engine#43406)
2023-07-04 [email protected] Roll Skia from eaca275ef1c0 to faf906db84ab (1 revision) (flutter/engine#43405)
2023-07-04 [email protected] Roll Dart SDK from e58e3bd3b507 to d128bd4977a7 (1 revision) (flutter/engine#43403)
2023-07-04 [email protected] Roll Fuchsia Mac SDK from GNWxBcnfjZlyaOw34... to 8-taK-r4HkgVAIGtU... (flutter/engine#43402)
2023-07-04 [email protected] Roll Skia from bb18c9b1f730 to eaca275ef1c0 (1 revision) (flutter/engine#43401)
2023-07-04 [email protected] Roll Dart SDK from 604ccea2f5b9 to e58e3bd3b507 (1 revision) (flutter/engine#43400)
2023-07-04 [email protected] Roll Skia from 85a3fda32850 to bb18c9b1f730 (3 revisions) (flutter/engine#43399)
2023-07-04 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.1.0 to 4.2.0 (flutter/engine#43398)
2023-07-04 [email protected] Roll Skia from 4abc43e2ffcc to 85a3fda32850 (1 revision) (flutter/engine#43393)
2023-07-04 [email protected] [Impeller] Document `impeller::Context`. (flutter/engine#43389)
2023-07-03 [email protected] Roll Dart SDK from a4c5ed075a2b to 604ccea2f5b9 (1 revision) (flutter/engine#43390)
2023-07-03 [email protected] Roll Dart SDK from c092e09b7e64 to a4c5ed075a2b (1 revision) (flutter/engine#43387)
2023-07-03 [email protected] Roll Skia from 6a5ea15c942b to 4abc43e2ffcc (1 revision) (flutter/engine#43386)
2023-07-03 [email protected] Roll Fuchsia Mac SDK from cytps4RRhs8-wbcVJ... to GNWxBcnfjZlyaOw34... (flutter/engine#43373)
2023-07-03 [email protected] Roll Dart SDK from dedff8f0ebd2 to c092e09b7e64 (1 revision) (flutter/engine#43374)
2023-07-03 [email protected] Roll Skia from 94ad507b8959 to 6a5ea15c942b (1 revision) (flutter/engine#43385)
2023-07-03 [email protected] Roll Skia from e16d5b988a36 to 94ad507b8959 (2 revisions) (flutter/engine#43383)
2023-07-03 [email protected] Roll Skia from 384b84445a9f to e16d5b988a36 (1 revision) (flutter/engine#43382)
2023-07-02 [email protected] Roll Skia from dbf0829114ee to 384b84445a9f (2 revisions) (flutter/engine#43381)
2023-07-01 [email protected] [Impeller] Remove blend mode restrictions on clear color optimization (flutter/engine#43348)
2023-07-01 [email protected] Roll Dart SDK from f00f7363f4bf to dedff8f0ebd2 (4 revisions) (flutter/engine#43371)
2023-07-01 [email protected] Roll Skia from ceaeef84b8a3 to dbf0829114ee (15 revisions) (flutter/engine#43370)
2023-07-01 [email protected] [Impeller] Add explicit color filter types to Aiks. (flutter/engine#43342)
2023-07-01 [email protected] Roll Dart SDK from 2d98d9e27dae to f00f7363f4bf (1 revision) (flutter/engine#43354)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from cytps4RRhs8- to C3Q7MJBYkiin

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

...

This change is for an internal IDE client to send a custom hot reload
request, as custom requests from the client must start with `$/`.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above. (this PR is linked internally)
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

…r.dart` (#129663)

Removes deprecated APIs from v2.6 in `binding.dart` and `widget_tester.dart`

Resolves #129654

…template" (#130035)

This more closely matches our other conventions.

#129556 (#129860)

Reland #129556 which had failed
an internal test (see Google internal link b/288993600) and was reverted
in #129645.

This PR must be landed with G3 Fix cl/543755631

q.v. https://flutter.dev/go/triage-2023-rfc

PLUS: clean-up of all the unreachable stuff.

Previously, if you changed buttons during a long-press gesture, if it was before the gesture was accepted we would discard it, and if it was after the gesture was accepted we would silently end it without firing any of the relevant events.

This silent cancelation behavior is terrible because it means there's no way for consumers to know what state they're in, so you end up with widgets that thing they're still being long-pressed even though nothing is happening.

We could change the behavior in three ways, as far as I can tell:

- we could send a cancel event when you change buttons. This would introduce a new kind of transition (start->cancel) which I don't think we currently require people to support. This would therefore not fix existing code and would make future code more complicated to handle a really obscure user action that it seems unlikely anyone cares about.

- we could send an end event when you change buttons. This would mean the action commits, even though the user is still holding the mouse button down. This seems slightly better than the previous option but still not ideal as it means nudging the mouse button commits you even though you're still holding the button down.

- we could ignore button changes after the long-press has been accepted.

I implemented the last one in this PR.