-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: 3476b966524f
head repository: flutter/flutter
compare: 64591356b968
- 20 commits
- 49 files changed
- 12 contributors
Commits on Apr 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 03d7256 - Browse repository at this point
Copy the full SHA 03d7256View commit details -
fix SliverReorderableList test to use correct custom action id (#125144)
as title ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Configuration menu - View commit details
-
Copy full SHA for 122dacf - Browse repository at this point
Copy the full SHA 122dacfView commit details -
Refactor Flutter Gradle Plugin so it can be applied using the declara…
…tive `plugins {}` block (#123511) This PR aims to resolve #121552. Resources used: - [Developing Plugins](https://docs.gradle.org/current/userguide/custom_plugins.html) - [Using Gradle Plugins](https://docs.gradle.org/current/userguide/plugins.html#sec:plugins_block) - [Composite Builds Plugin Development Sample](https://docs.gradle.org/current/samples/sample_composite_builds_plugin_development.html) This PR also paves way for #121541, because apps will no longer have: ```groovy apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle" ``` hardcoded. Instead, they'll use: ```groovy plugins { // ... id "dev.flutter.flutter-gradle-plugin" // the exact name is tentative } ```Configuration menu - View commit details
-
Copy full SHA for 51251f2 - Browse repository at this point
Copy the full SHA 51251f2View commit details -
Roll Flutter Engine from 609f9d536494 to d626f16cb9a3 (9 revisions) (#…
…125150) flutter/engine@609f9d5...d626f16 2023-04-19 [email protected] [web] Remove non-ShadowDom mode (flutter/engine#39915) 2023-04-19 [email protected] [impeller] added moltenvk notice (flutter/engine#41317) 2023-04-19 [email protected] Roll Skia from 8af1dd9659f0 to ad90b6bd4760 (3 revisions) (flutter/engine#41337) 2023-04-19 [email protected] Roll Dart SDK from 27e71f19c144 to fe8bb0565a30 (2 revisions) (flutter/engine#41336) 2023-04-19 [email protected] Roll Fuchsia Mac SDK from yD5a3QBJHUFM4nVou... to suSuT9F8zuP-pBg-E... (flutter/engine#41334) 2023-04-19 [email protected] Roll Fuchsia Linux SDK from Cy5LG4U2InaFLkJGz... to Tun7i4VLz6ncx8JJJ... (flutter/engine#41331) 2023-04-19 [email protected] Roll Skia from 85d9e67653b1 to 8af1dd9659f0 (1 revision) (flutter/engine#41333) 2023-04-19 [email protected] Roll Skia from 5a718d9e9c06 to 85d9e67653b1 (4 revisions) (flutter/engine#41330) 2023-04-19 [email protected] Roll Dart SDK from 1f224df52bee to 27e71f19c144 (3 revisions) (flutter/engine#41329) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Cy5LG4U2InaF to Tun7i4VLz6nc fuchsia/sdk/core/mac-amd64 from yD5a3QBJHUFM to suSuT9F8zuP- If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 4473899 - Browse repository at this point
Copy the full SHA 4473899View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c6929d - Browse repository at this point
Copy the full SHA 4c6929dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca3a900 - Browse repository at this point
Copy the full SHA ca3a900View commit details -
Roll Flutter Engine from d626f16cb9a3 to 0a53cf6f7a4e (1 revision) (#…
…125152) flutter/engine@d626f16...0a53cf6 2023-04-19 [email protected] [Impeller] Make //impeller/display_list TU naming consistent. (flutter/engine#41174) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 481ac3c - Browse repository at this point
Copy the full SHA 481ac3cView commit details -
Roll Packages from faf53fb to 88591be (6 revisions) (#125153)
flutter/packages@faf53fb...88591be 2023-04-19 [email protected] Roll Flutter from 42fb0b2 to 3476b96 (20 revisions) (flutter/packages#3760) 2023-04-19 49699333+dependabot[bot]@users.noreply.github.com Bump cirrusci/flutter from `794fbbc` to `d99b1ba` in /.ci (flutter/packages#3724) 2023-04-18 [email protected] [webview_flutter] Adds support to listen to url changes (flutter/packages#3313) 2023-04-18 [email protected] Roll Flutter from 15cb1f8 to 42fb0b2 (19 revisions) (flutter/packages#3756) 2023-04-18 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump com.android.tools.build:gradle from 7.2.2 to 8.0.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#3739) 2023-04-18 [email protected] [local_auth] Convert Android to Pigeon (flutter/packages#3748) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 898767f - Browse repository at this point
Copy the full SHA 898767fView commit details -
Revert selectable update back to be a postframecallback or microtask (#…
…125140) The regression was caused by the previous pr #124624 changes postframecallback to scheduleframecallback. The reason is that if a new postframecallback was scheduled when running a postframecallback. The newly added postframecallback will be execute on the next frame. However, adding postframecallback will not schedule a new frame. So if there isn't other widget that schedule a new frame, the newly added postframecallback will never gets run. After changing to scheduleframecallback, it causes an issue that transient callback may be called when rendering tree contains dirty layout information that are waiting to be rebuilt. Therefore, I use microtask to get around of the postframecallback issue instead of scheduleframecallback. fixes #125065
Configuration menu - View commit details
-
Copy full SHA for 14e191f - Browse repository at this point
Copy the full SHA 14e191fView commit details -
Use term wireless instead of network (#124232)
Rename variables, update comments, etc from `network` to `wireless` to keep it more uniform. Also, move non-overriden messages related to device selection into the file they're used. Part 7 in breakdown of #121262.
Configuration menu - View commit details
-
Copy full SHA for 48bb3c0 - Browse repository at this point
Copy the full SHA 48bb3c0View commit details -
Roll Flutter Engine from 0a53cf6f7a4e to d726345bf230 (2 revisions) (#…
…125157) flutter/engine@0a53cf6...d726345 2023-04-19 [email protected] [Impeller] Comprehensively label snapshots (flutter/engine#41325) 2023-04-19 [email protected] [Impeller] Fix transform regressions for chained filters (flutter/engine#41332) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for ea34f7d - Browse repository at this point
Copy the full SHA ea34f7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73f7945 - Browse repository at this point
Copy the full SHA 73f7945View commit details -
[flutter_tools] add todo for userMessages (#125156)
Adds `todo` link in code for #125155.
Configuration menu - View commit details
-
Copy full SHA for fa43a93 - Browse repository at this point
Copy the full SHA fa43a93View commit details -
[flutter_tools] bump min sdk version from 3.0.0-0 to 3.0.0 (#125158)
Allows use of APIs such as `Iterable.firstOrNull`.
Configuration menu - View commit details
-
Copy full SHA for c74cf4b - Browse repository at this point
Copy the full SHA c74cf4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5b0f0a - Browse repository at this point
Copy the full SHA f5b0f0aView commit details
Commits on Apr 20, 2023
-
Show magnifier on touch drag gestures (#125151)
This change shows the magnifier on touch drag gestures for Android and iOS and hides it when the drag ends. Fixes #118268
Configuration menu - View commit details
-
Copy full SHA for 8ed26d8 - Browse repository at this point
Copy the full SHA 8ed26d8View commit details -
Make search view shape clip the view content (#125161)
Fixes #124426 This PR is to make the search view shape clip the view content. Before: the highlight and the "i" of "item 9" are not clipped by the shape. <img width="350" alt="Screenshot 2023-04-19 at 12 09 48 PM" src="https://user-images.githubusercontent.com/36861262/233201222-468820a9-8717-4b6c-8528-8125a40fc161.png"> After: <img width="350" alt="Screenshot 2023-04-19 at 2 13 52 PM" src="https://user-images.githubusercontent.com/36861262/233201609-81f5a942-2390-4081-a9c7-c9523a7f9e72.png">
Configuration menu - View commit details
-
Copy full SHA for 3315b25 - Browse repository at this point
Copy the full SHA 3315b25View commit details -
Roll Flutter Engine from d726345bf230 to 2db85cbe6a01 (4 revisions) (#…
…125183) flutter/engine@d726345...2db85cb 2023-04-20 [email protected] Roll Fuchsia Mac SDK from suSuT9F8zuP-pBg-E... to OcPCdaE17MAihaCrD... (flutter/engine#41352) 2023-04-19 [email protected] Roll Dart SDK from fe8bb0565a30 to 88a3b66b50d6 (2 revisions) (flutter/engine#41349) 2023-04-19 [email protected] Add missing header guards (flutter/engine#41322) 2023-04-19 [email protected] [web] Fix trivial type issue. (flutter/engine#40956) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from suSuT9F8zuP- to OcPCdaE17MAi If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for b04efe4 - Browse repository at this point
Copy the full SHA b04efe4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f2e708 - Browse repository at this point
Copy the full SHA 9f2e708View commit details -
i125138 abstract method smoke agp update (#125139)
- Update gradle and AGP version for abstract_method_smoke_test #125138 part 1/N To update successfully: 1. Update gradle to a version supported by jdk 17 2. Uncommented the lockfile lines in android/build.gradle 3. Then ran the AGP update assistant from AndroidStudio -> tools 4. From android ran `./gradlew dependencies --write-locks` 5. From android/app ran `./gradlew dependencies --write-locks` 6. Re enabled the lockfiles section of android/build.gradle 7. Ensured `flutter build apk` passed
Configuration menu - View commit details
-
Copy full SHA for 6459135 - Browse repository at this point
Copy the full SHA 6459135View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 3476b966524f...64591356b968