Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 321fbc0e7e81
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6b93cf93c100
Choose a head ref
  • 18 commits
  • 84 files changed
  • 9 contributors

Commits on Mar 6, 2025

  1. Roll pub packages (#164713)

    This PR was generated by `flutter update-packages --force-upgrade`.
    flutter-pub-roller-bot authored Mar 6, 2025
    Configuration menu
    Copy the full SHA
    97f7c50 View commit details
    Browse the repository at this point in the history
  2. Roll Packages from abba683 to fc9d5ca (3 revisions) (#164714)

    flutter/packages@abba683...fc9d5ca
    
    2025-03-06 [email protected] manual roll with video player test
    disabled (flutter/packages#8803)
    2025-03-05 [email protected] [rfw] Make widget builders
    work with loops (flutter/packages#8650)
    2025-03-05 [email protected] [shared_preferences_android] dependabot
    takeover datastore (flutter/packages#8784)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected] on the revert to ensure that a
    human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Mar 6, 2025
    Configuration menu
    Copy the full SHA
    ac4e54c View commit details
    Browse the repository at this point in the history
  3. Roll pub packages (#164721)

    This PR was generated by `flutter update-packages --force-upgrade`.
    flutter-pub-roller-bot authored Mar 6, 2025
    Configuration menu
    Copy the full SHA
    7cdea59 View commit details
    Browse the repository at this point in the history
  4. [hcpp] Add tests for transform mutator (#164664)

    Adds tests covering all transform cases (rotation, flipping, scaling,
    translation).
    
    Fixes #164213.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    
    ---------
    
    Co-authored-by: Gray Mackall <[email protected]>
    gmackall and Gray Mackall authored Mar 6, 2025
    Configuration menu
    Copy the full SHA
    c45b835 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    50f6b48 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8876bcc View commit details
    Browse the repository at this point in the history
  7. Add lldb init file (#164344)

    Adds an .lldbinit file to iOS app xcscheme.
    
    Adding to scheme files can be error prone since a developer may be using
    custom schemes (flavors). If we can't add it to the scheme, we print an
    error without failing.
    
    Since it is part of the scheme, it will be added to the project and will
    be used on every run regardless of the device type/version. The Dart
    side handles limiting to specific devices. If needed, we can alter the
    .lldbinit file during `flutter assemble` to rewrite it since it doesn't
    read the file until launch time (therefore it can be changed during
    build time).
    
    During `flutter assemble`, if the project doesn't have an LLDB Init File
    set for any schemes, it'll throw an error if running in debug mode with
    an iOS 18.4+ device.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    vashworth authored Mar 6, 2025
    Configuration menu
    Copy the full SHA
    eb07c51 View commit details
    Browse the repository at this point in the history
  8. Migrate Mutators to DisplayList/Impeller geometry (#164258)

    Mutator types and MutatorsStack will now use DisplayList/Impeller
    geometry objects.
    flar authored Mar 6, 2025
    Configuration menu
    Copy the full SHA
    66e910d View commit details
    Browse the repository at this point in the history
  9. Adds aria-controls support (#163894)

    <!--
    Thanks for filing a pull request!
    Reviewers are typically assigned within a week of filing a request.
    To learn more about code review, see our documentation on Tree Hygiene:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    -->
    
    adding a new property in semantics properties called
    controlsVisibilityOfNodes, where developer can assign
    SemanticsProperties.identifier of other nodes to indicates which nodes'
    visibilities this node controls
    
    fixes #162125
    
    ## Pre-launch Checklist
    
    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [ ] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    chunhtai authored Mar 6, 2025
    Configuration menu
    Copy the full SHA
    e0b9869 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2025

  1. Configuration menu
    Copy the full SHA
    dadb05c View commit details
    Browse the repository at this point in the history
  2. [Impeller] test empty snapshot and allocation failure. (#164668)

    Speculative fix for #164628
    
    If our render target allocation failed, we need to bail out of toImage
    so that we don't crash. Adds a test that simulates this by asking for a
    0x0 texture.
    Jonah Williams authored Mar 7, 2025
    Configuration menu
    Copy the full SHA
    a45d325 View commit details
    Browse the repository at this point in the history
  3. Clip layers reduce rrects and paths to simpler shapes when possible (#…

    …164693)
    
    Flutter code can pass clips in the widget tree down as Path objects even
    if they were originally simpler shapes. We now catch those
    simplifications in the clip_*_layer code and perform reduced operations
    in their place.
    flar authored Mar 7, 2025
    Configuration menu
    Copy the full SHA
    f109028 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cd337fd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7ab81e0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e190868 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d9f4817 View commit details
    Browse the repository at this point in the history
  8. Roll Packages from fc9d5ca to 4c5a7ed (4 revisions) (#164785)

    flutter/packages@fc9d5ca...4c5a7ed
    
    2025-03-07 [email protected] Update PR template for clarity
    (flutter/packages#8777)
    2025-03-06 [email protected] [google_sign_in] Add Android account name
    field as optional (implementation package changes)
    (flutter/packages#8805)
    2025-03-06 [email protected] Roll Flutter from
    2578d97 to 321fbc0 (29 revisions) (flutter/packages#8808)
    2025-03-06 [email protected] [various] Updates packages to use
    flutter.compileSdkVersion (flutter/packages#8734)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected] on the revert to ensure that a
    human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Mar 7, 2025
    Configuration menu
    Copy the full SHA
    1b14b0c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6b93cf9 View commit details
    Browse the repository at this point in the history
Loading