Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2e748e8598b3
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3882afbfa997
Choose a head ref
  • 16 commits
  • 32 files changed
  • 7 contributors

Commits on Apr 15, 2024

  1. [Doctor] Improve CocoaPods messages (#146701)

    This tweaks the Flutter doctor messages for CocoaPods.
    
    This also switches the "unknown version" error to link to the update instructions instead of the installation instructions; the user has already installed CocoaPods in this scenario.
    
    Example error before:
    
    ```
        � CocoaPods not installed.
            CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
            Without CocoaPods, plugins will not work on iOS or macOS.
            For more info, see https://flutter.dev/platform-plugins
          To install see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.
    ```
    
    Example error after:
    
    ```
        � CocoaPods not installed.
            CocoaPods is a package manager for iOS or macOS platform code.
            Without CocoaPods, plugins will not work on iOS or macOS.
            For more info, see https://flutter.dev/platform-plugins
          For installation instructions, see https://guides.cocoapods.org/using/getting-started.html#installation
    ```
    loic-sharma authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    882bcbb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c4a7cf2 View commit details
    Browse the repository at this point in the history
  3. Roll Flutter Engine from 1a13c7d1f40e to 84238c411001 (4 revisions) (#…

    …146775)
    
    flutter/engine@1a13c7d...84238c4
    
    2024-04-15 [email protected] [scenarios] test disabling surface clear. (flutter/engine#52128)
    2024-04-12 [email protected] Roll Dart SDK from 3d13dbfb3284 to ac31be3c8546 (8 revisions) (flutter/engine#52084)
    2024-04-12 [email protected] Roll Skia from 761f6f7f6250 to 9e20a146c024 (7 revisions) (flutter/engine#52085)
    2024-04-12 [email protected] [Windows] Refactor client wrapper to prepare for multi-view (flutter/engine#52073)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    0d6bd20 View commit details
    Browse the repository at this point in the history
  4. Add hitTestBehavior and rootOverlay to LongPressDraggable constructor… (

    #146386)
    
    Passes through these two Draggable parameters so that they're usable in LongPressDraggable.
    Amir-P authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    c98d68d View commit details
    Browse the repository at this point in the history
  5. Roll Flutter Engine from 84238c411001 to 07ae93c9b755 (3 revisions) (#…

    …146776)
    
    flutter/engine@84238c4...07ae93c
    
    2024-04-15 [email protected] Roll Dart SDK from ac31be3c8546 to 3c2376cb9850 (1 revision) (flutter/engine#52095)
    2024-04-15 [email protected] Migrate FlutterCallbackCache and FlutterKeyboardManager to ARC (flutter/engine#51983)
    2024-04-15 [email protected] Roll buildroot and set ios_use_simulator variable used by Skia GN scripts (flutter/engine#52101)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    8c12ba8 View commit details
    Browse the repository at this point in the history
  6. Roll pub packages (#146782)

    This PR was generated by `flutter update-packages --force-upgrade`.
    flutter-pub-roller-bot authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    e6a0691 View commit details
    Browse the repository at this point in the history
  7. Bump github/codeql-action from 3.24.10 to 3.25.0 (#146784)

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.10 to 3.25.0.
    <details>
    <summary>Changelog</summary>
    <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
    <blockquote>
    <h1>CodeQL Action Changelog</h1>
    <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
    <p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
    <h2>[UNRELEASED]</h2>
    <p>No user facing changes.</p>
    <h2>3.25.0 - 15 Apr 2024</h2>
    <ul>
    <li>
    <p>The deprecated feature for extracting dependencies for a Python analysis has been removed. <a href="https://redirect.github.com/github/codeql-action/pull/2224">#2224</a></p>
    <p>As a result, the following inputs and environment variables are now ignored:</p>
    <ul>
    <li>The <code>setup-python-dependencies</code> input to the <code>init</code> Action</li>
    <li>The <code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION</code> environment variable</li>
    </ul>
    <p>We recommend removing any references to these from your workflows. For more information, see the release notes for CodeQL Action v3.23.0 and v2.23.0.</p>
    </li>
    <li>
    <p>Automatically overwrite an existing database if found on the filesystem. <a href="https://redirect.github.com/github/codeql-action/pull/2229">#2229</a></p>
    </li>
    <li>
    <p>Bump the minimum CodeQL bundle version to 2.12.6. <a href="https://redirect.github.com/github/codeql-action/pull/2232">#2232</a></p>
    </li>
    <li>
    <p>A more relevant log message and a diagnostic are now emitted when the <code>file</code> program is not installed on a Linux runner, but is required for Go tracing to succeed. <a href="https://redirect.github.com/github/codeql-action/pull/2234">#2234</a></p>
    </li>
    </ul>
    <h2>3.24.10 - 05 Apr 2024</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.17.0. <a href="https://redirect.github.com/github/codeql-action/pull/2219">#2219</a></li>
    <li>Add a deprecation warning for customers using CodeQL version 2.12.5 and earlier. These versions of CodeQL were discontinued on 26 March 2024 alongside GitHub Enterprise Server 3.8, and will be unsupported by CodeQL Action versions 3.25.0 and later and versions 2.25.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/2220">#2220</a>
    <ul>
    <li>If you are using one of these versions, please update to CodeQL CLI version 2.12.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
    <li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.11.6 and 2.12.5, you can replace <code>github/codeql-action/*@V3</code> by <code>github/codeql-action/*@v3.24.10</code> and <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.24.10</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
    </ul>
    </li>
    </ul>
    <h2>3.24.9 - 22 Mar 2024</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.16.5. <a href="https://redirect.github.com/github/codeql-action/pull/2203">#2203</a></li>
    </ul>
    <h2>3.24.8 - 18 Mar 2024</h2>
    <ul>
    <li>Improve the ease of debugging extraction issues by increasing the verbosity of the extractor logs when running in debug mode. <a href="https://redirect.github.com/github/codeql-action/pull/2195">#2195</a></li>
    </ul>
    <h2>3.24.7 - 12 Mar 2024</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.16.4. <a href="https://redirect.github.com/github/codeql-action/pull/2185">#2185</a></li>
    </ul>
    <h2>3.24.6 - 29 Feb 2024</h2>
    <p>No user facing changes.</p>
    <h2>3.24.5 - 23 Feb 2024</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.16.3. <a href="https://redirect.github.com/github/codeql-action/pull/2156">#2156</a></li>
    </ul>
    </blockquote>
    <p>... (truncated)</p>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/github/codeql-action/commit/df5a14dc28094dc936e103b37d749c6628682b60"><code>df5a14d</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2238">#2238</a> from github/update-v3.25.0-2b2cee522</li>
    <li><a href="https://github.com/github/codeql-action/commit/3f70eaa4d31bbf0600be93a0ae88db6c0aef186a"><code>3f70eaa</code></a> Update changelog for v3.25.0</li>
    <li><a href="https://github.com/github/codeql-action/commit/2b2cee52294c410df28cc7ba0beaf429d5b4e82c"><code>2b2cee5</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2234">#2234</a> from github/mbg/clearer-file-command-failure</li>
    <li><a href="https://github.com/github/codeql-action/commit/4fcf7a216ce13f13ffe9f395a802a3f22f8190e6"><code>4fcf7a2</code></a> Add changelog entry</li>
    <li><a href="https://github.com/github/codeql-action/commit/d30d1cabb492838711c91e6280899193c0f779c7"><code>d30d1ca</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2237">#2237</a> from github/henrymercer/more-configuration-errors</li>
    <li><a href="https://github.com/github/codeql-action/commit/55585360a353847d36f63bc5c29f1b7086340901"><code>5558536</code></a> Add configuration error for unsupported build mode</li>
    <li><a href="https://github.com/github/codeql-action/commit/fa75c144b4edca3ccd9a781733939fad7515f12e"><code>fa75c14</code></a> Capture rate limit and ref not existing config errors</li>
    <li><a href="https://github.com/github/codeql-action/commit/5a599c68cf43195b46783a38eafaca73404ea2e4"><code>5a599c6</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2236">#2236</a> from github/henrymercer/feature-flags-with-tool-feat...</li>
    <li><a href="https://github.com/github/codeql-action/commit/829376a61898ee2e4be42297fc41c4adcc10bf00"><code>829376a</code></a> Allow feature flags to specify tool feature requirements</li>
    <li><a href="https://github.com/github/codeql-action/commit/efc474680fa70a6df5c97b97233f665b4b7d6749"><code>efc4746</code></a> Downgrade log levels for some messages to debug</li>
    <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/4355270be187e1b672a7a1c7c7bae5afdc1ab94a...df5a14dc28094dc936e103b37d749c6628682b60">compare view</a></li>
    </ul>
    </details>
    <br />
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.24.10&new-version=3.25.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    </details>
    dependabot[bot] authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    38dcca9 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Roll Flutter Engine from 07ae93c9b755 to 503e7e8f37f3 (7 revisions) (#…

    …146790)
    
    flutter/engine@07ae93c...503e7e8
    
    2024-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] moved to bgra10_xr (#52019)" (flutter/engine#52140)
    2024-04-15 [email protected] Roll Skia from d27e288efd54 to 0b5df0201734 (1 revision) (flutter/engine#52132)
    2024-04-15 [email protected] Roll Skia from 0fe107da5a4e to d27e288efd54 (6 revisions) (flutter/engine#52130)
    2024-04-15 [email protected] [Impeller] moved to bgra10_xr (flutter/engine#52019)
    2024-04-15 [email protected] Roll Skia from 9e20a146c024 to 0fe107da5a4e (33 revisions) (flutter/engine#52129)
    2024-04-15 [email protected] [Impeller] Use Wang's formula for quad/cubic subdivision. (flutter/engine#52079)
    2024-04-15 [email protected] [Impeller] organize shaders a bit, make filter shaders use same vertex source. (flutter/engine#52113)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    8615fc6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb68f3c View commit details
    Browse the repository at this point in the history
  3. Roll Flutter Engine from 557ffb1cfda6 to 76fbe31a96b3 (4 revisions) (#…

    …146792)
    
    flutter/engine@557ffb1...76fbe31
    
    2024-04-16 [email protected] [Impeller] Update the readme to reflect current guidance on how to try Impeller. (flutter/engine#52135)
    2024-04-16 [email protected] [iOS] allow enabling asserts from Plist. (flutter/engine#52069)
    2024-04-16 [email protected] Roll Dart SDK from 3c2376cb9850 to 5f03197b9992 (5 revisions) (flutter/engine#52134)
    2024-04-15 [email protected] Roll Skia from 0b5df0201734 to f6a2a2af83f1 (2 revisions) (flutter/engine#52136)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    817630c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    08bae32 View commit details
    Browse the repository at this point in the history
  5. Roll pub packages (#146797)

    This PR was generated by `flutter update-packages --force-upgrade`.
    flutter-pub-roller-bot authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c06faf4 View commit details
    Browse the repository at this point in the history
  6. Roll Flutter Engine from 66ad80217898 to cba7678fcfd2 (6 revisions) (#…

    …146811)
    
    flutter/engine@66ad802...cba7678
    
    2024-04-16 [email protected] Roll Dart SDK from 7d02f18b8a84 to cb0c34389d90 (1 revision) (flutter/engine#52151)
    2024-04-16 [email protected] Roll Skia from 50ac1117f159 to 8013b7f1dcd3 (5 revisions) (flutter/engine#52149)
    2024-04-16 49699333+dependabot[bot]@users.noreply.github.com Bump google/osv-scanner-action from 1.6.2.pre.beta1 to 1.7.1 (flutter/engine#52147)
    2024-04-16 [email protected] Migrate vsync_waiter_ios to ARC (flutter/engine#52104)
    2024-04-16 [email protected] Roll Skia from b159229f2174 to 50ac1117f159 (1 revision) (flutter/engine#52146)
    2024-04-16 [email protected] Roll Dart SDK from 5f03197b9992 to 7d02f18b8a84 (2 revisions) (flutter/engine#52145)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9aea02b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cb719db View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c3445dc View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3882afb View commit details
    Browse the repository at this point in the history
Loading