Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2d30fe448cd4
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5d83a98331ac
Choose a head ref
  • 5 commits
  • 4 files changed
  • 2 contributors

Commits on Sep 13, 2024

  1. Roll Flutter Engine from bef48e87f438 to ab9daaa0bcc7 (3 revisions) (#… 

    …155172)

flutter/engine@bef48e8...ab9daaa

2024-09-13 [email protected] Roll Skia from 7cba76a07795 to a5a6d12b3642 (3 revisions) (flutter/engine#55179)
2024-09-13 [email protected] Add copyright notices to java test files (flutter/engine#55155)
2024-09-13 [email protected] Roll Skia from abb4eeac59c2 to 7cba76a07795 (1 revision) (flutter/engine#55174)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    07647ca View commit details
    Browse the repository at this point in the history

  2. text button case rework (#154943) 

    Rework on the text button use case to pass [b/347102786](https://b.corp.google.com/347102786), 

After talking with the tester, it seems like there isn't an issue with the A11y of the text button, rather just how the test case is set up. In order for the text case to pass, there needs to be real time feedback of an action that is done by pressing the text button (think of a dialog popup, or form submission notification). 

So I rewrote the test case to mimic a simple form with a submit button that once submitted, will let the user know it is submitted with a snack bar notification. https://screencast.googleplex.com/cast/NTM0ODc1NDIxMDE2MDY0MHwzYWI4MTZhMS1hMA
    @DBowen33
    DBowen33 authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    47aed96 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Roll Flutter Engine from ab9daaa0bcc7 to 4d8d8517a0ff (12 revisions) (#… 

    …155194)

flutter/engine@ab9daaa...4d8d851

2024-09-14 [email protected] Synthesize remove events on `PointerChange.ACTION_UP` and `PointerChange.ACTION_POINTER_UP` (flutter/engine#55157)
2024-09-13 [email protected] Roll Skia from bdc5e73cb6c9 to 2b8e33aa4824 (1 revision) (flutter/engine#55192)
2024-09-13 [email protected] Roll Dart SDK from 302b6472b849 to c0f7e399ff4a (1 revision) (flutter/engine#55191)
2024-09-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[skwasm] Scene builder optimizations for platform view placement (#54949)" (flutter/engine#55193)
2024-09-13 [email protected] Delete VolatilePathTracker in favor of Dispatch tracking (flutter/engine#55125)
2024-09-13 [email protected] Roll Fuchsia Linux SDK from 3YH1DEYJ-s93fHBw5... to -kKh_AYzPh_iEmTxK... (flutter/engine#55190)
2024-09-13 [email protected] Roll Skia from 9877f459399a to bdc5e73cb6c9 (1 revision) (flutter/engine#55189)
2024-09-13 [email protected] [impeller] add Android flag for disabling surface control for debugging. (flutter/engine#55185)
2024-09-13 [email protected] Roll Skia from a5a6d12b3642 to 9877f459399a (2 revisions) (flutter/engine#55187)
2024-09-13 [email protected] Roll Dart SDK from eb664303c5ff to 302b6472b849 (2 revisions) (flutter/engine#55182)
2024-09-13 [email protected] [skwasm] Scene builder optimizations for platform view placement (flutter/engine#54949)
2024-09-13 [email protected] add back test itSendsTextShowPasswordToFrameworkOnAttach with new mock for display metrics (flutter/engine#55110)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 3YH1DEYJ-s93 to -kKh_AYzPh_i

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 14, 2024
    Configuration menu
    Copy the full SHA
    1dce0c7 View commit details
    Browse the repository at this point in the history

  2. Roll Flutter Engine from 4d8d8517a0ff to c83cc8856282 (3 revisions) (#… 

    …155201)

flutter/engine@4d8d851...c83cc88

2024-09-14 [email protected] Roll Dart SDK from c0f7e399ff4a to de4a3d63671c (1 revision) (flutter/engine#55199)
2024-09-14 [email protected] [Impeller] desktop: Add missing dispatch for TextFrameDispatcher in embedder view. (flutter/engine#55197)
2024-09-14 [email protected] Add xcprivacy privacy manifest to macOS framework (flutter/engine#55078)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 14, 2024
    Configuration menu
    Copy the full SHA
    e1cb59f View commit details
    Browse the repository at this point in the history

  3. Roll Flutter Engine from c83cc8856282 to 622d4aec2e04 (1 revision) (#… 

    …155202)

flutter/engine@c83cc88...622d4ae

2024-09-14 [email protected] Roll Skia from 2b8e33aa4824 to 0ec9b089fa9e (1 revision) (flutter/engine#55201)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Sep 14, 2024
    Configuration menu
    Copy the full SHA
    5d83a98 View commit details
    Browse the repository at this point in the history
Loading