Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 29a238d0d506
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8d0b31d81a02
Choose a head ref
  • 19 commits
  • 78 files changed
  • 16 contributors

Commits on Sep 15, 2025

  1. Remove 'v' Open DevTools from help on web in profile/release mode (#1…

    …72829)
    
    This change:
    - Hides `v` from the help menu on web in profile/release mode
    - Keeps `v` available in debug and on native platforms
    - Change command order: `v` now appears before `s` in help
    - Updates `_commonTerminalInputHandler` to block `v` on web in release
    mode
    
    Testing:
    - Added new test: `printHelpDetails hides v on web in profile mode`
    - Added new test: 'v - does not launchDevToolsInBrowser on web in
    profile mode'
    - Fixed existing test to match correct command order (`v` before `s`)
    
    fixes #143451
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    ---------
    
    Co-authored-by: Daniil Lipatkin <[email protected]>
    Co-authored-by: Ben Konyi <[email protected]>
    3 people authored Sep 15, 2025
    Configuration menu
    Copy the full SHA
    41e3968 View commit details
    Browse the repository at this point in the history
  2. Roll Packages from 15e7e89 to fcd5f68 (3 revisions) (#175366)

    flutter/packages@15e7e89...fcd5f68
    
    2025-09-15 [email protected] [url_launcher] Add Android support
    for externalNonBrowserApplication (flutter/packages#9993)
    2025-09-12 49699333+dependabot[bot]@users.noreply.github.com
    [dependabot]: Bump androidx.test.espresso:espresso-contrib from 3.6.1 to
    3.7.0 in /packages/espresso/android (flutter/packages#9910)
    2025-09-12 [email protected] Roll Flutter from
    5a6a1bf to f331a55 (11 revisions) (flutter/packages#9997)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected] on the revert to ensure that a
    human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 15, 2025
    Configuration menu
    Copy the full SHA
    6360d22 View commit details
    Browse the repository at this point in the history
  3. Set Gemini Code Assist include_drafts to false (#175098)

    Set `include_drafts` to false so Gemini Code Assist doesn't comment on
    draft PRs.
    
    "Enables agent functionality on draft pull requests. Default: true."
    
    https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github#default-configuration
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    jmagman authored Sep 15, 2025
    Configuration menu
    Copy the full SHA
    f290249 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ad354af View commit details
    Browse the repository at this point in the history
  5. Roll Skia from f950263bb3d4 to 01b0ede33ae9 (7 revisions) (#175373)

    https://skia.googlesource.com/skia.git/+log/f950263bb3d4..01b0ede33ae9
    
    2025-09-15 [email protected] [rust png] Move Rust PNG public headers
    to non-"experimental" dirs (3/3)
    2025-09-15 [email protected] Roll
    vulkan-deps from fe358c043770 to 603c3e033c87 (5 revisions)
    2025-09-15 [email protected] Use pathbuilder to keep paths immutable
    2025-09-15 [email protected] Revert "SkColorSpacePrimaries: Add
    operator== and operator!="
    2025-09-15 [email protected] Revert "skhdr::Metadata: Add CLLI and MDCV
    metadata and parsing"
    2025-09-15
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-09-15 [email protected] skhdr::Metadata: Add CLLI and MDCV
    metadata and parsing
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected]
    on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 15, 2025
    Configuration menu
    Copy the full SHA
    3e0deb2 View commit details
    Browse the repository at this point in the history
  6. Show cursor after swipe only if TextField has focus (#175044)

    <!--
    Thanks for filing a pull request!
    Reviewers are typically assigned within a week of filing a request.
    To learn more about code review, see our documentation on Tree Hygiene:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    -->
    
    This PR fixes the issue where the cursor appears on a `TextField` after
    a small swipe gesture, even if the field does not have focus.
    
    The problem was caused by missing focus validation when showing the
    cursor.
    Now the cursor is only shown if the `TextField` has focus, which aligns
    with expected behavior.
    
    Fixes #173106
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    Memet18 authored Sep 15, 2025
    Configuration menu
    Copy the full SHA
    98f507e View commit details
    Browse the repository at this point in the history
  7. Update build.gradle to remove deprecation warning in `flutter\engin…

    …e\src\flutter\shell\platform\android` (#175305)
    
    part of #173321
    
    when excuting `./gradlew help --scan --warning-mode all` in
    `flutter\engine\src\flutter\shell\platform\android`
    i see a warning :
    ```gradle
    > Configure project :
    Build file 'C:\flutter\engine\src\flutter\shell\platform\android\build.gradle': line 25
    Properties should be assigned using the 'propName = value' syntax. Setting a property via the Gradle-generated 'propName value' or 'propName(value)' syntax in Groovy DSL has been deprecated. This is scheduled to be removed in Gradle 10.0. Use assignment ('namespace = <value>') instead. Consult the upgrading guide for further information: https://docs.gradle.org/9.0-milestone-1/userguide/upgrading_version_8.html#groovy_space_assignment_syntax
            at build_6pliwxbny923etvz9fwvbblij$_run_closure2.doCall$original(C:\flutter\engine\src\flutter\shell\platform\android\build.gradle:25)
            (Run with --stacktrace to get the full stack trace of this deprecation warning.)
            at build_6pliwxbny923etvz9fwvbblij.run(C:\flutter\engine\src\flutter\shell\platform\android\build.gradle:24)
            (Run with --stacktrace to get the full stack trace of this deprecation warning.)
    ```
    which is the line
    ```gradle
    namespace "io.flutter.embedding"
    ```
    after changing it to :
    ```gradle
    namespace = "io.flutter.embedding"
    ```
    the error is gone :
    ```gradle
    C:\flutter\engine\src\flutter\shell\platform\android git:[master]
    ./gradlew help --scan --warning-mode all
    
    > Task :help
    
    Welcome to Gradle 9.0-milestone-1.
    
    ```
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    AbdeMohlbi authored Sep 15, 2025
    Configuration menu
    Copy the full SHA
    1ceedcd View commit details
    Browse the repository at this point in the history
  8. Add a gn --ccache argument (#174621)

    This enables the use of ccache on Linux and Mac systems.
    
    ---------
    
    Co-authored-by: Loïc Sharma <[email protected]>
    robert-ancell and loic-sharma authored Sep 15, 2025
    Configuration menu
    Copy the full SHA
    cbac57a View commit details
    Browse the repository at this point in the history
  9. Deprecate Objective-C plugin template (#174003)

    This PR marks the `--ios-language objc` flag as deprecated for plugin
    creation. It introduces a warning message in the `flutter create` tool
    when the flag is used, but **does not** remove the functionality at this
    time. This is the first step towards its eventual removal.
    
    ## Context
    
    As discussed in the issue, usage metrics show that Objective-C is used
    in less than 4% of newly created plugins. To streamline the tool and
    align with modern iOS development practices (i.e., Swift), we are
    beginning the process of phasing out this option
    
    **Changes:**
    -   Adds a deprecation warning to the CLI when the `objc` flag is used.
    -   Updates the `--help` text to reflect the deprecation.
    - Removes obsolete tests for Objective-C plugin creation and usage
    tracking.
    
    ## Testing
    
    I have validated these changes by:
    
    1. Manually running `flutter-dev create` with the `objc` flag to confirm
    the new deprecation warning appears.
    2. Verifying that creating a plugin without the --ios-language flag does
    **not** trigger the warning.
    3. Running the tests in the `test/commands.shard` to ensure no
    regressions were introduced.
    4.  CI will validate the changes to the devicelab tests.
    
    Fixes #169683 
    
    ## Pre-launch Checklist
    
    - [X] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [X] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [X] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [X] I signed the [CLA].
    - [X] I listed at least one issue that this PR fixes in the description
    above.
    - [] I updated/added relevant documentation (doc comments with `///`).
    - [] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [X] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    okorohelijah authored Sep 15, 2025
    Configuration menu
    Copy the full SHA
    1eab8e1 View commit details
    Browse the repository at this point in the history
  10. Marks Mac_ios microbenchmarks_ios to be unflaky (#171146)

    <!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
    {
      "name": "Mac_ios microbenchmarks_ios"
    }
    -->
    The test has been passing for [50 consecutive
    runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20microbenchmarks_ios%22).
    This test can be marked as unflaky.
    fluttergithubbot authored Sep 15, 2025
    Configuration menu
    Copy the full SHA
    a396770 View commit details
    Browse the repository at this point in the history
  11. Merge the engine README into the README of the old buildroot. (#175384)

    That readme contained outdated instructions.
    chinmaygarde authored Sep 15, 2025
    Configuration menu
    Copy the full SHA
    324c0ee View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2025

  1. Configuration menu
    Copy the full SHA
    48895f0 View commit details
    Browse the repository at this point in the history
  2. Migrate to widget state (#175242)

    Follow up of #174746
    
    Migrate some files from `MaterialState` to `WidgetState`. This PR only
    focus on WidgetState for a subset of files.
    
    - This minimizes conflicts and reduces the size of the PR for easier
    reviews and follow up
    - I'll work on the other elements of
    `packages/flutter/lib/src/material/material_state.dart` into other PRs
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    ValentinVignal authored Sep 16, 2025
    Configuration menu
    Copy the full SHA
    2d20356 View commit details
    Browse the repository at this point in the history
  3. Fix default overlay color in TabBar (#175270)

    Fix the TODO introduced in
    #174746 (comment)
    
    The hidden bug was that the incorrect color was used for the overlay
    color of `TabBar` when using the default theme:
    
    Consider the scenario for a selected tab:
    1. The user over it
    2. The user presses it
    3. The user stops the press and hovers it again
    
    
    
    https://github.com/flutter/flutter/blob/2efda9cc146fa6eef5f758511cf04a55635366cb/packages/flutter/lib/src/material/tabs.dart#L2698-L2723
    
    Since the hovered and pressed colors are very similar, it is hard to
    catch. I've made a video to illustrate it when the hovered color is blue
    🟦 and the pressed color is red 🟥:
    
    <table>
    <tr>
    <th></th>
    <th>Before</th>
    <th>After</th>
    </tr>
    
    <tr>
    <td>Overlay color</td>
    <td>
    1. <code>primary.withOpacity(0.08)</code><br/>
    2. <code>primary.withOpacity(0.1)</code><br/>
    3. <code>primary.withOpacity(0.1)</code> ❌  Wrong color
    </td>
    
    <td>
    1. <code>primary.withOpacity(0.08)</code><br/>
    2. <code>primary.withOpacity(0.1)</code><br/>
    3. <code>primary.withOpacity(0.08)</code> ✅  Correct color
    </td>
    </tr>
    
    <tr>
    <td></td>
    <td>
    
    
    
    https://github.com/user-attachments/assets/667ea9b9-dce1-446b-93ae-68114464d518
    
    
    
    </td>
    <td>
    
    
    https://github.com/user-attachments/assets/e0910b73-11cc-4fc2-982a-e32a7f47dd1b
    
    
    </td>
    </tr>
    
    </table>
    
    
    | | Before | After |
    | :---: |  :---: | :---: |
    | overlay color| 1. `primary.withOpacity(0.08)`
    5. `` | 1. `primary.withOpacity(0.08)`  |
    
    
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    ValentinVignal authored Sep 16, 2025
    Configuration menu
    Copy the full SHA
    be522c6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d4281d1 View commit details
    Browse the repository at this point in the history
  5. [native_assets] Find more CCompilerConfig on Linux (#175323)

    Sometimes the necessary binaries `code_assets` expects alongside
    `clang++` have differing names than the current code expects (e.g., `ld`
    instead of `ld.lld`) on Linux. This change is necessary on some systems
    with atypical installs, such as NixOS.
    
    These binaries are gathered by the flutter tool and are eventually sent
    to the build hook for native code assets as the `CCompilerConfig`.
    
    Note that the only other reference to `clang`/`clang++` in the linux
    build system is where it is used to invoke `cmake`, where they are set
    as the values of the `CC`/`CXX` environment variables.
    
    Fixes #175311
    
    CC @dcharkes, this is take two of #175312
    
    > This PR also fixes my CI using only the `llvmPackages_20.clangUseLLVM`
    Nix package, for reference
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    GregoryConrad authored Sep 16, 2025
    Configuration menu
    Copy the full SHA
    bbb2362 View commit details
    Browse the repository at this point in the history
  6. Roll Skia from 4e9c86d4a6d9 to 7d160bbf9403 (3 revisions) (#175404)

    engine-flutter-autoroll authored Sep 16, 2025
    Configuration menu
    Copy the full SHA
    2cda3fb View commit details
    Browse the repository at this point in the history
  7. Adds a11y section locale support for iOS (#175005)

    <!--
    Thanks for filing a pull request!
    Reviewers are typically assigned within a week of filing a request.
    To learn more about code review, see our documentation on Tree Hygiene:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    -->
    
    part of #99600
    
    ## Pre-launch Checklist
    
    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [ ] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    chunhtai authored Sep 16, 2025
    Configuration menu
    Copy the full SHA
    e8bef98 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8d0b31d View commit details
    Browse the repository at this point in the history
Loading