Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 28a4e852bc90
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: adffe244f3f1
Choose a head ref
  • 17 commits
  • 35 files changed
  • 9 contributors

Commits on Jul 7, 2025

  1. Configuration menu
    Copy the full SHA
    8b7a48f View commit details
    Browse the repository at this point in the history
  2. [ Tool ] Prepare for enabling omit_obvious_*_types and `specify_non…

    …obvious_*_types` (#171651)
    
    Applying the specified lints will cause some minor breakages that can be
    resolved before the lints are enforced.
    bkonyi authored Jul 7, 2025
    Configuration menu
    Copy the full SHA
    f64e35a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f1e3c76 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9ed8f90 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cb150ca View commit details
    Browse the repository at this point in the history
  6. [ Tool ] Fix crash when SIGQUIT is sent to enable the VM service for …

    …`flutter analyze --watch` (#171713)
    
    The command was parsing stdout assuming all contents were JSON.
    
    Fixes #58391
    bkonyi authored Jul 7, 2025
    Configuration menu
    Copy the full SHA
    9de6f68 View commit details
    Browse the repository at this point in the history
  7. [android] release background image readers on <= Android 14 (#171193)

    Fixes the version of #162147
    that repros on 3.32 (but not the version that the original submitter
    experiences on 3.27 - I've not been able to reproduce that issue). See
    #162147 (comment)
    
    Result of bisecting #162147 to
    #165942
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    
    ---------
    
    Co-authored-by: Gray Mackall <[email protected]>
    gmackall and Gray Mackall authored Jul 7, 2025
    Configuration menu
    Copy the full SHA
    df21e0b View commit details
    Browse the repository at this point in the history
  8. Bump warn and error versions of agp, kotlin and gradle versions in pr…

    …eparation for gradle 9 (#171399)
    
    https://gradle.org/whats-new/gradle-9/ is coming and with it includes
    some deprecated methods. Some like
    #171397 can be fixed by
    annotations and calling new methods. Some like the deprecation of
    minsdkversion on Variant require bumping the minimum versions to be able
    to compile code that will work.
    
    b/368604254
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    reidbaker authored Jul 7, 2025
    Configuration menu
    Copy the full SHA
    84a5ce7 View commit details
    Browse the repository at this point in the history
  9. Reverts "Bump warn and error versions of agp, kotlin and gradle versi…

    …ons in preparation for gradle 9 (#171399)" (#171736)
    
    <!-- start_original_pr_link -->
    Reverts: #171399
    <!-- end_original_pr_link -->
    <!-- start_initiating_author -->
    Initiated by: matanlurey
    <!-- end_initiating_author -->
    <!-- start_revert_reason -->
    Reason for reverting: Many Gradle/Android related tasks are failing
    ([one
    example](https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_mokey%20run_release_test/1347/overview))
    <!-- end_revert_reason -->
    <!-- start_original_pr_author -->
    Original PR Author: reidbaker
    <!-- end_original_pr_author -->
    
    <!-- start_reviewers -->
    Reviewed By: {gmackall}
    <!-- end_reviewers -->
    
    <!-- start_revert_body -->
    This change reverts the following previous change:
    https://gradle.org/whats-new/gradle-9/ is coming and with it includes
    some deprecated methods. Some like
    #171397 can be fixed by
    annotations and calling new methods. Some like the deprecation of
    minsdkversion on Variant require bumping the minimum versions to be able
    to compile code that will work.
    
    b/368604254
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    
    <!-- end_revert_body -->
    
    Co-authored-by: auto-submit[bot] <[email protected]>
    auto-submit[bot] and auto-submit[bot] authored Jul 7, 2025
    Configuration menu
    Copy the full SHA
    9b0f94a View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2025

  1. Configuration menu
    Copy the full SHA
    a554116 View commit details
    Browse the repository at this point in the history
  2. feat: Use engine_stamp.json in flutter tool (#171454)

    The flutter tool will now download and use an `engine_stamp.json` file
    to determine the engine version, content hash, build date, and commit
    date.
    
    The file is treated as a new `DevelopmentArtifact.informative` and is
    fetched before flutterVersion is used. This ensures we have build
    information for a clean checkout with no bin/cache folder. Users that
    download from flutter.dev will have engine_stamp.json, so its a no-op.
    
    This change provides support for content hashed engine artifacts, who's
    revision (the hash) is not a git commit sha. A side benefit is "git" is
    only used at build time to extract this information.
    
    > [!NOTE]
    > Content hashed artifacts are not enabled yet for downloads;
    bin/internal/engine.version (releases) and the shell updaters still look
    for the git commit sha. One can test this out by setting
    `FLUTTER_PREBUILD_ENGINE_VERSION` to the content hash.
    jtmcdole authored Jul 8, 2025
    Configuration menu
    Copy the full SHA
    13d2219 View commit details
    Browse the repository at this point in the history
  3. Roll Skia from ad5c330487f7 to 4968a30d721c (8 revisions) (#171739)

    https://skia.googlesource.com/skia.git/+log/ad5c330487f7..4968a30d721c
    
    2025-07-07 [email protected] use pathbuilder inside stroker
    2025-07-07 [email protected] Remove legacy fontations png code
    2025-07-07 [email protected] Start converting clipsstack to use
    pathbuilder
    2025-07-07 [email protected] Make SkImage->makeSubset take an
    SkRecorder* instead of a graphite recorder
    2025-07-07 [email protected] [graphite] Use ClipStack::Simplify
    for initial draw check
    2025-07-07 [email protected] SkRegion to use pathbuilder
    2025-07-07 [email protected] Fix example in
    external_client/MODULE.bazel
    2025-07-07 [email protected] [graphite] Android-specific
    PaintOptions
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jul 8, 2025
    Configuration menu
    Copy the full SHA
    9aed967 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d01a809 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6bd4019 View commit details
    Browse the repository at this point in the history
  6. Roll Skia from f35536730dea to 36b1f71fc14f (3 revisions) (#171751)

    https://skia.googlesource.com/skia.git/+log/f35536730dea..36b1f71fc14f
    
    2025-07-08 [email protected] Roll Skia
    Infra from 7beaca95d5be to 743562b36d09 (4 revisions)
    2025-07-08 [email protected] Roll Dawn
    from 786d71685ca7 to 0275c582a080 (21 revisions)
    2025-07-08
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jul 8, 2025
    Configuration menu
    Copy the full SHA
    33c96ac View commit details
    Browse the repository at this point in the history
  7. Roll Skia from 36b1f71fc14f to 0669913308d3 (4 revisions) (#171756)

    https://skia.googlesource.com/skia.git/+log/36b1f71fc14f..0669913308d3
    
    2025-07-08
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-07-08 [email protected] Roll ANGLE
    from 8905d531f9d9 to 825b40622cf2 (2 revisions)
    2025-07-08 [email protected] Roll
    vulkan-deps from fd2462093c6e to 242b87cc5bcc (6 revisions)
    2025-07-08
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC
    [email protected],[email protected],[email protected] on the
    revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jul 8, 2025
    Configuration menu
    Copy the full SHA
    8af0596 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    adffe24 View commit details
    Browse the repository at this point in the history
Loading