Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 26bb33b9572b
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: edd434af3e9d
Choose a head ref
  • 14 commits
  • 161 files changed
  • 9 contributors

Commits on Aug 22, 2025

  1. Marks Mac_ios ios_debug_workflow to be unflaky (#174104)

    <!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
    {
      "name": "Mac_ios ios_debug_workflow"
    }
    -->
    The test has been passing for [50 consecutive
    runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20ios_debug_workflow%22).
    This test can be marked as unflaky.
    fluttergithubbot authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    73e39e9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bdea526 View commit details
    Browse the repository at this point in the history
  3. Migrate more files to WidgetStateProperty (#174268)

    Another batch of files migrated to use WidgetStateProperty
    
    Follow up of #174176
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    ValentinVignal authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    f0f208d View commit details
    Browse the repository at this point in the history
  4. [ Widget Preview ] Add support for DevTools configuration (#174272)

    Adds support for the `--devtools-server-address=<uri>` and `--devtools`
    options.
    
    Also fixes an issue where the VM service + DevTools connection
    information was not printed to STDOUT for web devices.
    
    Fixes #173617
    
    ---------
    
    Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
    bkonyi and gemini-code-assist[bot] authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    35eb77f View commit details
    Browse the repository at this point in the history
  5. Roll Packages from 58c02e0 to 092d832 (4 revisions) (#174295)

    flutter/packages@58c02e0...092d832
    
    2025-08-21 [email protected] Roll Flutter from
    960d107 to d2ac021 (12 revisions) (flutter/packages#9866)
    2025-08-21 [email protected] Handle automatic PopScope
    (flutter/packages#9856)
    2025-08-20 [email protected] Manual roll Flutter from
    e65380a to 960d107 (36 revisions) (flutter/packages#9862)
    2025-08-20 [email protected]
    [interactive_media_ads] Updates ProxyApis to prepare to add support for
    `AdEvent.ad` (flutter/packages#9785)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected] on the revert to ensure that a
    human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    62ea199 View commit details
    Browse the repository at this point in the history
  6. Refactor text and runtime effect to separate skia and impeller implem…

    …entations. (#174219)
    
    This makes two refactors to the display list architecture:
    * The concrete implementations of `DlRuntimeEffect` for skia and
    impeller are separated, and the impeller implementation put into the
    `impeller/display_list` target. This makes sure that a client can link
    against the main `display_list` library without actually pulling in all
    of impeller. (This is needed for
    #172314)
    * The `DrawTextBlob` and `DrawTextFrame` methods are consolidated into
    one `DrawText` call, and that takes a `DlText` object. The `DlText`
    object has two implementations, one for skia and one for impeller, and
    the impeller one is moved into `impeller/display_list` for the same
    reason mentioned above.
    eyebrowsoffire authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    a24dbd5 View commit details
    Browse the repository at this point in the history
  7. _downloadArtifacts (Web SDK) uses content-aware hashing in post-sub…

    …mit (#174236)
    
    Towards #174225.
    
    Will need to get cherry-picked into 3.35 and 3.36.
    matanlurey authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    6c7d642 View commit details
    Browse the repository at this point in the history
  8. Roll Skia from cb15e1452399 to ebb6051e8bb1 (5 revisions) (#174296)

    https://skia.googlesource.com/skia.git/+log/cb15e1452399..ebb6051e8bb1
    
    2025-08-22 [email protected] Revert "HDR v2: Change
    SkNamedTransferFn::kHLG/kPQ to new version"
    2025-08-22 [email protected] Image shader + tiny scale GM
    2025-08-22 [email protected] Android NDK font manager variation cache
    2025-08-22 [email protected] FontMgr Android NDK automatic axes
    2025-08-22 [email protected] Roll
    vulkan-deps from 7e28c4c2f184 to d74c51b56a14 (2 revisions)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    5c23f4c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    699f21a View commit details
    Browse the repository at this point in the history
  10. Update some semantics flags updated to use enum (engine, framework, w…

    …eb) (#170696)
    
    issue: #166101,
    
    
    new Updates :
    Add new enum Tristate and CheckedState in  for 7 flags.
    For CheckState, it used to use 3 bools (hasCheck, isChecked,
    isCheckStateMixed) to represent check states, replace them with a
    CheckState enum.
    For other 6 flags, each has 2 bools (hasXXState and isXX), replace them
    with a Tristate enum.
    
    This will be a breaking changes to the SemanticsFlags class , which was
    added in April in #166101 and
    #167771 , will write a breaking
    change doc for this PR
    
    
    
    
    ## Pre-launch Checklist
    
    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [ ] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    hannah-hyj authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    798ff59 View commit details
    Browse the repository at this point in the history
  11. [web] Expose rasterizers in Renderer (#174308)

    This is a small tweak to the Renderer API that exposes a `Rasterizer`
    and a map of `View` to `ViewRasterizer` in the `Renderer`. The
    `Renderer` handles creating and disposing the `ViewRasterizer`s in
    response to `View`s being created and disposed.
    
    This is a step towards #172311
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    harryterkelsen authored Aug 22, 2025
    Configuration menu
    Copy the full SHA
    7d6d410 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2025

  1. Configuration menu
    Copy the full SHA
    905a82f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e64895f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    edd434a View commit details
    Browse the repository at this point in the history
Loading