Comparing changes

…131585) flutter/engine@d95adb9...b84c936 2023-07-30 [email protected] Roll Fuchsia Mac SDK from 17au0GOALWDVfQnwu... to c0Pr9uG-46yC83ZVy... (flutter/engine#44154) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from 17au0GOALWDV to c0Pr9uG-46yC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…131592) flutter/engine@b84c936...22f9aad 2023-07-31 [email protected] Roll Skia from 3febb7d97cb0 to 1146dd2212ba (1 revision) (flutter/engine#44158) 2023-07-31 [email protected] Roll Skia from 0e62d11175aa to 3febb7d97cb0 (1 revision) (flutter/engine#44156) 2023-07-31 [email protected] Roll Fuchsia Linux SDK from 5tPeR3pmLZVAbR1iy... to SqCbKBft29XeD2Qvw... (flutter/engine#44155) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 5tPeR3pmLZVA to SqCbKBft29Xe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…131597) flutter/engine@22f9aad...b11a832 2023-07-31 [email protected] Roll Skia from 91b838fe533d to 6ee21fa70879 (1 revision) (flutter/engine#44160) 2023-07-31 [email protected] Roll Skia from 1146dd2212ba to 91b838fe533d (1 revision) (flutter/engine#44159) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

<img width="1119" alt="image" src="https://github.com/flutter/flutter/assets/66480156/e2e8eed1-3bef-436c-b21f-3891bdbe05bb"> In most cases, a FFI plugin doesn't need its own specific Android NDK version. Just following the Flutter app project's NDK version is enough. If a Flutter app project depends on multiple FFI plugins that use different Android NDK versions, it can be quite wasteful and use excessive disk space due to multiple NDK installations. Using Flutter app project's NDK version is also less error-prone because upgrading the Flutter SDK would be enough when upgrading FFI plugins(If project's `ndkVersion` is `flutter.ndkVersion`), without messing with Android NDK installations. This problem was discussed in some actual FFI plugin repositories, and they are striving to find their own solutions: - superlistapp/super_native_extensions#143 (comment) - cunarist/rinf#60 (comment) - rive-app/rive-flutter#320 - juicycleff/flutter-unity-view-widget#832

…131251) In the legacy VS Code DAP, we would deserialise the Flutter.Error event and provide some basic colouring (eg. stack frames are faded if not from user code and the text is split between stdout/stderr to allow the client to colour it). In the new DAPs we originally used `renderedErrorText` which didn't support either of these. This change adds changes to use the structured data (with some basic parsing because the source classes are in package:flutter and not accessible here) to provide a similar experience. It would be nicer if we could use the real underlying Flutter classes for this deserialisation, but extracting them from `package:flutter` and removing all dependencies on Flutter is a much larger job and I don't think should hold up providing improved error formatting for the new DAPs. Some comparisons: ![1_comparison](https://github.com/flutter/flutter/assets/1078012/74e7e6d6-c8d0-471f-b584-37ae148b0ce7) ![2_comparison](https://github.com/flutter/flutter/assets/1078012/21888934-6f2f-4048-86d7-bdf92d5c7301)

#103529

flutter/packages@10aab44...60e9a54 2023-07-30 [email protected] Manual roll Flutter from c2b40ca to 1d44fbd (7 revisions) (flutter/packages#4592) 2023-07-29 [email protected] Roll Flutter from e81907e to c2b40ca (24 revisions) (flutter/packages#4588) 2023-07-28 [email protected] [ci] Switch FTL to LUCI (flutter/packages#4583) 2023-07-28 [email protected] [go_router_builder] support v10.0.0 go_router (flutter/packages#4578) 2023-07-28 [email protected] Roll Flutter from dd9764e to e81907e (21 revisions) (flutter/packages#4582) 2023-07-28 [email protected] [ci] Add LUCI version of Android FTL tests in bringup mode (flutter/packages#4571) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…131611) flutter/engine@b11a832...ae6d1d6 2023-07-31 [email protected] Roll ANGLE from 143fa68f50b7 to fb37e0542c7c (1 revision) (flutter/engine#44161) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) Partially fixes/related to: #131425

…131614) flutter/engine@ae6d1d6...b83172a 2023-07-31 [email protected] Roll Fuchsia Mac SDK from c0Pr9uG-46yC83ZVy... to Dd4To9QyMtoPGPIpl... (flutter/engine#44168) 2023-07-31 [email protected] Roll ANGLE from fb37e0542c7c to 2755f73a3461 (1 revision) (flutter/engine#44167) 2023-07-31 [email protected] Roll Fuchsia Linux SDK from SqCbKBft29XeD2Qvw... to wIpcCOc0TtDYasQbl... (flutter/engine#44166) 2023-07-31 [email protected] Roll Skia from 6ee21fa70879 to cb61dd4af8a5 (1 revision) (flutter/engine#44165) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from SqCbKBft29Xe to wIpcCOc0TtDY fuchsia/sdk/core/mac-amd64 from c0Pr9uG-46yC to Dd4To9QyMtoP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Reverts #131368 Original PR: #131292 . The flutter mirror was out of date and tree was closed, so the original PR was reverted. Now should be safe to have a reland.

Updating the cirrus key. *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

Because the cost of type checks dominate our dart2wasm benchmarks, we've decided to pass `--omit-type-checks` for now. This was previously reverted because the skwasm benchmarks were broken in general for a separate reason, and my getting rid of `bringup: true` broke the tree. I ended up fixing the benchmarks and getting rid of `bringup: true` in a separate commit, so this just adds the flag only.

…131363)

@stuartmorgan

Added Regex to match error message from verbos build as suggested by @stuartmorgan [here](#98137 (comment)). Modified Windows Build Test Fixes #97065

Fixed code for the Uri as it includes the period at the end as the part of Uri parsing previously. As for example: ``` A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log. ``` Many terminals are unable to follow the link because it includes the period in the end as part of it. This PR simply removes the period in the end so that it is clickable in many systems (e.g. by `alt` -clicking on it in an embedded bash terminal, VSCode). ``` A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log ``` Fixes: #131166

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comparing changes

Open a pull request

Commits on Jul 31, 2023

This comparison is taking too long to generate.

Uh oh!