-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: 15f95ce0c38e
head repository: flutter/flutter
compare: 651a17db5427
- 7 commits
- 11 files changed
- 6 contributors
Commits on Jun 28, 2024
-
Roll Flutter Engine from 94591ffb20df to a78f5ce743ce (1 revision) (#…
…150972) flutter/engine@94591ff...a78f5ce 2024-06-28 [email protected] Roll Dart SDK from e7022f6eb6c9 to 0820b0766ac9 (1 revision) (flutter/engine#53623) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for ed8dde8 - Browse repository at this point
Copy the full SHA ed8dde8View commit details -
[flutter_tools] Include more details in structured errors sent to a D…
…AP client (#150698) The debug adapter converts Flutter's structured errors into a text format to be sent to the debug client and shown in the console. When an error is not the first error since the last reload, it is shown as just a summary (since it may be caused by a prior error). In this mode, the filter was causing some important information (the erroring widget) to be omitted. This tweaks the logic to include child nodes of a `DiagnosticBlock` in this mode. Fixes Dart-Code/Dart-Code#4743 ## Before:  ## After: 
Configuration menu - View commit details
-
Copy full SHA for eb58fe1 - Browse repository at this point
Copy the full SHA eb58fe1View commit details -
Roll Packages from 03f5f6d to 412ec46 (12 revisions) (#150985)
flutter/packages@03f5f6d...412ec46 2024-06-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.6 to 3.25.10 (flutter/packages#6924) 2024-06-27 [email protected] [video_player] Exposes VideoPlayerWebOptions. (flutter/packages#6990) 2024-06-27 [email protected] [ci] Add Wasm compilation to all_packages web app. (flutter/packages#6981) 2024-06-27 [email protected] [interactive_media_ads] Updates `README` with a usage section and fix some interface docs (flutter/packages#6988) 2024-06-27 [email protected] [tools] Fix vm test requirement (flutter/packages#6995) 2024-06-27 [email protected] Update `web_benchmarks` package to properly support wasm. (flutter/packages#6970) 2024-06-27 [email protected] [pigeon] Implement equals for Java data classes (flutter/packages#6992) 2024-06-25 [email protected] Final refactor of `video_player_android` before `SurfaceProducer#setCallback`. (flutter/packages#6982) 2024-06-25 [email protected] [pigeon] Update testing and docs (flutter/packages#6984) 2024-06-25 [email protected] [various] Update flutter.dev links to more reliable destinations (flutter/packages#6963) 2024-06-25 [email protected] [interactive_media_ads] Adds initial Android implementation (flutter/packages#6733) 2024-06-25 [email protected] Roll Flutter from 6c06abb to e726eb4 (51 revisions) (flutter/packages#6987) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 9e1efd8 - Browse repository at this point
Copy the full SHA 9e1efd8View commit details -
Use caret syntax with flutter create command (#150920)
The Pull Request changes the `dartSdkVersionBounds` value, which gets templated into the `pubspec.yaml` from the `flutter create`: https://github.com/flutter/flutter/blob/ffdeaa1995efc1fe7d759e13b92eba1ec57beea6/packages/flutter_tools/templates/app/pubspec.yaml.tmpl#L8 As from the Dart dependencies ["Best practices"](https://dart.dev/tools/pub/dependencies#use-caret-syntax) section of the documentation: > Use caret syntax Specify dependencies using the [caret syntax](https://dart.dev/tools/pub/dependencies#caret-syntax). This allows the pub tool to select newer versions of the package when they become available. Further, it places an upper bound on the allowed version. To learn more about the Caret syntax, refer to the [Caret syntax documentation](https://github.com/flutter/flutter/blob/ffdeaa1995efc1fe7d759e13b92eba1ec57beea6/packages/flutter_tools/templates/app/pubspec.yaml.tmpl#L8). **Additional context** - VGVentures/io_crossword#592 (comment) (cc: @kevmoo) - [Very Good Templates](https://github.com/VeryGoodOpenSource/very_good_templates) relies on the Caret syntax when templating the Dart SDK
Configuration menu - View commit details
-
Copy full SHA for 47e65e8 - Browse repository at this point
Copy the full SHA 47e65e8View commit details -
Add support for type-safe plugin apply (#150958)
The Gradle Kotlin DSL also allows for type-safe application of the Flutter Gradle plugin, which is currently undetected by the CLI ```kotlin plugins { dev.flutter.`flutter-gradle-plugin` } ``` Please note that the added test case isn't ideal, since the example gradle isn't actually valid kotlin DSL, however the `kotlin host app language with Gradle Kotlin DSL` is identical Fixes #149859Configuration menu - View commit details
-
Copy full SHA for 3a97a38 - Browse repository at this point
Copy the full SHA 3a97a38View commit details -
Draggable feedback positioning (#149040)
Reopened after revert in #147658 Another test was added in the meantime to `draggable_test.dart` that didn't call `gesture.up()`. I added this call to the test and now all tests pass. --- # Original Description (#145647): We changed the coordinates used to position the `Draggable` feedback by transforming them into the `Overlay`s coordinate space. This has no influence on any untransformed `Overlay`, most Flutter apps should be not affected. This PR fixes the positioning of the feedback in transformed context (see #145639 for before video): https://github.com/flutter/flutter/assets/42270125/df34e198-0667-453d-a27a-a79b2e2825a1 - fixes #145639 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [Data Driven Fixes]: https://github.com/flutter/flutter/wiki/Data-driven-Fixes --------- Co-authored-by: Jesper Bellenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f5b671a - Browse repository at this point
Copy the full SHA f5b671aView commit details -
Roll Flutter Engine from a78f5ce743ce to 2f7e9ab27493 (11 revisions) (#…
…151002) flutter/engine@a78f5ce...2f7e9ab 2024-06-28 [email protected] Roll Skia from 7a09d38fa7f8 to 3d5f5d546fb6 (1 revision) (flutter/engine#53634) 2024-06-28 [email protected] Roll Skia from 23a14cccc800 to 7a09d38fa7f8 (1 revision) (flutter/engine#53633) 2024-06-28 [email protected] Roll Skia from cd77153f20a8 to 23a14cccc800 (1 revision) (flutter/engine#53631) 2024-06-28 [email protected] Revert "[DisplayList] Add support for clipOval to leverage Impeller optimization" (flutter/engine#53629) 2024-06-28 [email protected] Roll Dart SDK from 4005e5f1fb8e to 341dbaf977a3 (1 revision) (flutter/engine#53630) 2024-06-28 [email protected] Roll Skia from 6650fcc6d054 to cd77153f20a8 (1 revision) (flutter/engine#53628) 2024-06-28 [email protected] Roll Skia from 2204428a75ca to 6650fcc6d054 (2 revisions) (flutter/engine#53627) 2024-06-28 [email protected] Roll Dart SDK from 0820b0766ac9 to 4005e5f1fb8e (1 revision) (flutter/engine#53626) 2024-06-28 [email protected] Roll Skia from 1700e3962acd to 2204428a75ca (1 revision) (flutter/engine#53625) 2024-06-28 [email protected] Roll Fuchsia Linux SDK from gBWzGuicxu76K82lg... to H_P7EHb4zXXV-Eiik... (flutter/engine#53624) 2024-06-28 [email protected] [DisplayList] Add support for clipOval to leverage Impeller optimization (flutter/engine#53622) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from gBWzGuicxu76 to H_P7EHb4zXXV If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 651a17d - Browse repository at this point
Copy the full SHA 651a17dView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 15f95ce0c38e...651a17db5427