-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: 15cb1f84d726
head repository: flutter/flutter
compare: 42fb0b23139c
- 19 commits
- 37 files changed
- 12 contributors
Commits on Apr 17, 2023
-
SelectionContainer's listeners can remove itself during listener call… (
#124624) When swapping out delegate of selectioncontainer, if the newly passed in delegate doesn't have any selectable content(which is usually the case), the selectioncontainerstate will notify all of the listeners. One of the listener would be SelectionRegistrant._updateSelectionRegistrarSubscription, and since it doesn't have content, it would remove itself from the listener which causes concurrent modification
Configuration menu - View commit details
-
Copy full SHA for cc9ffd3 - Browse repository at this point
Copy the full SHA cc9ffd3View commit details -
Add an example for SearchBar (#124992)
This PR is to: * Update API doc for `SearchBar`. * Add an example to show how to use a `SearchBar` as the builder of the `SearchAnchor`.
Configuration menu - View commit details
-
Copy full SHA for 6e85113 - Browse repository at this point
Copy the full SHA 6e85113View commit details -
Roll Flutter Engine from b2d07388ceb6 to 20034a8d62c4 (7 revisions) (#…
…125001) flutter/engine@b2d0738...20034a8 2023-04-17 [email protected] Reland "Migrate mac_host_engine to engine v2 builds." (flutter/engine#41279) 2023-04-17 [email protected] [rotation_distortion] Use "delayed swap" solution to reduce rotation distortion (flutter/engine#40730) 2023-04-17 [email protected] null check added to avoid NPE while calling FlutterView.detachFromFlutterEngine() (flutter/engine#41082) 2023-04-17 [email protected] [Impeller] Make `DoMakeRasterSnapshot` output timeline event. (flutter/engine#41197) 2023-04-17 [email protected] [Impeller] Remove ContentContextOptions declarations from AnonymousContents (flutter/engine#41256) 2023-04-17 [email protected] Roll Dart SDK from 786a70d8ef6b to a335e6724332 (1 revision) (flutter/engine#41278) 2023-04-17 [email protected] Roll Fuchsia Linux SDK from atix5Ek_OOxH-uoPA... to Cy5LG4U2InaFLkJGz... (flutter/engine#41275) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from atix5Ek_OOxH to Cy5LG4U2InaF If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 67a84e6 - Browse repository at this point
Copy the full SHA 67a84e6View commit details -
Add Harish Anbalagan to AUTHORS (#124684)
Adding my name (Harish Anbalagan) to Authors.
Configuration menu - View commit details
-
Copy full SHA for 0ac1813 - Browse repository at this point
Copy the full SHA 0ac1813View commit details -
Update usage of standalone
pubexecutable in flutter_tools testing d……ocs (#124898) Just found this while trying to run the integration test shard of `flutter_tools` locally :)
Configuration menu - View commit details
-
Copy full SHA for e99eb40 - Browse repository at this point
Copy the full SHA e99eb40View commit details
Commits on Apr 18, 2023
-
Add optional axis specifier to static scrollable methods (#124894)
This is motivated by part of the 2D scrolling proposal: [flutter.dev/go/2D-Foundation](https://flutter.dev/go/2D-Foundation) This is one of the last little PRs to prep for the 2D scrolling foundation. This adds an optional `axis` parameter to the static Scrollable methods `[of, maybeOf, recommendDeferredLoadingForContext]`. This allows developers that are nesting scrollables (or one day using 2D scrolling) to look them up instead by a particular axis. In general, even outside the context of 2D, I think this is helpful. I am often asked how to get the outer scrollable when nesting. Now it can be done. There is also a small semantic refactor here in ScrollableState.build, this just creates a private method (_buildChrome) that will be overridden in 2D later. It is easier to add now than in the really big PR that will be.
Configuration menu - View commit details
-
Copy full SHA for e867d1c - Browse repository at this point
Copy the full SHA e867d1cView commit details -
Roll Flutter Engine from 20034a8d62c4 to 4a603aaff32e (2 revisions) (#…
…125004) flutter/engine@20034a8...4a603aa 2023-04-17 [email protected] Remove 'Mac mac_unopt' in favor of Linux (flutter/engine#41226) 2023-04-17 [email protected] [Impeller] Add debug ToString methods to render targets. (flutter/engine#41221) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 9cc5f55 - Browse repository at this point
Copy the full SHA 9cc5f55View commit details -
Roll Flutter Engine from 4a603aaff32e to c4396f9f602f (2 revisions) (#…
…125007) flutter/engine@4a603aa...c4396f9 2023-04-17 [email protected] Roll impeller-cmake-example to 58042bb24833a3cbd615ad082b1d17daef42d097 (flutter/engine#41280) 2023-04-17 [email protected] Reland ui_web files in sky_engine (flutter/engine#41169) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 4075503 - Browse repository at this point
Copy the full SHA 4075503View commit details -
relayout active ListWheelScrollView children every performLayout (#12…
Configuration menu - View commit details
-
Copy full SHA for 3ba249a - Browse repository at this point
Copy the full SHA 3ba249aView commit details -
[InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFor…
…mField Widget (#124143) Adds `acceptEmptyDate` property to `InputDatePickerFormField`. Fixes: #117511 | `acceptEmptyDate` is **false** | `acceptEmptyDate` is **true** | | --- | ---| |  |  |
Configuration menu - View commit details
-
Copy full SHA for 5de716f - Browse repository at this point
Copy the full SHA 5de716fView commit details -
This PR was generated by `flutter update-packages --force-upgrade`.
Configuration menu - View commit details
-
Copy full SHA for b0346b2 - Browse repository at this point
Copy the full SHA b0346b2View commit details -
Roll Flutter Engine from c4396f9f602f to d2973619074e (6 revisions) (#…
…125039) flutter/engine@c4396f9...d297361 2023-04-18 [email protected] [macOS] Fix Ctrl+Tab is broken (flutter/engine#40706) 2023-04-18 [email protected] Roll Fuchsia Mac SDK from K1LGtKXyxRlW3Q9O1... to qZHSvkpAU1-YYGvYc... (flutter/engine#41293) 2023-04-18 [email protected] Roll buildroot to 059d155b4d452efd9c4427c45cddfd9445144869 (flutter/engine#41288) 2023-04-18 [email protected] [Impeller] Remove glyph pixel rounding during text frame conversion (flutter/engine#41285) 2023-04-18 [email protected] Revert "Reland "Migrate mac_host_engine to engine v2 builds."" (flutter/engine#41284) 2023-04-17 [email protected] focus SkiaGPUObject wrappers on only those objects that need the protection (flutter/engine#41237) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from K1LGtKXyxRlW to qZHSvkpAU1-Y If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for ec02eb3 - Browse repository at this point
Copy the full SHA ec02eb3View commit details -
Roll Packages from 0277f2a to faf53fb (7 revisions) (#125040)
flutter/packages@0277f2a...faf53fb 2023-04-18 [email protected] Manual roll Flutter from 50171bb to 15cb1f8 (9 revisions) (flutter/packages#3749) 2023-04-17 [email protected] [palette_generator] run agp update for example (flutter/packages#3747) 2023-04-17 [email protected] [go_router] Fixes a bug that go_router would crash if pageBuilder depends on InheritedWidgets.s. (flutter/packages#3714) 2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump com.android.tools.build:gradle from 7.3.1 to 8.0.0 in /packages/pigeon/platform_tests/alternate_language_test_plugin/android (flutter/packages#3727) 2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump com.android.tools.build:gradle from 7.3.1 to 8.0.0 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3726) 2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.4 to 1.13.5 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3725) 2023-04-17 [email protected] [tool] Add initial gradle validation command (flutter/packages#3715) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for a9ffc16 - Browse repository at this point
Copy the full SHA a9ffc16View commit details -
Stop running "_impeller_" benchmark variants (#125044)
Impeller is now the default on iOS, so these are redundant. In a subsequent change, I'll clean up the source files for these.
Configuration menu - View commit details
-
Copy full SHA for c31467f - Browse repository at this point
Copy the full SHA c31467fView commit details -
Roll Flutter Engine from d2973619074e to 55bb065c607b (1 revision) (#…
…125047) flutter/engine@d297361...55bb065 2023-04-18 [email protected] [fuchsia] migrate touch-input integration tests to gfx scene manager test ui stack (flutter/engine#41118) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for f7245b6 - Browse repository at this point
Copy the full SHA f7245b6View commit details -
iOS spell check cursor placement (#124875)
Fixes the cursor location after selecting a spell check result on iOS.
Configuration menu - View commit details
-
Copy full SHA for 39becb7 - Browse repository at this point
Copy the full SHA 39becb7View commit details -
Remove unused context parameter (#124254)
Tidying up the spell check API.
Configuration menu - View commit details
-
Copy full SHA for 9d68831 - Browse repository at this point
Copy the full SHA 9d68831View commit details -
Update the copy icon in snippets and samples to use the standard one (#…
…123651) ## Description This updates the copy icon for copying sample code to use `content_copy` instead of `assignment`. Before: <img width="369" alt="223876418-2470c4c5-abfc-4511-9762-1fd0b6e05903" src="https://user-images.githubusercontent.com/8867023/228396142-450125ee-d8cf-4ede-8545-5920eb0da99d.png"> After: <img width="408" alt="image" src="https://user-images.githubusercontent.com/8867023/228395959-8531704a-77aa-43af-9dcf-7456bb2ed090.png"> ## Related Issues - Fixes #122246 ## Tests - No tests needed.
Configuration menu - View commit details
-
Copy full SHA for d4e1209 - Browse repository at this point
Copy the full SHA d4e1209View commit details -
Fix text theme dart fix cases (#125052)
Fixes #125049 This is blocking the dart roll, dart fix will now fix some invalid code that was in these test cases. These test case files are un-analyzed intentionally because they are by nature samples of broken code.
Configuration menu - View commit details
-
Copy full SHA for 42fb0b2 - Browse repository at this point
Copy the full SHA 42fb0b2View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 15cb1f84d726...42fb0b23139c