Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 15cb1f84d726
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 42fb0b23139c
Choose a head ref
  • 19 commits
  • 37 files changed
  • 12 contributors

Commits on Apr 17, 2023

  1. SelectionContainer's listeners can remove itself during listener call… (

    #124624)
    
    When swapping out delegate of  selectioncontainer, if the newly passed in delegate doesn't have any selectable content(which is usually the case), the selectioncontainerstate will notify all of the listeners. One of the listener would be SelectionRegistrant._updateSelectionRegistrarSubscription, and since it doesn't have content, it would remove itself from the listener which causes concurrent modification
    chunhtai authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    cc9ffd3 View commit details
    Browse the repository at this point in the history
  2. Add an example for SearchBar (#124992)

    This PR is to: 
    * Update API doc for `SearchBar`.
    * Add an example to show how to use a `SearchBar` as the builder of the `SearchAnchor`.
    QuncCccccc authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    6e85113 View commit details
    Browse the repository at this point in the history
  3. Roll Flutter Engine from b2d07388ceb6 to 20034a8d62c4 (7 revisions) (#…

    …125001)
    
    flutter/engine@b2d0738...20034a8
    
    2023-04-17 [email protected] Reland  "Migrate mac_host_engine to engine v2 builds." (flutter/engine#41279)
    2023-04-17 [email protected] [rotation_distortion] Use "delayed swap" solution to reduce rotation distortion (flutter/engine#40730)
    2023-04-17 [email protected] null check added to avoid NPE while calling FlutterView.detachFromFlutterEngine() (flutter/engine#41082)
    2023-04-17 [email protected] [Impeller] Make `DoMakeRasterSnapshot` output timeline event. (flutter/engine#41197)
    2023-04-17 [email protected] [Impeller] Remove ContentContextOptions declarations from AnonymousContents (flutter/engine#41256)
    2023-04-17 [email protected] Roll Dart SDK from 786a70d8ef6b to a335e6724332 (1 revision) (flutter/engine#41278)
    2023-04-17 [email protected] Roll Fuchsia Linux SDK from atix5Ek_OOxH-uoPA... to Cy5LG4U2InaFLkJGz... (flutter/engine#41275)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from atix5Ek_OOxH to Cy5LG4U2InaF
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    67a84e6 View commit details
    Browse the repository at this point in the history
  4. Add Harish Anbalagan to AUTHORS (#124684)

    Adding my name (Harish Anbalagan) to Authors.
    Harishwarrior authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    0ac1813 View commit details
    Browse the repository at this point in the history
  5. Update usage of standalonepub executable in flutter_tools testing d…

    …ocs (#124898)
    
    Just found this while trying to run the integration test shard of `flutter_tools` locally :)
    bartekpacia authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    e99eb40 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Add optional axis specifier to static scrollable methods (#124894)

    This is motivated by part of the 2D scrolling proposal: [flutter.dev/go/2D-Foundation](https://flutter.dev/go/2D-Foundation)
    
    This is one of the last little PRs to prep for the 2D scrolling foundation. 
    This adds an optional `axis` parameter to the static Scrollable methods `[of, maybeOf, recommendDeferredLoadingForContext]`. This allows developers that are nesting scrollables (or one day using 2D scrolling) to look them up instead by a particular axis.
    
    In general, even outside the context of 2D, I think this is helpful. I am often asked how to get the outer scrollable when nesting. Now it can be done.
    
    There is also a small semantic refactor here in ScrollableState.build, this just creates a private method (_buildChrome) that will be overridden in 2D later. It is easier to add now than in the really big PR that will be.
    Piinks authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    e867d1c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9cc5f55 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4075503 View commit details
    Browse the repository at this point in the history
  4. relayout active ListWheelScrollView children every performLayout (#12…

    …4476)
    
    during performLayout, active children's constraints were updated, but they weren't laid out again w.r.t their parent (ListWheelScrollView).
    
    Fixes #123497
    werainkhatri authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    3ba249a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5de716f View commit details
    Browse the repository at this point in the history
  6. Roll pub packages (#125005)

    This PR was generated by `flutter update-packages --force-upgrade`.
    fluttergithubbot authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    b0346b2 View commit details
    Browse the repository at this point in the history
  7. Roll Flutter Engine from c4396f9f602f to d2973619074e (6 revisions) (#…

    …125039)
    
    flutter/engine@c4396f9...d297361
    
    2023-04-18 [email protected] [macOS] Fix Ctrl+Tab is broken
    (flutter/engine#40706)
    2023-04-18 [email protected] Roll Fuchsia Mac SDK from
    K1LGtKXyxRlW3Q9O1... to qZHSvkpAU1-YYGvYc... (flutter/engine#41293)
    2023-04-18 [email protected] Roll buildroot to
    059d155b4d452efd9c4427c45cddfd9445144869 (flutter/engine#41288)
    2023-04-18 [email protected] [Impeller] Remove glyph pixel rounding
    during text frame conversion (flutter/engine#41285)
    2023-04-18 [email protected] Revert "Reland "Migrate mac_host_engine
    to engine v2 builds."" (flutter/engine#41284)
    2023-04-17 [email protected] focus SkiaGPUObject wrappers on only those
    objects that need the protection (flutter/engine#41237)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/mac-amd64 from K1LGtKXyxRlW to qZHSvkpAU1-Y
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    ec02eb3 View commit details
    Browse the repository at this point in the history
  8. Roll Packages from 0277f2a to faf53fb (7 revisions) (#125040)

    flutter/packages@0277f2a...faf53fb
    
    2023-04-18 [email protected] Manual roll Flutter from 50171bb to 15cb1f8 (9 revisions) (flutter/packages#3749)
    2023-04-17 [email protected] [palette_generator] run agp update for example (flutter/packages#3747)
    2023-04-17 [email protected] [go_router] Fixes a bug that go_router would crash if pageBuilder depends on InheritedWidgets.s. (flutter/packages#3714)
    2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump com.android.tools.build:gradle from 7.3.1 to 8.0.0 in /packages/pigeon/platform_tests/alternate_language_test_plugin/android (flutter/packages#3727)
    2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump com.android.tools.build:gradle from 7.3.1 to 8.0.0 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3726)
    2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.4 to 1.13.5 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3725)
    2023-04-17 [email protected] [tool] Add initial gradle validation command (flutter/packages#3715)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    a9ffc16 View commit details
    Browse the repository at this point in the history
  9. Stop running "_impeller_" benchmark variants (#125044)

    Impeller is now the default on iOS, so these are redundant.
    
    In a subsequent change, I'll clean up the source files for these.
    zanderso authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    c31467f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f7245b6 View commit details
    Browse the repository at this point in the history
  11. iOS spell check cursor placement (#124875)

    Fixes the cursor location after selecting a spell check result on iOS.
    justinmc authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    39becb7 View commit details
    Browse the repository at this point in the history
  12. Remove unused context parameter (#124254)

    Tidying up the spell check API.
    justinmc authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    9d68831 View commit details
    Browse the repository at this point in the history
  13. Update the copy icon in snippets and samples to use the standard one (#…

    …123651)
    
    ## Description
    
    This updates the copy icon for copying sample code to use `content_copy` instead of `assignment`.
    Before:
    <img width="369" alt="223876418-2470c4c5-abfc-4511-9762-1fd0b6e05903" src="https://user-images.githubusercontent.com/8867023/228396142-450125ee-d8cf-4ede-8545-5920eb0da99d.png">
    
    After:
    <img width="408" alt="image" src="https://user-images.githubusercontent.com/8867023/228395959-8531704a-77aa-43af-9dcf-7456bb2ed090.png">
    
    ## Related Issues
     - Fixes #122246
    
    ## Tests
     - No tests needed.
    gspencergoog authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    d4e1209 View commit details
    Browse the repository at this point in the history
  14. Fix text theme dart fix cases (#125052)

    Fixes #125049
    
    This is blocking the dart roll, dart fix will now fix some invalid code that was in these test cases. These test case files are un-analyzed intentionally because they are by nature samples of broken code.
    Piinks authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    42fb0b2 View commit details
    Browse the repository at this point in the history
Loading