Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 11def8eff455
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ede594f8816f
Choose a head ref
  • 17 commits
  • 40 files changed
  • 13 contributors

Commits on Dec 21, 2023

  1. Configuration menu
    Copy the full SHA
    430254e View commit details
    Browse the repository at this point in the history
  2. Reland: "Fix how Gradle resolves Android plugin" (#137115)

    Relands #97823
    
    When the tool migrated to `.flutter-plugins-dependencies`, the Gradle plugin was never changed.
    Until now, the plugin had the heuristic that a plugin with a `android/build.gradle` file supported the Android platform.
    
    Also applies schema of `getPluginDependencies` to `getPluginList` which uses a `List` of Object instead of `Properties`.
    
    Fixes #97729
    Cause of the error: https://github.com/flutter/flutter/blob/5f105a6ca7a5ac7b8bc9b241f4c2d86f4188cf5c/packages/flutter_tools/gradle/flutter.gradle#L421C25-L421C25
    
    Fixes #98048
    The deprecated line `include ":$name"` in `settings.gradle` (pluginEach) in old projects causes the `project.rootProject.findProject` to also find the plugin "project", so it is not failing on the `afterEvaluate` method. But the plugin shouldn't be included in the first place as it fails with `Could not find method implementation() for arguments` error in special cases.
    
    Related to #48918, see [_writeFlutterPluginsListLegacy](https://github.com/flutter/flutter/blob/27bc1cf61a5b54bf655062be63050123abb617e4/packages/flutter_tools/lib/src/flutter_plugins.dart#L248).
    
    Co-authored-by: Emmanuel Garcia <[email protected]>
    Gustl22 and Emmanuel Garcia authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    f5ac225 View commit details
    Browse the repository at this point in the history
  3. Reverts "[web] Re-enable test now that source of flakiness is fixed" (#…

    …140515)
    
    Reverts #140462
    Initiated by: cbracken
    This change reverts the following previous change:
    Original Description:
    The test was flaky before due to overflowing GPU memory during the test. The memory leak was fixed here flutter/engine#49214
    
    Fixes #137669
    
    As a side effect of the fix, this test also runs much faster, from about 3 minutes on my Macbook down to about 25 seconds.
    auto-submit[bot] authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    cb50d4a View commit details
    Browse the repository at this point in the history
  4. Add send_text_input_action case to deserialization_factory to allow s…

    …endTextInputAction usages through flutter_driver. (#139197)
    
    **As a follow up to #131776
    
    **Summary:**
    Previously in #106561, SendTextInputAction was added to Flutter Driver.
    But it still cannot be used from flutter_driver tests. This PR intends to resolve that issue.
    
    **Issue:**
    An `DriverError: Unsupported command kind send_text_input_action` would be thrown from `flutter_driver/lib/src/common/deserialization_factory.dart` when a call to `driver.sendTextInputAction(TextInputAction.done);` was made despite the method `sendTextInputAction` is available for use since #106561.
    
    Previous works has been done in #131776, I merely added tests.
    
    Best regards.
    nonvachara-paloit authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    90badf7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    674fbd2 View commit details
    Browse the repository at this point in the history
  6. Enable android_preview_tool_integration_tests check (#140470)

    Enables the check that was added in #131901.
    
    Has been passing since #140099 (30 runs). Not sure what the normal number of successful runs we wait for is before enabling, let me know if we should wait for more data.
    gmackall authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    a3e0fa5 View commit details
    Browse the repository at this point in the history
  7. Fix flavor conditional asset bundling for macos (#140433)

    Fixes #140430
    Fixes #140432 while we are at it
    andrewkolos authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    9e104eb View commit details
    Browse the repository at this point in the history
  8. Make tests more resilient to Skia gold failures and refactor flutter_…

    …goldens for extensive technical debt removal (#140101)
    
    Originally landed in #139549
    Originally reverted in #140085
    
    - Remove all use of global variables.
    - Always pass in all dependencies, only create them in main or in tests.
    - Pass in the "print" primitive.
    - Make all network traffic retry (except when run locally, when it just auto-passes).
    - Enable tests to be run in random order.
    - Better error messages
    Hixie authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    62f1594 View commit details
    Browse the repository at this point in the history
  9. Run mac staging tests with Xcode 15 (#140518)

    Run macOS staging tests with Xcode 15 and macOS 13. Also, cleanup some comments.
    vashworth authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    2da1ff2 View commit details
    Browse the repository at this point in the history
  10. Roll pub packages (#140525)

    This PR was generated by `flutter update-packages --force-upgrade`.
    flutter-pub-roller-bot authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    9c2a756 View commit details
    Browse the repository at this point in the history
  11. Roll Flutter Engine from c70f0a495ace to 1b1b2a12a597 (32 revisions) (#…

    …140519)
    
    Roll Flutter Engine from c70f0a495ace to 1b1b2a12a597 (32 revisions)
    
    flutter/engine@c70f0a4...1b1b2a1
    
    2023-12-21 [email protected] Roll Dart SDK from 4a10533a4dc8 to bcf68d22f0fa (1 revision) (flutter/engine#49329)
    2023-12-21 [email protected] Roll Dart SDK from 1d0c3ecd1349 to 4a10533a4dc8 (1 revision) (flutter/engine#49326)
    2023-12-21 [email protected] Ensure sorted rects in ui.Canvas for legacy compatibility (flutter/engine#49309)
    2023-12-21 [email protected] Roll Dart SDK from 63a452b45026 to 1d0c3ecd1349 (1 revision) (flutter/engine#49318)
    2023-12-21 [email protected] [Impeller] Make IPLR files multi-platform (flutter/engine#49253)
    2023-12-21 [email protected] [web] Defer injection of platform views until needed. (flutter/engine#48960)
    2023-12-21 [email protected] Roll Dart SDK from 1aef027ec953 to 63a452b45026 (2 revisions) (flutter/engine#49311)
    2023-12-21 [email protected] Roll Skia from 29917d8c97ca to 4b16117e94b2 (4 revisions) (flutter/engine#49310)
    2023-12-21 [email protected] Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49262)
    2023-12-21 [email protected] Reland `[Impeller] new blur: refactored math and fixed expanded padding size` (flutter/engine#49302)
    2023-12-20 [email protected] Multiview pipeline Pt. 1: Skip illegal render calls (flutter/engine#49266)
    2023-12-20 [email protected] SemanticsUpdateBuilder: make all args non-null (flutter/engine#49148)
    2023-12-20 [email protected] [Impeller] fixed Rect::Contains (flutter/engine#49294)
    2023-12-20 [email protected] Roll Dart SDK from 97c3b7e1885a to 1aef027ec953 (1 revision) (flutter/engine#49295)
    2023-12-20 [email protected] Revert "[Impeller] new blur: refactored math and fixed expanded padding size" (flutter/engine#49298)
    2023-12-20 [email protected] [Impeller] new blur: refactored math and fixed expanded padding size (flutter/engine#49206)
    2023-12-20 [email protected] Multi-view pointer event (flutter/engine#46213)
    2023-12-20 [email protected] [web:multiview] Only call `Renderer.clearFragmentProgramCache` on hot restart (flutter/engine#48758)
    2023-12-20 [email protected] Roll Skia from 9cb1bb1164ea to 29917d8c97ca (1 revision) (flutter/engine#49289)
    2023-12-20 [email protected] [Impeller] Add interactive Blur+Clip AiksTest. (flutter/engine#49283)
    2023-12-20 [email protected] [macos] FlutterKeyboardManager memory leak fix (flutter/engine#48824)
    2023-12-20 [email protected] Don't guard Windows arm64 Dart SDK download on the release candidate flag (flutter/engine#49244)
    2023-12-20 [email protected] Fix testAppExtensionLaunching for Xcode 15/iOS 17 (flutter/engine#49242)
    2023-12-20 [email protected] Roll Skia from 8060d6b36066 to 9cb1bb1164ea (2 revisions) (flutter/engine#49288)
    2023-12-20 [email protected] Roll Dart SDK from ed415d966d8a to 97c3b7e1885a (1 revision) (flutter/engine#49287)
    2023-12-20 [email protected] Roll Skia from d0f09ad481f7 to 8060d6b36066 (1 revision) (flutter/engine#49285)
    2023-12-20 [email protected] [release] Update release config (flutter/engine#49254)
    2023-12-20 [email protected] Roll Dart SDK from 1732c4c92ccd to ed415d966d8a (1 revision) (flutter/engine#49274)
    2023-12-20 [email protected] Roll Dart SDK from 4c59838945d9 to 1732c4c92ccd (1 revision) (flutter/engine#49269)
    2023-12-20 [email protected] Sync lints with flutter/flutter (flutter/engine#49192)
    2023-12-19 [email protected] [web] Enforce onDrawFrame/onBeginFrame render rule (flutter/engine#49214)
    2023-12-19 [email protected] [Docs] Add more info about running tests on iOS (flutter/engine#48859)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    ...
    engine-flutter-autoroll authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    b417fb8 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Roll Flutter Engine from 1b1b2a12a597 to 737e6f8ce85e (5 revisions) (#…

    …140527)
    
    flutter/engine@1b1b2a1...737e6f8
    
    2023-12-21 [email protected] Roll Dart SDK from bcf68d22f0fa to fe94d9b88531 (1 revision) (flutter/engine#49343)
    2023-12-21 [email protected] Reland "[web] Enforce onDrawFrame/onBeginFrame render rule" (flutter/engine#49336)
    2023-12-21 [email protected] Turn on scenario app screenshots (flutter/engine#49066)
    2023-12-21 [email protected] Revert onrender change (flutter/engine#49333)
    2023-12-21 [email protected] [web] autofocus in new routes (flutter/engine#47727)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 22, 2023
    Configuration menu
    Copy the full SHA
    08e58ba View commit details
    Browse the repository at this point in the history
  2. [web] unskip canvaskit tests that pass now (#140480)

    Unskip a few CanvasKit tests that pass now.
    yjbanov authored Dec 22, 2023
    Configuration menu
    Copy the full SHA
    c02ace6 View commit details
    Browse the repository at this point in the history
  3. Migrate verify_codesigned. (#139328)

    This is part of the migration of adhoc tests to shard tests.
    
    Bug: #139153
    godofredoc authored Dec 22, 2023
    Configuration menu
    Copy the full SHA
    c73bffe View commit details
    Browse the repository at this point in the history
  4. Roll Flutter Engine from 737e6f8ce85e to 1ba8fc0765f9 (4 revisions) (#…

    …140531)
    
    flutter/engine@737e6f8...1ba8fc0
    
    2023-12-22 [email protected] Fix GetImpellerContext for ShellTestPlatformViewGL (flutter/engine#49337)
    2023-12-21 [email protected] [Impeller] Remove use of private Rect fields from PathBuilder (flutter/engine#49334)
    2023-12-21 [email protected] [Impeller] Do not skip rendering when mask blur is zero (flutter/engine#49342)
    2023-12-21 [email protected] [Windows] Fix incorrect surface manager comment (flutter/engine#49335)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 22, 2023
    Configuration menu
    Copy the full SHA
    8024c5e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6126e4b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ede594f View commit details
    Browse the repository at this point in the history
Loading