-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: 11def8eff455
head repository: flutter/flutter
compare: ede594f8816f
- 17 commits
- 40 files changed
- 13 contributors
Commits on Dec 21, 2023
-
Roll Packages from dc5b267 to 4c3bc49 (1 revision) (#140511)
flutter/packages@dc5b267...4c3bc49 2023-12-20 [email protected] Remove workarounds for `check_podspecs` needed for older version of Cocoapods (flutter/packages#5724) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 430254e - Browse repository at this point
Copy the full SHA 430254eView commit details -
Reland: "Fix how Gradle resolves Android plugin" (#137115)
Relands #97823 When the tool migrated to `.flutter-plugins-dependencies`, the Gradle plugin was never changed. Until now, the plugin had the heuristic that a plugin with a `android/build.gradle` file supported the Android platform. Also applies schema of `getPluginDependencies` to `getPluginList` which uses a `List` of Object instead of `Properties`. Fixes #97729 Cause of the error: https://github.com/flutter/flutter/blob/5f105a6ca7a5ac7b8bc9b241f4c2d86f4188cf5c/packages/flutter_tools/gradle/flutter.gradle#L421C25-L421C25 Fixes #98048 The deprecated line `include ":$name"` in `settings.gradle` (pluginEach) in old projects causes the `project.rootProject.findProject` to also find the plugin "project", so it is not failing on the `afterEvaluate` method. But the plugin shouldn't be included in the first place as it fails with `Could not find method implementation() for arguments` error in special cases. Related to #48918, see [_writeFlutterPluginsListLegacy](https://github.com/flutter/flutter/blob/27bc1cf61a5b54bf655062be63050123abb617e4/packages/flutter_tools/lib/src/flutter_plugins.dart#L248). Co-authored-by: Emmanuel Garcia <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f5ac225 - Browse repository at this point
Copy the full SHA f5ac225View commit details -
Reverts "[web] Re-enable test now that source of flakiness is fixed" (#…
…140515) Reverts #140462 Initiated by: cbracken This change reverts the following previous change: Original Description: The test was flaky before due to overflowing GPU memory during the test. The memory leak was fixed here flutter/engine#49214 Fixes #137669 As a side effect of the fix, this test also runs much faster, from about 3 minutes on my Macbook down to about 25 seconds.
Configuration menu - View commit details
-
Copy full SHA for cb50d4a - Browse repository at this point
Copy the full SHA cb50d4aView commit details -
Add send_text_input_action case to deserialization_factory to allow s…
…endTextInputAction usages through flutter_driver. (#139197) **As a follow up to #131776 **Summary:** Previously in #106561, SendTextInputAction was added to Flutter Driver. But it still cannot be used from flutter_driver tests. This PR intends to resolve that issue. **Issue:** An `DriverError: Unsupported command kind send_text_input_action` would be thrown from `flutter_driver/lib/src/common/deserialization_factory.dart` when a call to `driver.sendTextInputAction(TextInputAction.done);` was made despite the method `sendTextInputAction` is available for use since #106561. Previous works has been done in #131776, I merely added tests. Best regards.
Configuration menu - View commit details
-
Copy full SHA for 90badf7 - Browse repository at this point
Copy the full SHA 90badf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 674fbd2 - Browse repository at this point
Copy the full SHA 674fbd2View commit details -
Enable
android_preview_tool_integration_testscheck (#140470)Configuration menu - View commit details
-
Copy full SHA for a3e0fa5 - Browse repository at this point
Copy the full SHA a3e0fa5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e104eb - Browse repository at this point
Copy the full SHA 9e104ebView commit details -
Make tests more resilient to Skia gold failures and refactor flutter_…
…goldens for extensive technical debt removal (#140101) Originally landed in #139549 Originally reverted in #140085 - Remove all use of global variables. - Always pass in all dependencies, only create them in main or in tests. - Pass in the "print" primitive. - Make all network traffic retry (except when run locally, when it just auto-passes). - Enable tests to be run in random order. - Better error messages
Configuration menu - View commit details
-
Copy full SHA for 62f1594 - Browse repository at this point
Copy the full SHA 62f1594View commit details -
Run mac staging tests with Xcode 15 (#140518)
Run macOS staging tests with Xcode 15 and macOS 13. Also, cleanup some comments.
Configuration menu - View commit details
-
Copy full SHA for 2da1ff2 - Browse repository at this point
Copy the full SHA 2da1ff2View commit details -
This PR was generated by `flutter update-packages --force-upgrade`.
Configuration menu - View commit details
-
Copy full SHA for 9c2a756 - Browse repository at this point
Copy the full SHA 9c2a756View commit details -
Roll Flutter Engine from c70f0a495ace to 1b1b2a12a597 (32 revisions) (#…
…140519) Roll Flutter Engine from c70f0a495ace to 1b1b2a12a597 (32 revisions) flutter/engine@c70f0a4...1b1b2a1 2023-12-21 [email protected] Roll Dart SDK from 4a10533a4dc8 to bcf68d22f0fa (1 revision) (flutter/engine#49329) 2023-12-21 [email protected] Roll Dart SDK from 1d0c3ecd1349 to 4a10533a4dc8 (1 revision) (flutter/engine#49326) 2023-12-21 [email protected] Ensure sorted rects in ui.Canvas for legacy compatibility (flutter/engine#49309) 2023-12-21 [email protected] Roll Dart SDK from 63a452b45026 to 1d0c3ecd1349 (1 revision) (flutter/engine#49318) 2023-12-21 [email protected] [Impeller] Make IPLR files multi-platform (flutter/engine#49253) 2023-12-21 [email protected] [web] Defer injection of platform views until needed. (flutter/engine#48960) 2023-12-21 [email protected] Roll Dart SDK from 1aef027ec953 to 63a452b45026 (2 revisions) (flutter/engine#49311) 2023-12-21 [email protected] Roll Skia from 29917d8c97ca to 4b16117e94b2 (4 revisions) (flutter/engine#49310) 2023-12-21 [email protected] Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49262) 2023-12-21 [email protected] Reland `[Impeller] new blur: refactored math and fixed expanded padding size` (flutter/engine#49302) 2023-12-20 [email protected] Multiview pipeline Pt. 1: Skip illegal render calls (flutter/engine#49266) 2023-12-20 [email protected] SemanticsUpdateBuilder: make all args non-null (flutter/engine#49148) 2023-12-20 [email protected] [Impeller] fixed Rect::Contains (flutter/engine#49294) 2023-12-20 [email protected] Roll Dart SDK from 97c3b7e1885a to 1aef027ec953 (1 revision) (flutter/engine#49295) 2023-12-20 [email protected] Revert "[Impeller] new blur: refactored math and fixed expanded padding size" (flutter/engine#49298) 2023-12-20 [email protected] [Impeller] new blur: refactored math and fixed expanded padding size (flutter/engine#49206) 2023-12-20 [email protected] Multi-view pointer event (flutter/engine#46213) 2023-12-20 [email protected] [web:multiview] Only call `Renderer.clearFragmentProgramCache` on hot restart (flutter/engine#48758) 2023-12-20 [email protected] Roll Skia from 9cb1bb1164ea to 29917d8c97ca (1 revision) (flutter/engine#49289) 2023-12-20 [email protected] [Impeller] Add interactive Blur+Clip AiksTest. (flutter/engine#49283) 2023-12-20 [email protected] [macos] FlutterKeyboardManager memory leak fix (flutter/engine#48824) 2023-12-20 [email protected] Don't guard Windows arm64 Dart SDK download on the release candidate flag (flutter/engine#49244) 2023-12-20 [email protected] Fix testAppExtensionLaunching for Xcode 15/iOS 17 (flutter/engine#49242) 2023-12-20 [email protected] Roll Skia from 8060d6b36066 to 9cb1bb1164ea (2 revisions) (flutter/engine#49288) 2023-12-20 [email protected] Roll Dart SDK from ed415d966d8a to 97c3b7e1885a (1 revision) (flutter/engine#49287) 2023-12-20 [email protected] Roll Skia from d0f09ad481f7 to 8060d6b36066 (1 revision) (flutter/engine#49285) 2023-12-20 [email protected] [release] Update release config (flutter/engine#49254) 2023-12-20 [email protected] Roll Dart SDK from 1732c4c92ccd to ed415d966d8a (1 revision) (flutter/engine#49274) 2023-12-20 [email protected] Roll Dart SDK from 4c59838945d9 to 1732c4c92ccd (1 revision) (flutter/engine#49269) 2023-12-20 [email protected] Sync lints with flutter/flutter (flutter/engine#49192) 2023-12-19 [email protected] [web] Enforce onDrawFrame/onBeginFrame render rule (flutter/engine#49214) 2023-12-19 [email protected] [Docs] Add more info about running tests on iOS (flutter/engine#48859) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...
Configuration menu - View commit details
-
Copy full SHA for b417fb8 - Browse repository at this point
Copy the full SHA b417fb8View commit details
Commits on Dec 22, 2023
-
Roll Flutter Engine from 1b1b2a12a597 to 737e6f8ce85e (5 revisions) (#…
…140527) flutter/engine@1b1b2a1...737e6f8 2023-12-21 [email protected] Roll Dart SDK from bcf68d22f0fa to fe94d9b88531 (1 revision) (flutter/engine#49343) 2023-12-21 [email protected] Reland "[web] Enforce onDrawFrame/onBeginFrame render rule" (flutter/engine#49336) 2023-12-21 [email protected] Turn on scenario app screenshots (flutter/engine#49066) 2023-12-21 [email protected] Revert onrender change (flutter/engine#49333) 2023-12-21 [email protected] [web] autofocus in new routes (flutter/engine#47727) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 08e58ba - Browse repository at this point
Copy the full SHA 08e58baView commit details -
[web] unskip canvaskit tests that pass now (#140480)
Unskip a few CanvasKit tests that pass now.
Configuration menu - View commit details
-
Copy full SHA for c02ace6 - Browse repository at this point
Copy the full SHA c02ace6View commit details -
Migrate verify_codesigned. (#139328)
This is part of the migration of adhoc tests to shard tests. Bug: #139153
Configuration menu - View commit details
-
Copy full SHA for c73bffe - Browse repository at this point
Copy the full SHA c73bffeView commit details -
Roll Flutter Engine from 737e6f8ce85e to 1ba8fc0765f9 (4 revisions) (#…
…140531) flutter/engine@737e6f8...1ba8fc0 2023-12-22 [email protected] Fix GetImpellerContext for ShellTestPlatformViewGL (flutter/engine#49337) 2023-12-21 [email protected] [Impeller] Remove use of private Rect fields from PathBuilder (flutter/engine#49334) 2023-12-21 [email protected] [Impeller] Do not skip rendering when mask blur is zero (flutter/engine#49342) 2023-12-21 [email protected] [Windows] Fix incorrect surface manager comment (flutter/engine#49335) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 8024c5e - Browse repository at this point
Copy the full SHA 8024c5eView commit details -
Roll Flutter Engine from 1ba8fc0765f9 to a8da67fed23b (1 revision) (#…
…140536) flutter/engine@1ba8fc0...a8da67f 2023-12-22 [email protected] Roll Dart SDK from fe94d9b88531 to 69423a5dd254 (1 revision) (flutter/engine#49354) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 6126e4b - Browse repository at this point
Copy the full SHA 6126e4bView commit details -
Roll Flutter Engine from a8da67fed23b to 5448105a76f7 (1 revision) (#…
…140540) flutter/engine@a8da67f...5448105 2023-12-22 [email protected] Roll Dart SDK from 69423a5dd254 to 151b363886f9 (1 revision) (flutter/engine#49357) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for ede594f - Browse repository at this point
Copy the full SHA ede594fView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 11def8eff455...ede594f8816f