Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0a7f8af6d146
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d595e98d85ea
Choose a head ref
  • 4 commits
  • 18 files changed
  • 4 contributors

Commits on Aug 7, 2024

  1. Roll Flutter Engine from 206e86ee8a40 to 5a0fd5fbecc6 (6 revisions) (#… 

    …152985)

flutter/engine@206e86e...5a0fd5f

2024-08-07 [email protected] [Impeller] Statically check stage interfaces for precision mismatches. (flutter/engine#54375)
2024-08-07 [email protected] Roll Skia from f04ba9cd0e4b to 968a00456bc5 (4 revisions) (flutter/engine#54378)
2024-08-06 [email protected] Roll Dart SDK from dedfa3393296 to f5d136899082 (5 revisions) (flutter/engine#54376)
2024-08-06 [email protected] [Impeller] Reorder pipeline construction in content context. (flutter/engine#54373)
2024-08-06 [email protected] [iOS] clean ups to platform view controller (flutter/engine#54335)
2024-08-06 [email protected] [Impeller] ensure precision matches for buggy vulkan drivers. (flutter/engine#54372)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    e0c051f View commit details
    Browse the repository at this point in the history

  2. Reverts "[tool] Guard process writes to frontend server in `ResidentC… 

    …ompiler` (#152358)" (#153028)

Reverts: #152358
Initiated by: zanderso
Reason for reverting: Speculative revert to determine whether this PR is related to #153026
Original PR Author: andrewkolos

Reviewed By: {christopherfujino}

This change reverts the following previous change:
Contributes to fixing #137184.
Cleaned up version of earlier PR, #152187.

This PR guards all the writes to `Process::stdin` by wrapping them with `ProcessUtils.writelnToStdinUnsafe`. This way, if any writes fail, we should at least get a stacktrace in our crash reporting.
    @auto-submit
    auto-submit[bot] authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    72432c3 View commit details
    Browse the repository at this point in the history

  3. Update design languages triage link to exclude drafts (#153027) 

    Noticed the framework triage was doing this, adopting it for design languages as well!

Critical triage follows up on these draft PRs if they sit for long without an update. Having draft PRs allows folks to discuss changes without getting nudged constantly to make progress on it. This feels like a really positive change.
    @Piinks
    Piinks authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    2ff7fe9 View commit details
    Browse the repository at this point in the history

  4. Fix PageController throws when changing page before viewPortDimension… 

    …s are set (#153017)

## Description

This PR fixes `PageController` throwing when using `jumpToPage` or `animateToPage` to switch page before the viewport dimensions were retrieved.

Solution based on #152947 (comment).

## Related Issue

Fixes #86222.
Fixes #152079

## Tests

Adds 2 tests.
    @bleroux
    bleroux authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    d595e98 View commit details
    Browse the repository at this point in the history
Loading