Comparing changes

…148546) flutter/engine@a19d372...7d244ab 2024-05-17 [email protected] Roll Skia from a251e7836a5c to bcb24206f9c4 (1 revision) (flutter/engine#52899) 2024-05-17 [email protected] Roll Dart SDK from c0709fb4a1a3 to 601c7a96ef5d (1 revision) (flutter/engine#52898) 2024-05-17 [email protected] Roll Skia from 071cbd93d0a4 to a251e7836a5c (1 revision) (flutter/engine#52897) 2024-05-17 [email protected] Roll Skia from 4af5313185d7 to 071cbd93d0a4 (2 revisions) (flutter/engine#52896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…148549) flutter/engine@7d244ab...17decdf 2024-05-17 [email protected] Roll Dart SDK from 601c7a96ef5d to 28e8e94f9e10 (1 revision) (flutter/engine#52900) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Reverts #147793 Introduced #148548.

The test on MotoG4 has lots of flaky timeouts, so this PR moves it to bringup to stop turning the tree red. This PR also adds the test on Mokey in anticipation of removing the MotoG4 devices and to see if it might be flaky there as well.

…148567) flutter/engine@17decdf...5b3bf9a 2024-05-17 [email protected] Roll Skia from 6165e26f33ac to 6f7cb3d360b7 (1 revision) (flutter/engine#52903) 2024-05-17 [email protected] Roll Skia from bcb24206f9c4 to 6165e26f33ac (1 revision) (flutter/engine#52902) 2024-05-17 [email protected] Issue an`ERROR` instead of an `INFO` for a non-working API. (flutter/engine#52892) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Part of #145009 This is part one of the wiki migration. This moves all wiki pages wholesale into the new docs directory with no changes. Follow up PRs will sort them, updating breadcrumbs and links.

…148581) flutter/engine@5b3bf9a...93f1b5a 2024-05-17 [email protected] Roll Fuchsia Linux SDK from ywxGmpIdjxBl2i7s2... to jKdOTTgE2Uq5OmJzT... (flutter/engine#52909) 2024-05-17 [email protected] [Impeller] fix colr/bitmap font color drawing. (flutter/engine#52871) 2024-05-17 [email protected] Roll Skia from 6f7cb3d360b7 to 3f4c5038da37 (1 revision) (flutter/engine#52907) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ywxGmpIdjxBl to jKdOTTgE2Uq5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fixes: #147260 (this is a remake of #147296; in hindsight I could have force-pushed there instead but ð�¤·)

…148595) flutter/engine@93f1b5a...552a965 2024-05-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fixes MatrixFilterContents rendering/coverage (#52880)" (flutter/engine#52918) 2024-05-18 [email protected] Fixes MatrixFilterContents rendering/coverage (flutter/engine#52880) 2024-05-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[macOS] Generate universal gen_snapshots (#52885)" (flutter/engine#52913) 2024-05-17 [email protected] [macOS] Generate universal gen_snapshots (flutter/engine#52885) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Currently, `Feedback` exists in the Material layer. However, not only is `Feedback` not material-opinionated, but it is an abstract class that defines its functionality depending on the user's platform. It makes sense that `Feedback` should exist in the widgets layer instead. This makes it easier to incorporate platform specific `Feedback` updates as they arrive, fixing issues like #148391. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [Data Driven Fixes]: https://github.com/flutter/flutter/wiki/Data-driven-Fixes

This suite is failing when run with --test-randomize-ordering-seed=20240518 This is currently blocking the engine->framework roller

`'flutter create should tool exit if the template manifest cannot be read'` fails consistently, as shown by #148614. The test expects a `ToolExit` with the message "Unable to read the template manifest", but depending on how the test is being run, a different exception ("Cannot create a project within the Flutter SDK") is sometimes thrown first. This pull request relocates the test project to `dev/` to prevent the extraneous error.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comparing changes

Open a pull request

Commits on May 17, 2024

Commits on May 18, 2024

This comparison is taking too long to generate.

Uh oh!