Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 00171b07130e
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 50171bbae357
Choose a head ref
  • 7 commits
  • 20 files changed
  • 3 contributors

Commits on Apr 15, 2023

  1. Configuration menu
    Copy the full SHA
    4543766 View commit details
    Browse the repository at this point in the history
  2. [flutter_tools] Remove Version.unknown (#124771)

    Fixes #124756 by removing the concept of `Version.unknown`.
    
    `Version` fields that needed the ability to represent an unknown version have been made nullable. Assigning `null` to them represents an unknown version.
    andrewkolos authored Apr 15, 2023
    Configuration menu
    Copy the full SHA
    68ec71f View commit details
    Browse the repository at this point in the history
  3. [cupertino] improve cupertino picker performance by using at most one…

    … opacity layer (#124719)
    
    Fixes #124703
    
    Rather than applying an opacity layer per picker item, apply them to all partially opaque picker items at once. This dramatically improves performance for impeller, by reducing the number of required subpasses and texture allocations signficantly.
    
    Before:
    Doesn't finish, 100s of passes
    
    After:
    
    ![image](https://user-images.githubusercontent.com/8975114/231569280-91f55c9a-53a5-4b75-8728-59a4dceebe81.png)
    
    ![image](https://user-images.githubusercontent.com/8975114/231569309-7c82e5ff-46c7-4f00-80f0-9b4096aa4b14.png)
    
    See also:
    
    #124658
    Jonah Williams authored Apr 15, 2023
    Configuration menu
    Copy the full SHA
    d1d426e View commit details
    Browse the repository at this point in the history
  4. Revert "[framework] use shader tiling instead of repeated calls to dr…

    …awImage" (#124640)
    
    Reverts #119495
    
    We'll managed to optimize almost all of the cases that made this slow. Actually, it will soon be harder to optimize shader tiling...
    Jonah Williams authored Apr 15, 2023
    Configuration menu
    Copy the full SHA
    00495da View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d8a916f View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2023

  1. Roll Flutter Engine from feb476b7b991 to da0805a9cf03 (4 revisions) (#…

    …124933)
    
    flutter/engine@feb476b...da0805a
    
    2023-04-15 [email protected] Roll Skia from 2a4d95762651 to 2d0b05335104 (1 revision) (flutter/engine#41250)
    2023-04-15 [email protected] [Impeller] add a generic porter duff blend foreground shader. (flutter/engine#41098)
    2023-04-15 [email protected] Roll Fuchsia Linux SDK from Y_tD90hDX_jiubGbC... to hacWN-gQSoWudziIS... (flutter/engine#41248)
    2023-04-15 [email protected] Roll Fuchsia Mac SDK from RFyPoDrXzIiy-E3wn... to gI2knJ4Rh0yoK4Syd... (flutter/engine#41249)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from Y_tD90hDX_ji to hacWN-gQSoWu
      fuchsia/sdk/core/mac-amd64 from RFyPoDrXzIiy to gI2knJ4Rh0yo
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 16, 2023
    Configuration menu
    Copy the full SHA
    2d57261 View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from da0805a9cf03 to 4a998b73a2df (5 revisions) (#…

    …124944)
    
    flutter/engine@da0805a...4a998b7
    
    2023-04-16 [email protected] Roll Skia from cc3404330d3b to 03c8e529196d (1 revision) (flutter/engine#41255)
    2023-04-16 [email protected] Roll Skia from 2d0b05335104 to cc3404330d3b (1 revision) (flutter/engine#41254)
    2023-04-16 [email protected] Roll Fuchsia Linux SDK from hacWN-gQSoWudziIS... to 46T4ZTAt48yPRDEn5... (flutter/engine#41253)
    2023-04-16 [email protected] Roll Fuchsia Mac SDK from gI2knJ4Rh0yoK4Syd... to AAx6fLy6ykWVhXvNh... (flutter/engine#41252)
    2023-04-16 [email protected] [Impeller] Add offscreen texture checkerboarding (flutter/engine#41199)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from hacWN-gQSoWu to 46T4ZTAt48yP
      fuchsia/sdk/core/mac-amd64 from gI2knJ4Rh0yo to AAx6fLy6ykWV
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 16, 2023
    Configuration menu
    Copy the full SHA
    50171bb View commit details
    Browse the repository at this point in the history
Loading