fix: golden names for TestDecoration

rkishan516 · rkishan516 · commit fa6ba1022c5f · 2026-03-08T07:11:15.000+05:30
diff --git a/packages/flutter/test/widgets/container_test.dart b/packages/flutter/test/widgets/container_test.dart
@@ -633,7 +633,7 @@ void main() {
   });
 
   testWidgets('getClipPath() works for lots of kinds of decorations', (WidgetTester tester) async {
-    Future<void> test(Decoration decoration) async {
+    Future<void> test(Decoration decoration, [String? name]) async {
       await tester.pumpWidget(
         Directionality(
           textDirection: TextDirection.rtl,
@@ -653,12 +653,12 @@ void main() {
       );
       await expectLater(
         find.byType(Container),
-        matchesGoldenFile('container_test.getClipPath.${decoration.runtimeType}.png'),
+        matchesGoldenFile('container_test.getClipPath.${name ?? decoration.runtimeType}.png'),
       );
     }
 
     await test(const BoxDecoration());
-    await test(const _TestDecoration());
+    await test(const _TestDecoration(), 'UnderlineTabIndicator');
     await test(const ShapeDecoration(shape: StadiumBorder()));
     await test(const FlutterLogoDecoration());
   });
@@ -845,13 +845,32 @@ class _TestDecoration extends Decoration {
 
   @override
   Path getClipPath(Rect rect, TextDirection textDirection) {
-    return Path()..addRRect(RRect.fromRectAndRadius(rect, const Radius.circular(10)));
+    const borderSideWidth = 2.0;
+    final indicator = Rect.fromLTWH(
+      rect.left,
+      rect.bottom - borderSideWidth,
+      rect.width,
+      borderSideWidth,
+    );
+    return Path()..addRect(indicator);
   }
 }
 
 class _TestDecorationPainter extends BoxPainter {
   @override
   void paint(Canvas canvas, Offset offset, ImageConfiguration configuration) {
-    // No painting needed for clip path testing.
+    assert(configuration.size != null);
+    final Rect rect = offset & configuration.size!;
+    const borderSideWidth = 2.0;
+    const color = Color(0xFFFFFFFF);
+    final paint = Paint()
+      ..color = color
+      ..strokeCap = StrokeCap.square
+      ..strokeWidth = borderSideWidth
+      ..style = PaintingStyle.stroke;
+    final Offset indicatorBottomLeft = rect.bottomLeft + const Offset(0.0, -borderSideWidth / 2.0);
+    final Offset indicatorBottomRight =
+        rect.bottomRight + const Offset(0.0, -borderSideWidth / 2.0);
+    canvas.drawLine(indicatorBottomLeft, indicatorBottomRight, paint);
   }
 }
diff --git a/packages/flutter/test/widgets/page_view_test.dart b/packages/flutter/test/widgets/page_view_test.dart
@@ -26,6 +26,7 @@ void main() {
   const kOrange = Color(0xFFFF8C00);
   const kPurple = Color(0xFF800080);
   const kYellow = Color(0xFFFFFF00);
+  const kBlack87 = Color(0xDD000000);
 
   // Regression test for https://github.com/flutter/flutter/issues/100451
   testWidgets('PageView.builder respects findChildIndexCallback', (WidgetTester tester) async {
@@ -1254,6 +1255,12 @@ void main() {
 
     await tester.pumpWidget(
       TestWidgetsApp(
+        builder: (BuildContext context, Widget? child) {
+          return DefaultTextStyle(
+            style: const TextStyle(color: kBlack87, fontSize: 14.0),
+            child: child!,
+          );
+        },
         home: Center(
           child: SizedBox(
             width: pixel6EmulatorWidth,
