Skip to content

Commit f9555b0

Browse files
Drop the AbsorbPointer sample from the cross-import allowlist and give its labels a color
The sample and its test no longer import Material, so they no longer belong in knownExamplesCrossImports. WidgetsApp does not install a DefaultTextStyle, so the section titles and tap counters were falling back to a style with no color and rendering invisibly against the white background. Set WidgetsApp.textStyle so they are legible.
1 parent 621d186 commit f9555b0

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

‎dev/bots/check_examples_cross_imports.dart‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,6 @@ class ExamplesCrossImportChecker {
267267
'packages/flutter/examples/api/lib/widgets/basic/mouse_region.0.dart',
268268
'packages/flutter/examples/api/lib/widgets/basic/expanded.0.dart',
269269
'packages/flutter/examples/api/lib/widgets/basic/mouse_region.on_exit.0.dart',
270-
'packages/flutter/examples/api/lib/widgets/basic/absorb_pointer.0.dart',
271270
'packages/flutter/examples/api/lib/widgets/single_child_scroll_view/single_child_scroll_view.1.dart',
272271
'packages/flutter/examples/api/lib/widgets/single_child_scroll_view/single_child_scroll_view.0.dart',
273272
'packages/flutter/examples/api/lib/widgets/scroll_end_notification/scroll_end_notification.1.dart',
@@ -469,7 +468,6 @@ class ExamplesCrossImportChecker {
469468
'packages/flutter/examples/api/test/widgets/basic/aspect_ratio.2_test.dart',
470469
'packages/flutter/examples/api/test/widgets/basic/indexed_stack.0_test.dart',
471470
'packages/flutter/examples/api/test/widgets/basic/clip_rrect.1_test.dart',
472-
'packages/flutter/examples/api/test/widgets/basic/absorb_pointer.0_test.dart',
473471
'packages/flutter/examples/api/test/widgets/basic/listener.0_test.dart',
474472
'packages/flutter/examples/api/test/widgets/basic/clip_rrect.0_test.dart',
475473
'packages/flutter/examples/api/test/widgets/basic/mouse_region.0_test.dart',

‎packages/flutter/examples/api/lib/widgets/basic/absorb_pointer.0.dart‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ class AbsorbPointerApp extends StatelessWidget {
1515
Widget build(BuildContext context) {
1616
return WidgetsApp(
1717
color: const Color(0xFFFFFFFF),
18+
// WidgetsApp does not install a [DefaultTextStyle], so without this the
19+
// labels below fall back to a style with no color and are invisible
20+
// against the white background.
21+
textStyle: const TextStyle(color: Color(0xFF000000), fontSize: 14.0),
1822
builder: (BuildContext context, Widget? child) {
1923
return const AbsorbPointerExample();
2024
},

0 commit comments

Comments
 (0)