Repository navigation
Commit f1a0549
[web] Propagate aria-label to inner slider input (#192964)
On Flutter Web, `SemanticIncrementable` (`role="slider"`) renders an
outer `<flt-semantics>` container alongside an inner `<input
type="range" role="slider">`. Previously, `AriaLabelRepresentation` set
`aria-label` exclusively on the outer `<flt-semantics>` wrapper
(`role="none"` when active), leaving the interactive `<input
role="slider">` element without an accessible name in the browser's
accessibility tree (`name: ""` in Chrome `Accessibility.getFullAXTree`
and `"50%, slider"` in VoiceOver).
This change:
1. Propagates `semanticsObject.label` to the inner `<input
role="slider">` element's `aria-label` attribute in
`SemanticIncrementable.update()`, removing it when the label becomes
empty.
2. Tracks `_previousLabel` in `AriaLabelRepresentation` so stale
`aria-label` attributes are cleaned up when a label is cleared.
3. Adds unit tests in `semantics_test.dart` (`_testIncrementables()`)
verifying `aria-label` propagation and cleanup on `<input
role="slider">`.
Fixes http://b/463248173
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: zhongliugo <[email protected]>1 parent b959896 commit f1a0549
4 files changed
Lines changed: 43 additions & 1 deletion
File tree
- engine/src/flutter/lib/web_ui
- lib/src/engine/semantics
- test/engine/semantics
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
125 | 132 | | |
126 | 133 | | |
127 | 134 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| 123 | + | |
123 | 124 | | |
124 | 125 | | |
125 | 126 | | |
126 | 127 | | |
127 | 128 | | |
| 129 | + | |
128 | 130 | | |
129 | 131 | | |
130 | 132 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
| 110 | + | |
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2932 | 2932 | | |
2933 | 2933 | | |
2934 | 2934 | | |
| 2935 | + | |
| 2936 | + | |
| 2937 | + | |
| 2938 | + | |
| 2939 | + | |
| 2940 | + | |
| 2941 | + | |
| 2942 | + | |
| 2943 | + | |
| 2944 | + | |
| 2945 | + | |
| 2946 | + | |
| 2947 | + | |
| 2948 | + | |
| 2949 | + | |
| 2950 | + | |
| 2951 | + | |
| 2952 | + | |
| 2953 | + | |
| 2954 | + | |
| 2955 | + | |
| 2956 | + | |
| 2957 | + | |
| 2958 | + | |
| 2959 | + | |
| 2960 | + | |
| 2961 | + | |
| 2962 | + | |
| 2963 | + | |
| 2964 | + | |
| 2965 | + | |
| 2966 | + | |
| 2967 | + | |
2935 | 2968 | | |
2936 | 2969 | | |
2937 | 2970 | | |
| |||
0 commit comments