Skip to content

Commit ec0c44f

Browse files
hm21hm21
committed
2 parents 0a3684d + 6519f99 commit ec0c44f

File tree

386 files changed

+11506
-3917
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

386 files changed

+11506
-3917
lines changed

‎.ci.yaml‎

Lines changed: 39 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ platform_properties:
7676
[
7777
{"dependency": "android_sdk", "version": "version:36v4"},
7878
{"dependency": "android_virtual_device", "version": "android_36_google_apis_x64.textpb"},
79-
{"dependency": "avd_cipd_version", "version": "build_id:8699815938758639089"},
79+
{"dependency": "avd_cipd_version", "version": "build_id:8702262057250908257"},
8080
{"dependency": "open_jdk", "version": "version:21"},
8181
{"dependency": "clang", "version": "git_revision:5d5aba78dbbee75508f01bcaa69aedb2ab79065a"},
8282
{"dependency": "cmake", "version": "build_id:8787856497187628321"},
@@ -1688,8 +1688,8 @@ targets:
16881688
{"dependency": "cmake", "version": "build_id:8787856497187628321"},
16891689
{"dependency": "ninja", "version": "version:1.9.0"}
16901690
]
1691-
shard: tool_tests
1692-
subshard: commands
1691+
shard: tool_tests_commands
1692+
subshard: 1_1
16931693
tags: >
16941694
["framework", "hostonly", "shard", "linux"]
16951695
runIf:
@@ -2367,7 +2367,6 @@ targets:
23672367

23682368
# Uses Impeller.
23692369
- name: Linux_pixel_7pro hello_world_impeller
2370-
bringup: true # Flaky https://github.com/flutter/flutter/issues/173698
23712370
recipe: devicelab/devicelab_drone
23722371
presubmit: false
23732372
timeout: 60
@@ -2693,6 +2692,7 @@ targets:
26932692

26942693
# linux mokey benchmark
26952694
- name: Linux_mokey flutter_engine_group_performance
2695+
bringup: true # Flaky https://github.com/flutter/flutter/issues/179114
26962696
recipe: devicelab/devicelab_drone
26972697
presubmit: false
26982698
timeout: 60
@@ -3129,7 +3129,6 @@ targets:
31293129

31303130
# Pixel 7 Pro, Skia
31313131
- name: Linux_pixel_7pro new_gallery__transition_perf
3132-
bringup: true # Flaky https://github.com/flutter/flutter/issues/174105
31333132
recipe: devicelab/devicelab_drone
31343133
presubmit: false
31353134
timeout: 60
@@ -3170,7 +3169,6 @@ targets:
31703169

31713170
# Pixel 7 Pro, Impeller (OpenGL)
31723171
- name: Linux_pixel_7pro new_gallery_opengles_impeller__transition_perf
3173-
bringup: true # Flaky https://github.com/flutter/flutter/issues/173337
31743172
recipe: devicelab/devicelab_drone
31753173
presubmit: false
31763174
timeout: 60
@@ -3554,7 +3552,6 @@ targets:
35543552
- name: Linux_pixel_7pro draw_arcs_all_fill_styles_perf__timeline_summary
35553553
recipe: devicelab/devicelab_drone
35563554
presubmit: false
3557-
bringup: true
35583555
timeout: 60
35593556
properties:
35603557
tags: >
@@ -3564,7 +3561,6 @@ targets:
35643561
- name: Mac_ios draw_arcs_all_fill_styles_perf_ios__timeline_summary
35653562
recipe: devicelab/devicelab_drone
35663563
presubmit: false
3567-
bringup: true
35683564
timeout: 60
35693565
properties:
35703566
tags: >
@@ -3574,7 +3570,6 @@ targets:
35743570
- name: Linux_pixel_7pro draw_arcs_all_stroke_styles_perf__timeline_summary
35753571
recipe: devicelab/devicelab_drone
35763572
presubmit: false
3577-
bringup: true
35783573
timeout: 60
35793574
properties:
35803575
tags: >
@@ -4627,8 +4622,8 @@ targets:
46274622
{"dependency": "android_sdk", "version": "version:36v4"},
46284623
{"dependency": "open_jdk", "version": "version:21"}
46294624
]
4630-
shard: tool_tests
4631-
subshard: commands
4625+
shard: tool_tests_commands
4626+
subshard: 1_1
46324627
tags: >
46334628
["framework", "hostonly", "shard", "mac"]
46344629
@@ -4642,8 +4637,8 @@ targets:
46424637
{"dependency": "android_sdk", "version": "version:36v4"},
46434638
{"dependency": "open_jdk", "version": "version:21"}
46444639
]
4645-
shard: tool_tests
4646-
subshard: commands
4640+
shard: tool_tests_commands
4641+
subshard: 1_1
46474642
tags: >
46484643
["framework", "hostonly", "shard", "mac"]
46494644
@@ -4741,6 +4736,7 @@ targets:
47414736

47424737
# mac mokey test
47434738
- name: Mac_arm64_mokey entrypoint_dart_registrant
4739+
bringup: true # Flakey https://github.com/flutter/flutter/issues/179514
47444740
recipe: devicelab/devicelab_drone
47454741
presubmit: false
47464742
timeout: 60
@@ -4829,6 +4825,7 @@ targets:
48294825

48304826
# mac mokey test
48314827
- name: Mac_arm64_mokey native_assets_android
4828+
bringup: true # Flakey https://github.com/flutter/flutter/issues/179514
48324829
recipe: devicelab/devicelab_drone
48334830
presubmit: false
48344831
timeout: 60
@@ -4885,6 +4882,7 @@ targets:
48854882

48864883
# mac mokey test
48874884
- name: Mac_arm64_mokey run_release_test
4885+
bringup: true # Flaky https://github.com/flutter/flutter/issues/177371
48884886
recipe: devicelab/devicelab_drone
48894887
presubmit: false
48904888
runIf:
@@ -6562,9 +6560,10 @@ targets:
65626560
- engine/**
65636561
- DEPS
65646562

6565-
- name: Windows tool_tests_commands
6563+
- name: Windows tool_tests_commands_1_2
65666564
recipe: flutter/flutter_drone
65676565
timeout: 60
6566+
bringup: true
65686567
properties:
65696568
add_recipes_cq: "true"
65706569
dependencies: >-
@@ -6573,8 +6572,32 @@ targets:
65736572
{"dependency": "open_jdk", "version": "version:21"},
65746573
{"dependency": "vs_build", "version": "version:vs2019"}
65756574
]
6576-
shard: tool_tests
6577-
subshard: commands
6575+
shard: tool_tests_commands
6576+
subshard: 1_2
6577+
tags: >
6578+
["framework", "hostonly", "shard", "windows"]
6579+
runIf:
6580+
- dev/**
6581+
- packages/flutter_tools/**
6582+
- bin/**
6583+
- .ci.yaml
6584+
- engine/**
6585+
- DEPS
6586+
6587+
- name: Windows tool_tests_commands_2_2
6588+
recipe: flutter/flutter_drone
6589+
timeout: 60
6590+
bringup: true
6591+
properties:
6592+
add_recipes_cq: "true"
6593+
dependencies: >-
6594+
[
6595+
{"dependency": "android_sdk", "version": "version:36v4"},
6596+
{"dependency": "open_jdk", "version": "version:21"},
6597+
{"dependency": "vs_build", "version": "version:vs2019"}
6598+
]
6599+
shard: tool_tests_commands
6600+
subshard: 2_2
65786601
tags: >
65796602
["framework", "hostonly", "shard", "windows"]
65806603
runIf:

‎.github/workflows/content-aware-hash.yml‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,15 @@ name: Generate a content aware hash for the Flutter Engine
66

77
on: workflow_dispatch
88

9+
permissions:
10+
contents: read
11+
912
jobs:
1013
generate-engine-content-hash:
1114
runs-on: ubuntu-latest
1215
steps:
1316
- name: Checkout code
14-
uses: actions/checkout@v6
17+
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
1518

1619
- name: Generate Hash
1720
run: |

‎.github/workflows/coverage.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
runs-on: ubuntu-latest
2020
if: ${{ github.repository == 'flutter/flutter' }}
2121
steps:
22-
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd
22+
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3
2323
- name: ./bin/flutter test --coverage
2424
run: pushd packages/flutter;../../bin/flutter test --coverage -j 1;popd
2525
- name: upload coverage

‎.github/workflows/easy-cp.yml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ on:
99
branches: master
1010
types: [labeled]
1111

12-
permissions: write-all
12+
permissions:
13+
contents: read
14+
pull-requests: write
1315

1416
jobs:
1517
cherrypick_not_merged_remove_label:
@@ -44,7 +46,7 @@ jobs:
4446
run: |
4547
echo "COMMIT_SHA=$(echo ${{ github.event.pull_request.merge_commit_sha }})" >> $GITHUB_ENV
4648
- name: Checkout Flutter Repo
47-
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd
49+
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3
4850
with:
4951
repository: flutteractionsbot/flutter
5052
path: flutter

‎.github/workflows/files-changed.yml‎

Lines changed: 0 additions & 41 deletions
This file was deleted.

‎.github/workflows/merge-changelog.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515

1616
steps:
1717
- name: Setup Repository
18-
uses: actions/checkout@v6
18+
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
1919
with:
2020
repository: ${{ github.repository }}
2121
ref: master

‎.github/workflows/tool-test-general.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222

2323
steps:
2424
# Note: we must check out the tree for the composite action to be available
25-
- uses: actions/checkout@v6
25+
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
2626
- uses: ./.github/actions/composite-flutter-setup
2727

2828
- name: Tool Test

‎CHANGELOG.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,17 @@ docs/releases/Hotfix-Documentation-Best-Practices.md
3232

3333
## Flutter 3.38 Changes
3434

35+
### [3.38.4](https://github.com/flutter/flutter/releases/tag/3.38.4)
36+
37+
- [flutter/178547](https://github.com/flutter/flutter/issues/178547) Rendering issues in the Linux desktop embedder when using Skia.
38+
- [flutter/178529](https://github.com/flutter/flutter/issues/178529) AppLocalizations getting deleted when running debug web
39+
- [flutter/178660](https://github.com/flutter/flutter/issues/178660) `flutter widget-preview start` can crash if `.dart_tool/widget_preview_scaffold/.dart_tool` doesn't exist on subsequent runs.
40+
- [flutter/175227](https://github.com/flutter/flutter/issues/175227) Flutter Web applications launched in Chrome show a warning related to --no-sandbox.
41+
- [flutter/179155](https://github.com/flutter/flutter/issues/179155) `flutter widget-preview start` crashes if a file named `pubspec.yaml` is modified outside the root of the previewed project.
42+
- [flutter/156692](https://github.com/flutter/flutter/issues/156692) `flutter attach` can crash if the target application disconnects unexpectedly.
43+
- [flutter/179008](https://github.com/flutter/flutter/issues/179008) `flutter pub get` could be spawned multiple times on MacOS when `pubspec.yaml`s outside of the project were modified after a `flutter pub get` in the root project.
44+
- [flutter/178715](https://github.com/flutter/flutter/issues/178715) Running flutter test on Linux/MacOS for Android projects with build hooks fails without the desktop native tooling installed.
45+
3546
### [3.38.3](https://github.com/flutter/flutter/releases/tag/3.38.3)
3647

3748
- [flutter/178772](https://github.com/flutter/flutter/issues/178772) Flutter engine reports a different version than the framework.

‎DEPS‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ vars = {
1515
'flutter_git': 'https://flutter.googlesource.com',
1616
'skia_git': 'https://skia.googlesource.com',
1717
'llvm_git': 'https://llvm.googlesource.com',
18-
'skia_revision': '925c311f4b37026e285964fb7bd1b56b9b4e3ea4',
18+
'skia_revision': 'e61cc6d073fd3dd217b52e7b91d21151aad61478',
1919

2020
# WARNING: DO NOT EDIT canvaskit_cipd_instance MANUALLY
2121
# See `lib/web_ui/README.md` for how to roll CanvasKit to a new version.
@@ -59,28 +59,28 @@ vars = {
5959
# updated revision list of existing dependencies. You will need to
6060
# gclient sync before and after update deps to ensure all deps are updated.
6161
# updated revision list of existing dependencies.
62-
'dart_revision': '394606994711884cd3abf25c29a97831820099c4',
62+
'dart_revision': '17749965ec57169a2f6c14b8dc5a6a0b6698e343',
6363

6464
# WARNING: DO NOT EDIT MANUALLY
6565
# The lines between blank lines above and below are generated by a script. See create_updated_flutter_deps.py
66-
'dart_ai_rev': '058f8f571b0ab74784d218d43de23d95803e2877',
66+
'dart_ai_rev': '4eb2446144a8af374e08da8d3c743dcce129f87f',
6767
'dart_binaryen_rev': '6ec7b5f9c615d3b224c67ae221d6812c8f8e1a96',
68-
'dart_boringssl_rev': 'e743669eaf598d55406345d4794927ce70f01244',
68+
'dart_boringssl_rev': '098d5baf008ffa6321e2c4a358f5475fcf1fe938',
6969
'dart_core_rev': '5c3e2c38df268be2347f3aad30ced0147dd012bb',
70-
'dart_devtools_rev': 'ed691cae7fb35f6c77950b0e13746893715e4ec8',
71-
'dart_ecosystem_rev': '35b4e6fb5a790ca31081ac9d70e893268c7bda09',
72-
'dart_http_rev': '907782f5a792e7a5b0ed92f118c0ad91f3ecde51',
70+
'dart_devtools_rev': 'bac6843cce3c98d8794a7cce796faaa8860cc00f',
71+
'dart_ecosystem_rev': 'eac66d93142907b39f2271647c111f36ff3365b9',
72+
'dart_http_rev': 'a22386e9c390290c916d1c53a3d3c1447ec120ce',
7373
'dart_i18n_rev': 'dd8a792a8492370a594706c8304d2eb8db844d7a',
7474
'dart_libprotobuf_rev': '24487dd1045c7f3d64a21f38a3f0c06cc4cf2edb',
7575
'dart_perfetto_rev': '13ce0c9e13b0940d2476cd0cff2301708a9a2e2b',
7676
'dart_protobuf_gn_rev': 'ca669f79945418f6229e4fef89b666b2a88cbb10',
77-
'dart_protobuf_rev': '3ed04a91ff4de8493226e8fd0d89678c2986edf6',
77+
'dart_protobuf_rev': '9e30258e0aa6a6430ee36c84b75308a9702fde42',
7878
'dart_pub_rev': 'b297f1f5e42f2569f15a98548f44b4b9a48487c1',
7979
'dart_sync_http_rev': '6666fff944221891182e1f80bf56569338164d72',
80-
'dart_tools_rev': '30c418bdd4b46d462e29e9ea360bbf9d62296c3b',
80+
'dart_tools_rev': 'd03c394b24829f662098e590a2c812a076b01199',
8181
'dart_vector_math_rev': '70a9a2cb610d040b247f3ca2cd70a94c1c6f6f23',
82-
'dart_web_rev': '7b94cf8908d320179678fc24557f163e2924c830',
83-
'dart_webdev_rev': 'b9c39c00853dfad0e235bec3b265f86a0f4f328a',
82+
'dart_web_rev': '35fc98dd8f9da175ed0a2dcf246299e922e1e1e2',
83+
'dart_webdev_rev': '234e44c2ba0aa6cee5a36026538ca89457bf0d55',
8484
'dart_webdriver_rev': '09104f459ed834d48b132f6b7734923b1fbcf2e9',
8585
'dart_webkit_inspection_protocol_rev': '0f7685804d77ec02c6564d7ac1a6c8a2341c5bdf',
8686

@@ -302,7 +302,7 @@ deps = {
302302
Var('chromium_git') + '/external/github.com/WebAssembly/binaryen.git' + '@' + Var('dart_binaryen_rev'),
303303

304304
'engine/src/flutter/third_party/dart/third_party/devtools':
305-
{'dep_type': 'cipd', 'packages': [{'package': 'dart/third_party/flutter/devtools', 'version': 'git_revision:ed691cae7fb35f6c77950b0e13746893715e4ec8'}]},
305+
{'dep_type': 'cipd', 'packages': [{'package': 'dart/third_party/flutter/devtools', 'version': 'git_revision:bac6843cce3c98d8794a7cce796faaa8860cc00f'}]},
306306

307307
'engine/src/flutter/third_party/dart/third_party/perfetto/src':
308308
Var('android_git') + '/platform/external/perfetto' + '@' + Var('dart_perfetto_rev'),
@@ -341,7 +341,7 @@ deps = {
341341
Var('dart_git') + '/pub.git' + '@' + Var('dart_pub_rev'),
342342

343343
'engine/src/flutter/third_party/dart/third_party/pkg/shelf':
344-
Var('dart_git') + '/shelf.git@b924de80e122d1e17b1132bedb02ddb1445b337c',
344+
Var('dart_git') + '/shelf.git@dd830a0338b31bee92fe7ebc20b9bb963403b6b0',
345345

346346
'engine/src/flutter/third_party/dart/third_party/pkg/sync_http':
347347
Var('dart_git') + '/sync_http.git' + '@' + Var('dart_sync_http_rev'),
@@ -350,7 +350,7 @@ deps = {
350350
Var('dart_git') + '/external/github.com/simolus3/tar.git@13479f7c2a18f499e840ad470cfcca8c579f6909',
351351

352352
'engine/src/flutter/third_party/dart/third_party/pkg/test':
353-
Var('dart_git') + '/test.git@80a49347e4a3dbc3ed70782df5e8c76a67f9256c',
353+
Var('dart_git') + '/test.git@c15153b9618afc4c5e8a43bac43339de130c2149',
354354

355355
'engine/src/flutter/third_party/dart/third_party/pkg/tools':
356356
Var('dart_git') + '/tools.git' + '@' + Var('dart_tools_rev'),
@@ -531,7 +531,7 @@ deps = {
531531
Var('chromium_git') + '/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator' + '@' + 'c788c52156f3ef7bc7ab769cb03c110a53ac8fcb',
532532

533533
'engine/src/third_party/abseil-cpp':
534-
Var('chromium_git') + '/chromium/src/third_party/abseil-cpp' + '@' + '5b92b04a2ed98498a7f03f9234bbad7752445a43',
534+
Var('chromium_git') + '/chromium/src/third_party/abseil-cpp' + '@' + '564023aa53767b5f60b3a556f0a025b7b7e8241e',
535535

536536
# Dart packages
537537
'engine/src/flutter/third_party/pkg/archive':
@@ -810,7 +810,7 @@ deps = {
810810
'packages': [
811811
{
812812
'package': 'fuchsia/sdk/core/linux-amd64',
813-
'version': '3mkBM9XuntkUl3G9lHmerxac4ZfIjyy5I_SD8biFKWEC'
813+
'version': 'u5vxWTRT0HlxOP5_rIPOkUJXTun41aPDWjrw0MQdakkC'
814814
}
815815
],
816816
'condition': 'download_fuchsia_deps and not download_fuchsia_sdk',

0 commit comments

Comments
 (0)