Repository navigation
Commit eb61588
authored
This dep has been abandoned
https://developer.android.com/tools/releases/sdk-tools
Also bumps to include sdk 37, because the underlying script had been bumped without a corresponding bump in the ci.yaml
This is a cherry-pick of #189962 to `beta` branch to ensure tests pass for builds/releases on the beta branch.
Impacted Users: Flutter releng / CI infra team. No direct end-user or app-developer impact. This affects the ability to produce beta/release builds on the arm64 Mac CI bot pool.
Impact Description: The android_sdk CIPD bundle pulls in the ancient, abandoned tools:tools package, whose emulator binary is Intel-only and requires Rosetta to run. We're removing Rosetta from the arm64 Mac CI bot pool, so any CI step that touches that binary will fail on those machines. Without this, we can't remove Rosetta from the prod/dart-internal.flutter bot pools. No impact on flutter apps.
Workaround: The only alternatives are to keep Rosetta installed on the arm64 Mac bots.
Risk: Low. The removed tools:tools package has been abandoned by Android and is not used by the build; the change swaps to the already-published android_sdk version:37v2 CIPD bundle and re-enables a test that was only skipped because of the Intel-only binary. Changes are confined to CI/dependency configuration, the lint baseline, and a single test.
Test Coverage: Yes. The change re-enables the emulator.getEmulators should respond with list daemon test on macOS (previously skipped via #189876), and the existing Android/CI test shards exercise the updated SDK bundle. The commit landed and passed on master as #189962.
Validation Steps:
1. Confirm CI is green on the candidate branch, in particular the Android and macOS shards that consume the android_sdk dependency.
2. Verify the emulator.getEmulators daemon test runs (no longer skipped) and passes on macOS.
3. Post Rosetta-removal: confirm builds succeed on an arm64 Mac bot with Rosetta absent, i.e. no step attempts to invoke the Intel-only tools emulator binary.
Issue: #189876
Issue: #103386
Fixes: #190176 (cherry-pick issue)
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
1 parent 7c7929a commit eb61588
5 files changed
Lines changed: 134 additions & 150 deletions
File tree
- engine/src/flutter/tools
- android_lint
- android_sdk
- packages/flutter_tools/test/commands.shard/hermetic
0 commit comments