Address feedback and update test

TahaTesser · TahaTesser · commit e9e6fc7f966a · 2024-08-13T15:09:56.000+03:00
diff --git a/dev/tools/gen_defaults/lib/slider_template.dart b/dev/tools/gen_defaults/lib/slider_template.dart
@@ -44,7 +44,7 @@ class _${blockName}DefaultsM3 extends SliderThemeData {
   @override
   // TODO(tahatesser): Update this hard-coded value to use the correct token value.
   // https://github.com/flutter/flutter/issues/153271
-  Color? get inactiveTickMarkColor => _colors.primary;
+  Color? get inactiveTickMarkColor => _colors.onSecondaryContainer;
 
   @override
   Color? get disabledActiveTickMarkColor => _colors.${getToken("$tokenGroup.disabled.stop-indicator.color-selected")};
diff --git a/packages/flutter/lib/src/material/slider.dart b/packages/flutter/lib/src/material/slider.dart
@@ -2089,7 +2089,7 @@ class _SliderDefaultsM3 extends SliderThemeData {
   @override
   // TODO(tahatesser): Update this hard-coded value to use the correct token value.
   // https://github.com/flutter/flutter/issues/153271
-  Color? get inactiveTickMarkColor => _colors.primary;
+  Color? get inactiveTickMarkColor => _colors.onSecondaryContainer;
 
   @override
   Color? get disabledActiveTickMarkColor => _colors.onInverseSurface;
diff --git a/packages/flutter/test/material/slider_test.dart b/packages/flutter/test/material/slider_test.dart
@@ -5169,7 +5169,7 @@ void main() {
     RenderBox valueIndicatorBox = tester.renderObject(find.byType(Overlay));
     expect(
       valueIndicatorBox,
-      isNot(paints..scale()..path(color: theme.colorScheme.primary)),
+      isNot(paints..scale()..rrect(color: theme.colorScheme.inverseSurface)),
     );
 
     // Right arrow (increase)
@@ -5183,7 +5183,7 @@ void main() {
     valueIndicatorBox = tester.renderObject(find.byType(Overlay));
     expect(
       valueIndicatorBox,
-      paints..scale()..path(color: theme.colorScheme.primary),
+      paints..scale()..rrect(color: theme.colorScheme.inverseSurface),
     );
 
     // Left arrow (decrease)
@@ -5197,7 +5197,7 @@ void main() {
     valueIndicatorBox = tester.renderObject(find.byType(Overlay));
     expect(
       valueIndicatorBox,
-      paints..scale()..path(color: theme.colorScheme.primary),
+      paints..scale()..rrect(color: theme.colorScheme.inverseSurface),
     );
 
     // Up arrow (increase)
@@ -5211,7 +5211,7 @@ void main() {
     valueIndicatorBox = tester.renderObject(find.byType(Overlay));
     expect(
       valueIndicatorBox,
-      paints..scale()..path(color: theme.colorScheme.primary),
+      paints..scale()..rrect(color: theme.colorScheme.inverseSurface),
     );
 
     // Down arrow (decrease)
@@ -5225,7 +5225,7 @@ void main() {
     valueIndicatorBox = tester.renderObject(find.byType(Overlay));
     expect(
       valueIndicatorBox,
-      paints..scale()..path(color: theme.colorScheme.primary),
+      paints..scale()..rrect(color: theme.colorScheme.inverseSurface),
     );
   }, variant: TargetPlatformVariant.desktop());
 }
diff --git a/packages/flutter/test/material/slider_theme_test.dart b/packages/flutter/test/material/slider_theme_test.dart
@@ -120,7 +120,7 @@ void main() {
     final Color thumbColor = Color(colorScheme.primary.value);
     final Color disabledThumbColor = colorScheme.onSurface.withOpacity(0.38);
     final Color activeTickMarkColor = colorScheme.secondaryContainer;
-    final Color inactiveTickMarkColor = colorScheme.primary;
+    final Color inactiveTickMarkColor = colorScheme.onSecondaryContainer;
     final Color disabledActiveTickMarkColor = colorScheme.onInverseSurface;
     final Color disabledInactiveTickMarkColor = colorScheme.onSurface;
     final Color stopIndicatorColor = colorScheme.primary;
