Repository navigation
Commit e52f01c
authored
[Impeller] Execute PipelineCompileQueue jobs in the order that they were added (#190262)
ContentContext tries to create the most commonly used shaders first. But
previously the PipelineCompileQueue was using an unordered map to store
the shader compilation jobs, which made it iterate through the jobs in
arbitrary order.
This means that the queue may not build the most needed shaders earliest
in the background. If these shaders are not built before the raster
thread needs them, then the raster thread will need to spend time
building them on demand.
This PR changes PipelineCompileQueue to use an Abseil linked hash map
that retains the order in which elements are inserted.
PipelineCompileQueue will then build the shaders in the order that they
were added by ContentContext.1 parent 347b5a0 commit e52f01c
3 files changed
Lines changed: 30 additions & 6 deletions
File tree
- engine/src/flutter/impeller/renderer
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| 101 | + | |
101 | 102 | | |
102 | 103 | | |
103 | 104 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | 8 | | |
11 | 9 | | |
12 | 10 | | |
13 | 11 | | |
| 12 | + | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
| |||
125 | 124 | | |
126 | 125 | | |
127 | 126 | | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
132 | 131 | | |
133 | 132 | | |
134 | 133 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
30 | 32 | | |
31 | 33 | | |
32 | 34 | | |
| |||
92 | 94 | | |
93 | 95 | | |
94 | 96 | | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
95 | 119 | | |
96 | 120 | | |
0 commit comments