Repository navigation
Commit e4cfadc
authored
[stable] [flutter_tools] Handle all DartDevelopmentServiceExceptions gracefully in resident web runner (#191323)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
### Issue Link:
#191179
### Impact Description:
Unhandled `DartDevelopmentServiceException` during web debugging startup causes the Flutter CLI to crash. It emerged as a top crash signature in Flutter 3.47.0 telemetry. It impacts development (crashes the tool when browser exits prematurely or rejects handshake during startup).
### Changelog Description:
[flutter/191179] When WebSocket upgrade fails during DDS startup on Web, handle the DartDevelopmentServiceException gracefully instead of crashing.
### Workaround:
No workaround available; the tool crashes when the error occurs.
### Risk:
What is the risk level of this cherry-pick?
### Test Coverage:
Are you confident that your fix is well-tested by automated tests?
### Validation Steps:
Run unit tests in `resident_web_runner_test.dart`, specifically the new test: "Does not crash if DDS fails to upgrade WebSocket during startup".1 parent 6655482 commit e4cfadc
2 files changed
Lines changed: 29 additions & 5 deletions
File tree
- packages/flutter_tools
- lib/src/isolated
- test/general.shard
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
405 | 405 | | |
406 | 406 | | |
407 | 407 | | |
408 | | - | |
| 408 | + | |
409 | 409 | | |
410 | 410 | | |
411 | 411 | | |
412 | | - | |
413 | | - | |
| 412 | + | |
| 413 | + | |
414 | 414 | | |
415 | | - | |
| 415 | + | |
416 | 416 | | |
417 | 417 | | |
418 | 418 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
275 | 275 | | |
276 | 276 | | |
277 | 277 | | |
278 | | - | |
| 278 | + | |
| 279 | + | |
279 | 280 | | |
280 | 281 | | |
281 | 282 | | |
282 | 283 | | |
283 | 284 | | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
284 | 308 | | |
285 | 309 | | |
286 | 310 | | |
| |||
0 commit comments