Skip to content

Commit e122d5d

Browse files
committed
Revert "Fixes in flutter framework code to address the mixin issue raised"
This reverts commit 1c236d5.
1 parent fb9743d commit e122d5d

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

packages/flutter/lib/src/rendering/proxy_box.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,8 @@ class RenderProxyBox extends RenderBox with RenderObjectWithChildMixin<RenderBox
5151
/// This class can be used as a mixin for situations where the proxying behavior
5252
/// of [RenderProxyBox] is desired but inheriting from [RenderProxyBox] is
5353
/// impractical (e.g. because you want to mix in other classes as well).
54-
/// TODO(ianh): Remove this class once https://github.com/dart-lang/sdk/issues/15101 is fixed
55-
@optionalTypeArgs
56-
abstract class RenderProxyBoxMixin<T extends RenderBox> extends RenderBox with RenderObjectWithChildMixin<T> {
54+
// TODO(ianh): Remove this class once https://github.com/dart-lang/sdk/issues/15101 is fixed
55+
abstract class RenderProxyBoxMixin extends RenderBox with RenderObjectWithChildMixin<RenderBox> {
5756
// This class is intended to be used as a mixin, and should not be
5857
// extended directly.
5958
factory RenderProxyBoxMixin._() => null;

packages/flutter/lib/src/widgets/automatic_keep_alive.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,8 +299,7 @@ class KeepAliveHandle extends ChangeNotifier {
299299
///
300300
/// * [AutomaticKeepAlive], which listens to messages from this mixin.
301301
/// * [KeepAliveNotification], the notifications sent by this mixin.
302-
@optionalTypeArgs
303-
abstract class AutomaticKeepAliveClientMixin<T extends StatefulWidget> extends State<T> {
302+
abstract class AutomaticKeepAliveClientMixin extends State<T> {
304303
// This class is intended to be used as a mixin, and should not be
305304
// extended directly.
306305
factory AutomaticKeepAliveClientMixin._() => null;

packages/flutter/lib/src/widgets/ticker_provider.dart

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ class TickerMode extends InheritedWidget {
7373
/// This mixin only supports vending a single ticker. If you might have multiple
7474
/// [AnimationController] objects over the lifetime of the [State], use a full
7575
/// [TickerProviderStateMixin] instead.
76-
@optionalTypeArgs
77-
abstract class SingleTickerProviderStateMixin<T extends StatefulWidget> extends State<T> implements TickerProvider { // ignore: TYPE_ARGUMENT_NOT_MATCHING_BOUNDS, https://github.com/dart-lang/sdk/issues/25232
76+
abstract class SingleTickerProviderStateMixin extends State<T> implements TickerProvider { // ignore: TYPE_ARGUMENT_NOT_MATCHING_BOUNDS, https://github.com/dart-lang/sdk/issues/25232
7877
// This class is intended to be used as a mixin, and should not be
7978
// extended directly.
8079
factory SingleTickerProviderStateMixin._() => null;
@@ -156,8 +155,12 @@ abstract class SingleTickerProviderStateMixin<T extends StatefulWidget> extends
156155
/// If you only have a single [Ticker] (for example only a single
157156
/// [AnimationController]) for the lifetime of your [State], then using a
158157
/// [SingleTickerProviderStateMixin] is more efficient. This is the common case.
158+
<<<<<<< HEAD
159159
@optionalTypeArgs
160160
abstract class TickerProviderStateMixin<T extends StatefulWidget> extends State<T> implements TickerProvider { // ignore: TYPE_ARGUMENT_NOT_MATCHING_BOUNDS, https://github.com/dart-lang/sdk/issues/25232
161+
=======
162+
abstract class TickerProviderStateMixin extends State<dynamic> implements TickerProvider { // ignore: TYPE_ARGUMENT_NOT_MATCHING_BOUNDS, https://github.com/dart-lang/sdk/issues/25232
163+
>>>>>>> parent of 1c236d524... Fixes in flutter framework code to address the mixin issue raised
161164
// This class is intended to be used as a mixin, and should not be
162165
// extended directly.
163166
factory TickerProviderStateMixin._() => null;

0 commit comments

Comments
 (0)