Skip to content

Commit db6988d

Browse files
nshahannshahan
authored
[tool] Remove web drive hot reload workaround (#9704)
flutter drive for web should no longer need this workaround. See dart-lang/sdk#60289 See #170612 Add charset to some index.html files which is needed in the new DDC module system.
1 parent 7a9e9ce commit db6988d

File tree

10 files changed

+8
-13
lines changed

10 files changed

+8
-13
lines changed

‎packages/camera/camera_web/example/web/index.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
found in the LICENSE file. -->
55
<html>
66
<head>
7+
<meta charset="UTF-8" />
78
<title>Browser Tests</title>
89
</head>
910
<body>

‎packages/file_selector/file_selector_web/example/web/index.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
found in the LICENSE file. -->
55
<html>
66
<head>
7+
<meta charset="UTF-8" />
78
<title>Browser Tests</title>
89
</head>
910
<body>

‎packages/google_maps_flutter/google_maps_flutter_web/example/web/index.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
found in the LICENSE file. -->
55
<html>
66
<head>
7+
<meta charset="UTF-8" />
78
<title>Browser Tests</title>
89
<!-- This API key comes from: go/flutter-maps-web-tests-api-key (GCP project: flutter-infra) -->
910
<script src="https://maps.googleapis.com/maps/api/js?key=AIzaSyAa9cRBkhuxGq3Xw3HPz8SPwaVOhRmm7kk&libraries=geometry,visualization"></script>

‎packages/google_sign_in/google_sign_in_web/example/web/index.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
found in the LICENSE file. -->
55
<html>
66
<head>
7+
<meta charset="UTF-8" />
78
<title>Browser Tests</title>
89
</head>
910
<body>

‎packages/url_launcher/url_launcher_web/example/web/index.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
found in the LICENSE file. -->
55
<html>
66
<head>
7+
<meta charset="UTF-8" />
78
<title>Browser Tests</title>
89
</head>
910
<body>

‎packages/webview_flutter/webview_flutter/example/assets/www/index.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
found in the LICENSE file. -->
55
<html lang="en">
66
<head>
7+
<meta charset="UTF-8" />
78
<title>Load file or HTML string example</title>
89
<link rel="stylesheet" href="styles/style.css" />
910
</head>

‎packages/webview_flutter/webview_flutter_android/example/assets/www/index.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
found in the LICENSE file. -->
55
<html lang="en">
66
<head>
7+
<meta charset="UTF-8" />
78
<title>Load file or HTML string example</title>
89
<link rel="stylesheet" href="styles/style.css" />
910
</head>

‎packages/webview_flutter/webview_flutter_wkwebview/example/assets/www/index.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
found in the LICENSE file. -->
55
<html lang="en">
66
<head>
7+
<meta charset="UTF-8" />
78
<title>Load file or HTML string example</title>
89
<link rel="stylesheet" href="styles/style.css" />
910
</head>

‎script/tool/lib/src/drive_examples_command.dart‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,10 +140,6 @@ class DriveExamplesCommand extends PackageLoopingCommand {
140140
platformWeb: <String>[
141141
'-d',
142142
'web-server',
143-
// TODO(stuartmorgan): Remove once drive works without it. See
144-
// https://github.com/dart-lang/sdk/issues/60289 and
145-
// https://github.com/flutter/flutter/pull/169174
146-
'--no-web-experimental-hot-reload',
147143
'--web-port=7357',
148144
'--browser-name=chrome',
149145
if (useWasm) '--wasm',

‎script/tool/test/drive_examples_command_test.dart‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -840,7 +840,6 @@ void main() {
840840
'drive',
841841
'-d',
842842
'web-server',
843-
'--no-web-experimental-hot-reload',
844843
'--web-port=7357',
845844
'--browser-name=chrome',
846845
'--screenshot=/path/to/logs/plugin_example-drive',
@@ -892,7 +891,6 @@ void main() {
892891
'drive',
893892
'-d',
894893
'web-server',
895-
'--no-web-experimental-hot-reload',
896894
'--web-port=7357',
897895
'--browser-name=chrome',
898896
'--wasm',
@@ -943,7 +941,6 @@ void main() {
943941
'drive',
944942
'-d',
945943
'web-server',
946-
'--no-web-experimental-hot-reload',
947944
'--web-port=7357',
948945
'--browser-name=chrome',
949946
'--screenshot=/path/to/logs/plugin_example-drive',
@@ -996,7 +993,6 @@ void main() {
996993
'drive',
997994
'-d',
998995
'web-server',
999-
'--no-web-experimental-hot-reload',
1000996
'--web-port=7357',
1001997
'--browser-name=chrome',
1002998
'--chrome-binary=/path/to/chrome',
@@ -1448,7 +1444,6 @@ void main() {
14481444
'drive',
14491445
'-d',
14501446
'web-server',
1451-
'--no-web-experimental-hot-reload',
14521447
'--web-port=7357',
14531448
'--browser-name=chrome',
14541449
'--screenshot=/path/to/logs/plugin_example-drive',
@@ -1464,7 +1459,6 @@ void main() {
14641459
'drive',
14651460
'-d',
14661461
'web-server',
1467-
'--no-web-experimental-hot-reload',
14681462
'--web-port=7357',
14691463
'--browser-name=chrome',
14701464
'--screenshot=/path/to/logs/plugin_example-drive',
@@ -1564,7 +1558,6 @@ void main() {
15641558
'drive',
15651559
'-d',
15661560
'web-server',
1567-
'--no-web-experimental-hot-reload',
15681561
'--web-port=7357',
15691562
'--browser-name=chrome',
15701563
'--screenshot=/path/to/logs/a_package_example-drive',
@@ -1610,7 +1603,6 @@ void main() {
16101603
'drive',
16111604
'-d',
16121605
'web-server',
1613-
'--no-web-experimental-hot-reload',
16141606
'--web-port=7357',
16151607
'--browser-name=chrome',
16161608
'--driver',
@@ -1690,7 +1682,6 @@ void main() {
16901682
'drive',
16911683
'-d',
16921684
'web-server',
1693-
'--no-web-experimental-hot-reload',
16941685
'--web-port=7357',
16951686
'--browser-name=chrome',
16961687
'--screenshot=/path/to/logs/a_package_example_with_web-drive',

0 commit comments

Comments
 (0)